WebServer.h/cpp don't seem to represent the actual implementation in the library

[wishwamithra]

Board

The repo itself

Device Description

No need of a device description. I am questioning the content of this repo.

Hardware Configuration

No need of hardware configuration. I am questioning the content of this repo.

Version

latest master (checkout manually)

IDE Name

Arduino IDE

Operating System

N/A

Flash frequency

N/A

PSRAM enabled

yes

Upload speed

9600

Description

I don't think the repo shows the true implementation of the library, especially w.r.t. WebServer (https://github.com/espressif/arduino-esp32/blob/master/libraries/WebServer/src/WebServer.h). Here is the proof:

1. I see only two references to WebServer::handleClient() function in this repo. First, in the declaration in WebServer.h file, and then in the WebServer.cpp file. Where is this function used (get called)?
2. Check what the uses of variables _firstHandler, _lastHandler and _currentHandler are. _firstHandler and _lastHandler are set, but never used. In contrast, _currentHandler is used, but never set.

Sketch

No need of a sketch. I am questioning the content of this repo.

Debug Message

No need of a debug messaage. I am questioning the content of this repo.

Other Steps to Reproduce

No response

I have checked existing issues, online documentation and the Troubleshooting Guide

• I confirm I have checked existing issues, online documentation and Troubleshooting guide.

[JAndrassy]

arduino-esp32/libraries/WebServer/examples/HelloServer/HelloServer.ino

Line 72 in ebca505

server.handleClient();

arduino-esp32/libraries/WebServer/src/WebServer.cpp

Lines 356 to 365 in ebca505

	void WebServer::_addRequestHandler(RequestHandler* handler) {
	if (!_lastHandler) {
	_firstHandler = handler;
	_lastHandler = handler;
	}
	else {
	_lastHandler->next(handler);
	_lastHandler = handler;
	}
	}

[wishwamithra]

arduino-esp32/libraries/WebServer/examples/HelloServer/HelloServer.ino

Line 72 in ebca505

server.handleClient();

arduino-esp32/libraries/WebServer/src/WebServer.cpp

Lines 356 to 365 in ebca505

	void WebServer::_addRequestHandler(RequestHandler* handler) {
	if (!_lastHandler) {
	_firstHandler = handler;
	_lastHandler = handler;
	}
	else {
	_lastHandler->next(handler);
	_lastHandler = handler;
	}
	}

Thank you. So, for the first question, the answer is that the application should call handleClient(). But for the second question, where is _firstHandler and _lastHandler used. I see the places where its values are set, but can't see a place they are used for anything. Even in your answer, it shows where the values are set. What is the use of these variables. And as for _currentHandler, it is only used, but not set in any place of the code. Given these variables are protected variables, an application cannot use them directly either, when they create WebServer object. Appreciate if you could shed some light on this too.

[JAndrassy]

_addRequestHandler uses _lastHandler
and this is missing in my previous comment

arduino-esp32/libraries/WebServer/src/Parsing.cpp

Line 126 in ebca505

for (handler = _firstHandler; handler; handler = handler->next()) {