Merge TASK-015: http_request_impl skeleton (PIMPL split, structural only)

Brings in:
- e9175c1 TASK-015: http_request_impl skeleton (PIMPL split, structural only)
- fd6c984 TASK-015: wire test-request fallback through http_request_impl
- 01c425b TASK-015: housekeeping (review record)

Author: etr

specs/tasks/M3-request/TASK-015.md

@@ -8,11 +8,11 @@
 Move `http_request`'s backend-coupled members (`MHD_Connection*`, raw GnuTLS handle, computed caches) into `detail/http_request_impl.hpp` behind a `std::unique_ptr<http_request_impl>`. No API rename yet.
 
 **Action Items:**
-- [ ] Create `src/httpserver/detail/http_request_impl.hpp` (gated `HTTPSERVER_COMPILATION` only).
-- [ ] Move all backend-coupled state into the impl struct: `MHD_Connection* conn_`, `gnutls_session_t tls_session_`, parsed-args cache, headers cache, etc.
-- [ ] Public `http_request.hpp` declares `std::unique_ptr<http_request_impl> impl_;` and forward-declares the impl class.
-- [ ] Implement existing public methods as forwarders to `impl_->method()`.
-- [ ] Move `<microhttpd.h>`, `<gnutls/gnutls.h>` includes from public `http_request.hpp` into `http_request_impl.hpp` and `http_request.cpp`.
+- [x] Create `src/httpserver/detail/http_request_impl.hpp` (gated `HTTPSERVER_COMPILATION` only).
+- [x] Move all backend-coupled state into the impl struct: `MHD_Connection* conn_`, `gnutls_session_t tls_session_`, parsed-args cache, headers cache, etc.
+- [x] Public `http_request.hpp` declares `std::unique_ptr<http_request_impl> impl_;` and forward-declares the impl class.
+- [x] Implement existing public methods as forwarders to `impl_->method()`.
+- [x] Move `<microhttpd.h>`, `<gnutls/gnutls.h>` includes from public `http_request.hpp` into `http_request_impl.hpp` and `http_request.cpp`.
 
 **Dependencies:**
 - Blocked by: TASK-002, TASK-014
@@ -28,4 +28,4 @@ Move `http_request`'s backend-coupled members (`MHD_Connection*`, raw GnuTLS han
 **Related Requirements:** PRD-HDR-REQ-001..004
 **Related Decisions:** DR-003b, §4.2
 
-**Status:** Not Started
+**Status:** In Progress

specs/tasks/_index.md

@@ -97,7 +97,7 @@ Nominally: **13 sequential tasks**, each S–XL. Most other tasks parallelize of
 | TASK-012 | `http_response` fluent `with_*` setters | M2 | Done | TASK-009 |
 | TASK-013 | Remove `*_response` subclasses and dispatch virtuals | M2 | Done | TASK-009, TASK-010, TASK-011, TASK-012 |
 | TASK-014 | `webserver_impl` skeleton (PIMPL prep) | M3 | In Progress | TASK-002 |
-| TASK-015 | `http_request_impl` skeleton (PIMPL split) | M3 | Not Started | TASK-002, TASK-014 |
+| TASK-015 | `http_request_impl` skeleton (PIMPL split) | M3 | In Progress | TASK-002, TASK-014 |
 | TASK-016 | Per-connection arena for `http_request_impl` | M3 | Not Started | TASK-014, TASK-015 |
 | TASK-017 | `http_request` container getters return `const&` | M3 | Not Started | TASK-015 |
 | TASK-018 | `http_request` single-key getters return `string_view`, all const | M3 | Not Started | TASK-015, TASK-016 |

specs/unworked_review_issues/2026-05-04_211034_task-015.md

@@ -19,12 +19,12 @@
 AM_CPPFLAGS = -I../ -I$(srcdir)/httpserver/ -DHTTPSERVER_COMPILATION
 METASOURCES = AUTO
 lib_LTLIBRARIES = libhttpserver.la
-libhttpserver_la_SOURCES = string_utilities.cpp webserver.cpp http_utils.cpp file_info.cpp http_request.cpp http_response.cpp http_resource.cpp create_webserver.cpp detail/http_endpoint.cpp detail/body.cpp
+libhttpserver_la_SOURCES = string_utilities.cpp webserver.cpp http_utils.cpp file_info.cpp http_request.cpp http_response.cpp http_resource.cpp create_webserver.cpp create_test_request.cpp detail/http_endpoint.cpp detail/body.cpp
 # noinst_HEADERS: shipped in the tarball but NEVER installed under $prefix/include.
 # Detail headers (httpserver/detail/*.hpp) live here so they cannot leak to
 # downstream consumers — the public surface comes in through <httpserver.hpp>.
-noinst_HEADERS = httpserver/string_utilities.hpp httpserver/detail/modded_request.hpp httpserver/detail/http_endpoint.hpp httpserver/detail/body.hpp httpserver/detail/webserver_impl.hpp gettext.h
-nobase_include_HEADERS = httpserver.hpp httpserver/body_kind.hpp httpserver/constants.hpp httpserver/create_webserver.hpp httpserver/webserver.hpp httpserver/http_utils.hpp httpserver/file_info.hpp httpserver/http_request.hpp httpserver/http_response.hpp httpserver/http_resource.hpp httpserver/feature_unavailable.hpp httpserver/iovec_entry.hpp httpserver/http_arg_value.hpp httpserver/http_method.hpp
+noinst_HEADERS = httpserver/string_utilities.hpp httpserver/detail/modded_request.hpp httpserver/detail/http_endpoint.hpp httpserver/detail/body.hpp httpserver/detail/webserver_impl.hpp httpserver/detail/http_request_impl.hpp gettext.h
+nobase_include_HEADERS = httpserver.hpp httpserver/body_kind.hpp httpserver/constants.hpp httpserver/create_webserver.hpp httpserver/create_test_request.hpp httpserver/webserver.hpp httpserver/http_utils.hpp httpserver/file_info.hpp httpserver/http_request.hpp httpserver/http_response.hpp httpserver/http_resource.hpp httpserver/feature_unavailable.hpp httpserver/iovec_entry.hpp httpserver/http_arg_value.hpp httpserver/http_method.hpp
 
 if HAVE_WEBSOCKET
 libhttpserver_la_SOURCES += websocket_handler.cpp

src/Makefile.am

@@ -20,7 +20,9 @@
 */
 
 #include "httpserver/create_test_request.hpp"
+#include "httpserver/detail/http_request_impl.hpp"
 
+#include <memory>
 #include <string>
 #include <utility>
 
@@ -29,40 +31,44 @@ namespace httpserver {
 http_request create_test_request::build() {
     http_request req;
 
+    // Allocate an impl for this test request (connection_ stays null,
+    // indicating the test-request path to all MHD-touching accessors).
+    req.impl_ = std::make_unique<detail::http_request_impl>();
+
     req.set_method(_method);
     req.set_path(_path);
     req.set_version(_version);
     req.set_content(_content);
 
-    req.headers_local = std::move(_headers);
-    req.footers_local = std::move(_footers);
-    req.cookies_local = std::move(_cookies);
+    req.impl_->headers_local = std::move(_headers);
+    req.impl_->footers_local = std::move(_footers);
+    req.impl_->cookies_local = std::move(_cookies);
 
     for (auto& [key, values] : _args) {
         for (auto& value : values) {
-            req.cache->unescaped_args[key].push_back(std::move(value));
+            req.impl_->unescaped_args[key].push_back(std::move(value));
         }
     }
-    req.cache->args_populated = true;
+    req.impl_->args_populated = true;
 
     if (!_querystring.empty()) {
-        req.cache->querystring = std::move(_querystring);
+        req.impl_->querystring = std::move(_querystring);
     }
 
 #ifdef HAVE_BAUTH
-    req.cache->username = std::move(_user);
-    req.cache->password = std::move(_pass);
+    req.impl_->username = std::move(_user);
+    req.impl_->password = std::move(_pass);
 #endif  // HAVE_BAUTH
 
 #ifdef HAVE_DAUTH
-    req.cache->digested_user = std::move(_digested_user);
+    req.impl_->digested_user = std::move(_digested_user);
 #endif  // HAVE_DAUTH
 
-    req.cache->requestor_ip = std::move(_requestor);
-    req.requestor_port_local = _requestor_port;
+    req.impl_->requestor_ip = std::move(_requestor);
+    req.impl_->requestor_port_local = _requestor_port;
 
 #ifdef HAVE_GNUTLS
-    req.tls_enabled_local = _tls_enabled;
+    req.impl_->tls_enabled_local = _tls_enabled;
 #endif  // HAVE_GNUTLS
 
     return req;