diff --git a/README.md b/README.md index 27760f9..8ad79e0 100644 --- a/README.md +++ b/README.md @@ -1,69 +1,146 @@ # Exercism ReScript Track -[![Configlet](https://github.com/exercism/rescript/actions/workflows/configlet.yml/badge.svg)](https://github.com/exercism/rescript/actions/workflows/configlet.yml) [![Test](https://github.com/exercism/rescript/actions/workflows/test.yml/badge.svg)](https://github.com/exercism/rescript/actions/workflows/test.yml) +[![Configlet](https://github.com/exercism/rescript/actions/workflows/configlet.yml/badge.svg)](https://github.com/exercism/rescript/actions/workflows/configlet.yml) +[![Test](https://github.com/exercism/rescript/actions/workflows/test.yml/badge.svg)](https://github.com/exercism/rescript/actions/workflows/test.yml) Exercism exercises in ReScript. -## Testing +## Installation + +Track exercises target [ReScript] 12.2.0 using the [ReScript Test][ReScriptTest] testing framework on [Node.js] 22+. If you're contributing to the track, you will also need [make]. + +### Setting up the development environment -To test all exercises, run `./bin/verify-exercises`. -This command will iterate over all exercises and check to see if their exemplar/example implementation passes all the tests. +Run the following commands from inside the project root directory to install the required tools: + +```shell +npm install +git submodule update --init --recursive # add/update a local copy of the problem-specification submodule +``` -To test a single exercise, run `./bin/verify-exercises `. +To automate the creation of practice exercise tests, our track tooling consumes data from the the [problem specifications][exercism-problem-specifications-link] submodule. Because these specifications serve as the canonical source for all Exercism tracks, any upstream updates ensure our test cases remain consistent with the global exercise standard. -### Using Docker +If you have format on save enabled for JSON files, it is recommended to disable this feature. Alternatively save JSON files with `Ctrl+K s` to save without applying formatting rules. -If your track has a working [test runner](https://exercism.org/docs/building/tooling/test-runners), the `./bin/verify-exercises-in-docker` script can also be used to test all exercises. -This script pulls (_downloads_) the test runner's [Docker image](https://exercism.org/docs/building/tooling/test-runners/docker) and then uses Docker to run that image to test an exercise. +### Running the development environment -```exercism/note -The main benefit of this approach is that it best mimics how exercises are tested in production (on the website). -Another benefit is that you don't have to install track-specific dependencies (e.g. an SDK) locally, you just need Docker installed. +Open up two terminals. By running the commands below, files will compile on save and re-run the test suite. + +```shell +# Terminal 1 +npm run res:start + +# Terminal 2 +npm run test ``` -To test a single exercise, run `./bin/verify-exercises-in-docker `. +## Adding Exercises -### Linting +Documentation on contributing to Exercism can be found [here][exercism-contributing-docs-link]. -[`configlet`](https://exercism.org/docs/building/configlet) is an Exercism-wide tool for working with tracks. You can download it by running: +New practice exercises can be added via: ```shell -$ ./bin/fetch-configlet +bin/add-practice-exercise + +# Optionally, you can also specify the exercise's difficulty (via `-d`) and/or author's GitHub username (via `-a`): +bin/add-practice-exercise -a foobar -d 3 ``` -Run its [`lint` command](https://exercism.org/docs/building/configlet/lint) to verify if exercises have the required files and if config files are correct: +Now complete the following steps: + +- `config.json` - ensure that the new exercise data is correctly placed in order of difficulty and then alphabetically within that difficulty rating. +- implement exercise test cases, detailed in the [testing](#testing) section below. +- `exercises/practice//.meta/.res` - write an example of code here that will pass all test cases. This does not need to be the finest example of how to complete this exercise, but it must pass all the test cases. Update the interface file with the exposed function signatures in the `.resi` file. +- `exercises/practice//wrc/.res` - create an exercise stub here which returns `panic("'' has not been implemented")`. Update the interface file with the function signatures, so that the student has a reference to what names and types are used. + +## Testing + +Tests are written using [rescript-test][ReScriptTest]. There is a test templating system in place to reduce the amount of work needed by a developer. Follow these steps when writing tests: + +- `exercises/practice//.meta/tests.toml` - if any of these test cases are not relevant to the language, add `ignore = true` on a newline below the description +- `exercises/practice//.meta/testTemplate.js` - edit this file to allow the test generator to automatically create test files. + - you must write your comparator functions - https://bloodyowl.github.io/rescript-test/assertions. + - common assertions with comparator functions are located at `test_generator/assertions.js`. Pass the required ones into the `assertionFunctions` array. + - edit the `template` function so that it will generate the test cases. The `c` variable refers to a test case in `problem-specifications/exercises//canonical-data.json`. Look at other exercise test templates for inspiration. + +Run all exercise tests: ```shell -$ ./bin/configlet lint - -The lint command is under development. -Please re-run this command regularly to see if your track passes the latest linting rules. - -Basic linting finished successfully: -- config.json exists and is valid JSON -- config.json has these valid fields: - language, slug, active, blurb, version, status, online_editor, key_features, tags -- Every concept has the required .md files -- Every concept has a valid links.json file -- Every concept has a valid .meta/config.json file -- Every concept exercise has the required .md files -- Every concept exercise has a valid .meta/config.json file -- Every practice exercise has the required .md files -- Every practice exercise has a valid .meta/config.json file -- Required track docs are present -- Required shared exercise docs are present +make test ``` -## Adding exercises +This command will iterate over all exercises and check to see if their example implementation passes all the tests. -New (practice) exercises can be added via: +To test that all exercises will pass in the CI/CD environment, run: ```shell -bin/add-practice-exercise +./bin/verify-exercises + +# test a single exercise: +./bin/verify-exercises +``` + +## Coding Style + +Use `PascalCase.res` for ReScript implementation file names. +A ReScript interface file (`.resi`) should be included with every exercise to help the user get started. + +Run `make format` on your code before pushing. + +If you are using VS Code, install the official [ReScript VS Code extension][rescript-vs-code-extension] for syntax highlighting and code formatting. + +## Linting & Formatting + +[`configlet`][configlet] is an Exercism-wide tool for working with tracks. You can download it by running: + +```shell +./bin/fetch-configlet ``` -Optionally, you can also specify the exercise's difficulty (via `-d`) and/or author's GitHub username (via `-a`): +Run the [`lint` command][configlet-link-link] to verify if exercises have the required files and if config files are correct. Address any issues before pushing your changes: ```shell -bin/add-practice-exercise -a foobar -d 3 +./bin/configlet lint +``` + +Run the [`fmt` command][configlet-fmt-link] to verify if exercises and configuration files are formatted correctly. Address any issues before pushing your changes: + +```shell +./bin/configlet fmt + +# check a single exercise +./bin/configlet fmt -e + +# auto format files +./bin/configlet fmt -u ``` + +If you are auto formatting files, only commit the files relevant to your pull request. + +## Pull Requests + +Familiarise yourself with the Exercism [documentation][exercism-pr-docs-link] on pull requests. + +Make sure your work is commited on a new branch. When you are ready to submit your changes, push your changes to your forked repository and open a pull request on the language track [repository]. + +More details on how to create pull requests from a fork can be found [here][github-fork-pr-link]. + +## Feedback + +If you find this documentation is inaccurate or incomplete, or can be improved in any way, please don't hesitate to raise an [issue][issue-link] or submit a pull request. + +[ReScript]: https://rescript-lang.org/ +[ReScriptTest]: https://bloodyowl.github.io/rescript-test/ +[Node.js]: https://nodejs.org/ +[repository]: https://github.com/exercism/rescript +[issue-link]: https://github.com/exercism/rescript/issues +[configlet-lint-link]: https://exercism.org/docs/building/configlet/lint +[configlet-fmt-link]: https://exercism.org/docs/building/configlet/fmt +[github-fork-pr-link]: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/proposing-changes-to-your-work-with-pull-requests/creating-a-pull-request-from-a-fork +[exercism-pr-docs-link]: https://exercism.org/docs/building/github/contributors-pull-request-guide +[exercism-contributing-docs-link]: https://exercism.org/docs/building +[exercism-problem-specifications-link]: https://github.com/exercism/problem-specifications +[configlet]: https://exercism.org/docs/building/configlet +[make]: https://www.gnu.org/software/make/ +[rescript-vs-code-extension]: https://marketplace.visualstudio.com/items?itemName=chenglou92.rescript-vscode diff --git a/exercises/practice/anagram/.meta/config.json b/exercises/practice/anagram/.meta/config.json index 580756c..bd897f8 100644 --- a/exercises/practice/anagram/.meta/config.json +++ b/exercises/practice/anagram/.meta/config.json @@ -21,7 +21,7 @@ ".meta/Anagram.resi" ] }, - "blurb": "Given a word and a list of possible anagrams, select the correct sublist.", + "blurb": "Find the words that use the same letters as another word.", "source": "Inspired by the Extreme Startup game", "source_url": "https://github.com/rchatley/extreme_startup" } diff --git a/exercises/practice/isogram/.meta/config.json b/exercises/practice/isogram/.meta/config.json index 099952b..78201e7 100644 --- a/exercises/practice/isogram/.meta/config.json +++ b/exercises/practice/isogram/.meta/config.json @@ -15,7 +15,7 @@ ".meta/Isogram.resi" ] }, - "blurb": "Determine if a word or phrase is an isogram.", + "blurb": "Determine whether a phrase is an isogram, a word with no repeated letters.", "source": "Wikipedia", "source_url": "https://en.wikipedia.org/wiki/Isogram" } diff --git a/exercises/practice/pangram/.meta/config.json b/exercises/practice/pangram/.meta/config.json index 1e43332..3cbe128 100644 --- a/exercises/practice/pangram/.meta/config.json +++ b/exercises/practice/pangram/.meta/config.json @@ -15,7 +15,7 @@ ".meta/Pangram.resi" ] }, - "blurb": "Determine if a sentence is a pangram.", + "blurb": "Determine whether a phrase uses every letter in the Latin alphabet.", "source": "Wikipedia", "source_url": "https://en.wikipedia.org/wiki/Pangram" }