QueryParams are not re-appended in fromParameters

[traineira]

Prerequisites

• I have written a descriptive issue title
• I have searched existing issues to ensure the bug has not already been reported

Fastify version

5.8.2

Plugin version

11.4.1

Node.js version

latest

Operating system

macOS

Operating system version (i.e. 20.04, 11.3, 10)

15.3.1

Description

QueryParams are not re-appended in fromParameters if the prefix does not include ":", here

This way we loose the queryParams when we use this function.

Link to code that reproduces the bug

https://github.com/fastify/fastify-http-proxy/blob/204a3d0b58de717695cbec615efbf11b255b9507/index.js#L725

Expected Behavior

The queryParams should be re-appended in both scenarios. We should add here the following

if (queryParams) {
  dest += `?${qs.stringify(queryParams)}`
}

and remove from here

[Eomm]

The link is 404: https://github.com/fastify/fastify-http-proxy/blob/204a3d0b58de717695cbec615efbf11b255b9507/index.js#L725

Could you provide a minimal reproducible code snippet?

[traineira]

Oh sorry,
Here is a snippet of code that can be used to reproduce:

import proxy from "@fastify/http-proxy";
await app.register(proxy, {
  upstream: "https://localhost:8000",
  prefix: "/prefix",
  rewritePrefix: "/api",
  preHandler: async (request, reply):  Promise<void> => {
    const proxyUrl = "/v2/api/prefix";
    const proxiedReply = reply.fromParameters(
    request.url,
    request.params,
    proxyUrl
  ); 
// operations with proxiedReply result
});

When using the proxy with an URL that has queryParams(e.g. "https://localhost:8080/api/prefix/path?foo=bar" reply.fromParameters will return an url without the queryParams

[rozzilla]

@Eomm can you have a look? 🙏🏼 #451