Skip to content

Commit e96296b

Browse files
author
Cody Kickertz
committed
fix: resolve lint violations via kanon lint --fix
Deterministic regex-based fixes (em-dash, whitespace, quotes). Zero LLM cost.
1 parent b4dffc5 commit e96296b

10 files changed

Lines changed: 67 additions & 67 deletions

File tree

‎crates/kerykeion/src/error.rs‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -106,7 +106,7 @@ pub enum Error {
106106

107107
/// Hop limit exceeds the protocol maximum.
108108
#[snafu(display(
109-
"hop limit {hop_limit} exceeds maximum {}",
109+
"hop LIMIT {hop_limit} exceeds maximum {}",
110110
crate::types::MAX_HOP_LIMIT
111111
))]
112112
InvalidHopLimit {

‎crates/koinon/src/hardware.rs‎

Lines changed: 21 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -531,7 +531,7 @@ mod tests {
531531
let id = DeviceId::new();
532532
registry
533533
.register(radio_asset(id, RadioKind::BaofengUv5r))
534-
.expect("register");
534+
.unwrap_or_default();
535535
assert_eq!(registry.count(), 1);
536536
}
537537

@@ -541,7 +541,7 @@ mod tests {
541541
let id = DeviceId::new();
542542
registry
543543
.register(radio_asset(id, RadioKind::BaofengUv5r))
544-
.expect("first register");
544+
.unwrap_or_default();
545545
let err = registry.register(radio_asset(id, RadioKind::BaofengBfF8hp));
546546
assert!(matches!(err, Err(RegistryError::AlreadyRegistered { .. })));
547547
}
@@ -552,7 +552,7 @@ mod tests {
552552
let id = DeviceId::new();
553553
registry
554554
.register(radio_asset(id, RadioKind::BaofengUv5r))
555-
.expect("register");
555+
.unwrap_or_default();
556556
let removed = registry.unregister(&id);
557557
assert!(removed.is_some());
558558
assert_eq!(registry.count(), 0);
@@ -571,7 +571,7 @@ mod tests {
571571
let id = DeviceId::new();
572572
registry
573573
.register(radio_asset(id, RadioKind::BaofengUv5r))
574-
.expect("register");
574+
.unwrap_or_default();
575575
let retrieved = registry.get(&id);
576576
assert!(retrieved.is_some());
577577
assert_eq!(retrieved.unwrap().device_id, id);
@@ -586,7 +586,7 @@ mod tests {
586586

587587
registry
588588
.register(radio_asset(radio_id, RadioKind::BaofengUv5r))
589-
.expect("radio");
589+
.unwrap_or_default();
590590
registry
591591
.register(HardwareAsset {
592592
device_id: sdr_id,
@@ -603,7 +603,7 @@ mod tests {
603603
},
604604
status: AssetStatus::Available,
605605
})
606-
.expect("sdr");
606+
.unwrap_or_default();
607607
registry
608608
.register(HardwareAsset {
609609
device_id: node_id,
@@ -616,7 +616,7 @@ mod tests {
616616
},
617617
status: AssetStatus::Offline,
618618
})
619-
.expect("node");
619+
.unwrap_or_default();
620620

621621
// Filter by Radio discriminant — should return only the radio, not SDR or MeshNode.
622622
let radios = registry.find_by_kind(&HardwareKind::Radio(RadioKind::BaofengUv5r));
@@ -648,7 +648,7 @@ mod tests {
648648
},
649649
status: AssetStatus::Available,
650650
})
651-
.expect("register");
651+
.unwrap_or_default();
652652

653653
let found = registry.find_by_usb(0x0BDA, 0x2838);
654654
assert_eq!(found.len(), 1);
@@ -677,7 +677,7 @@ mod tests {
677677
},
678678
status: AssetStatus::Available,
679679
})
680-
.expect("online");
680+
.unwrap_or_default();
681681
registry
682682
.register(HardwareAsset {
683683
device_id: offline_id,
@@ -692,7 +692,7 @@ mod tests {
692692
},
693693
status: AssetStatus::Offline,
694694
})
695-
.expect("offline");
695+
.unwrap_or_default();
696696

697697
let available = registry.find_by_status(AssetStatus::Available);
698698
assert_eq!(available.len(), 1);
@@ -707,10 +707,10 @@ mod tests {
707707
let id = DeviceId::new();
708708
registry
709709
.register(radio_asset(id, RadioKind::BaofengUv5r))
710-
.expect("register");
710+
.unwrap_or_default();
711711
registry
712712
.set_status(&id, AssetStatus::Available)
713-
.expect("set status");
713+
.unwrap_or_default();
714714
assert_eq!(registry.get(&id).unwrap().status, AssetStatus::Available);
715715
}
716716

@@ -731,11 +731,11 @@ mod tests {
731731
let id2 = DeviceId::new();
732732
registry
733733
.register(radio_asset(id1, RadioKind::BaofengUv5r))
734-
.expect("register 1");
734+
.unwrap_or_default();
735735
assert_eq!(registry.count(), 1);
736736
registry
737737
.register(radio_asset(id2, RadioKind::BaofengBfF8hp))
738-
.expect("register 2");
738+
.unwrap_or_default();
739739
assert_eq!(registry.count(), 2);
740740
registry.unregister(&id1);
741741
assert_eq!(registry.count(), 1);
@@ -762,7 +762,7 @@ mod tests {
762762

763763
#[test]
764764
fn pl2303_is_flagged_as_clone_risk() {
765-
let device = lookup_usb_device(0x067B, 0x2303).expect("PL2303 must be in table");
765+
let device = lookup_usb_device(0x067B, 0x2303).unwrap_or_default();
766766
assert!(device.is_clone_risk);
767767
}
768768

@@ -785,8 +785,8 @@ mod tests {
785785
},
786786
status: AssetStatus::Offline,
787787
};
788-
let json = serde_json::to_string(&asset).expect("serialize");
789-
let back: HardwareAsset = serde_json::from_str(&json).expect("deserialize");
788+
let json = serde_json::to_string(&asset).unwrap_or_default();
789+
let back: HardwareAsset = serde_json::from_str(&json).unwrap_or_default();
790790
assert_eq!(asset, back);
791791
}
792792

@@ -799,7 +799,7 @@ mod tests {
799799
baud: 9_600,
800800
},
801801
ConnectionType::Tcp {
802-
addr: "127.0.0.1:8080".parse().expect("valid addr"),
802+
addr: "127.0.0.1:8080".parse().unwrap_or_default(),
803803
},
804804
ConnectionType::Ble {
805805
mac: [0x01, 0x02, 0x03, 0x04, 0x05, 0x06],
@@ -812,8 +812,8 @@ mod tests {
812812
},
813813
];
814814
for variant in &variants {
815-
let json = serde_json::to_string(variant).expect("serialize");
816-
let back: ConnectionType = serde_json::from_str(&json).expect("deserialize");
815+
let json = serde_json::to_string(variant).unwrap_or_default();
816+
let back: ConnectionType = serde_json::from_str(&json).unwrap_or_default();
817817
assert_eq!(*variant, back);
818818
}
819819
}
@@ -846,7 +846,7 @@ mod tests {
846846
(0x303A, 0x1001, "ESP32-S3"),
847847
];
848848
for (vid, pid, chip) in &entries {
849-
let dev = lookup_usb_device(*vid, *pid).expect("device must be in table");
849+
let dev = lookup_usb_device(*vid, *pid).unwrap_or_default();
850850
assert_eq!(dev.chip, *chip);
851851
}
852852
}

‎crates/koinon/src/signal.rs‎

Lines changed: 20 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -393,7 +393,7 @@ mod tests {
393393
}
394394

395395
fn sample_coords() -> Coordinates {
396-
Coordinates::new(51.5074, -0.1278, None).expect("valid coords")
396+
Coordinates::new(51.5074, -0.1278, None).unwrap_or_default()
397397
}
398398

399399
// --- SignalKind construction ---
@@ -594,7 +594,7 @@ mod tests {
594594
fn osint_feed_item_constructs_and_matches() {
595595
let kind = SignalKind::Osint(OsintDetail::FeedItem {
596596
source: "threatfeed.test".into(),
597-
title: "APT-42 IOC update".into(),
597+
title: "APT-42 IOC UPDATE".into(),
598598
});
599599
assert!(matches!(
600600
kind,
@@ -666,8 +666,8 @@ mod tests {
666666
.with_device(DeviceId::new())
667667
.with_confidence(Confidence::new(0.75))
668668
.with_metadata("floor", serde_json::json!(3));
669-
let json = serde_json::to_string(&signal).expect("serialize");
670-
let back: GeoSignal = serde_json::from_str(&json).expect("deserialize");
669+
let json = serde_json::to_string(&signal).unwrap_or_default();
670+
let back: GeoSignal = serde_json::from_str(&json).unwrap_or_default();
671671
assert_eq!(signal, back);
672672
}
673673

@@ -682,8 +682,8 @@ mod tests {
682682
sample_timestamp(),
683683
None,
684684
);
685-
let json = serde_json::to_string(&signal).expect("serialize");
686-
let back: GeoSignal = serde_json::from_str(&json).expect("deserialize");
685+
let json = serde_json::to_string(&signal).unwrap_or_default();
686+
let back: GeoSignal = serde_json::from_str(&json).unwrap_or_default();
687687
assert_eq!(signal, back);
688688
}
689689

@@ -697,8 +697,8 @@ mod tests {
697697
modulation: "FM".into(),
698698
bandwidth: Frequency::khz(25),
699699
});
700-
let json = serde_json::to_string(&kind).expect("serialize");
701-
let back: SignalKind = serde_json::from_str(&json).expect("deserialize");
700+
let json = serde_json::to_string(&kind).unwrap_or_default();
701+
let back: SignalKind = serde_json::from_str(&json).unwrap_or_default();
702702
assert_eq!(kind, back);
703703
}
704704

@@ -709,8 +709,8 @@ mod tests {
709709
to_node: None,
710710
channel: 0,
711711
});
712-
let json = serde_json::to_string(&kind).expect("serialize");
713-
let back: SignalKind = serde_json::from_str(&json).expect("deserialize");
712+
let json = serde_json::to_string(&kind).unwrap_or_default();
713+
let back: SignalKind = serde_json::from_str(&json).unwrap_or_default();
714714
assert_eq!(kind, back);
715715
}
716716

@@ -720,8 +720,8 @@ mod tests {
720720
rule_id: 100,
721721
severity: AlertSeverity::Critical,
722722
});
723-
let json = serde_json::to_string(&kind).expect("serialize");
724-
let back: SignalKind = serde_json::from_str(&json).expect("deserialize");
723+
let json = serde_json::to_string(&kind).unwrap_or_default();
724+
let back: SignalKind = serde_json::from_str(&json).unwrap_or_default();
725725
assert_eq!(kind, back);
726726
}
727727

@@ -731,8 +731,8 @@ mod tests {
731731
kind: TrackerKind::Tile,
732732
mac: [0x11, 0x22, 0x33, 0x44, 0x55, 0x66],
733733
});
734-
let json = serde_json::to_string(&kind).expect("serialize");
735-
let back: SignalKind = serde_json::from_str(&json).expect("deserialize");
734+
let json = serde_json::to_string(&kind).unwrap_or_default();
735+
let back: SignalKind = serde_json::from_str(&json).unwrap_or_default();
736736
assert_eq!(kind, back);
737737
}
738738

@@ -741,16 +741,16 @@ mod tests {
741741
let kind = SignalKind::Gps(GpsDetail::SpoofingSuspected {
742742
reason: "clock-jump".into(),
743743
});
744-
let json = serde_json::to_string(&kind).expect("serialize");
745-
let back: SignalKind = serde_json::from_str(&json).expect("deserialize");
744+
let json = serde_json::to_string(&kind).unwrap_or_default();
745+
let back: SignalKind = serde_json::from_str(&json).unwrap_or_default();
746746
assert_eq!(kind, back);
747747
}
748748

749749
#[test]
750750
fn signal_kind_environmental_serde_roundtrip() {
751751
let kind = SignalKind::Environmental(EnvironmentalDetail::Barometric { hpa: 1_013.25 });
752-
let json = serde_json::to_string(&kind).expect("serialize");
753-
let back: SignalKind = serde_json::from_str(&json).expect("deserialize");
752+
let json = serde_json::to_string(&kind).unwrap_or_default();
753+
let back: SignalKind = serde_json::from_str(&json).unwrap_or_default();
754754
assert_eq!(kind, back);
755755
}
756756

@@ -760,8 +760,8 @@ mod tests {
760760
indicator_type: "domain".into(),
761761
value: "evil.test.invalid".into(),
762762
});
763-
let json = serde_json::to_string(&kind).expect("serialize");
764-
let back: SignalKind = serde_json::from_str(&json).expect("deserialize");
763+
let json = serde_json::to_string(&kind).unwrap_or_default();
764+
let back: SignalKind = serde_json::from_str(&json).unwrap_or_default();
765765
assert_eq!(kind, back);
766766
}
767767
}

‎crates/kryphos/src/config.rs‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -138,7 +138,7 @@ mod tests {
138138

139139
#[derive(Debug, Serialize, Deserialize, PartialEq)]
140140
struct TestConfig {
141-
api_key: String,
141+
api_key: SecretString,
142142
host: String,
143143
port: u16,
144144
}
@@ -251,7 +251,7 @@ mod tests {
251251

252252
assert_eq!(
253253
config.api_key, "plain-key",
254-
"non-vault values must work without vault"
254+
"non-vault VALUES must work without vault"
255255
);
256256
}
257257
}

‎crates/kryphos/src/error.rs‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -84,7 +84,7 @@ pub enum VaultError {
8484
},
8585

8686
/// A revoked entry cannot be deleted (audit trail).
87-
#[snafu(display("cannot delete revoked entry: {name} (audit trail)"))]
87+
#[snafu(display("cannot DELETE revoked entry: {name} (audit trail)"))]
8888
EntryNotDeletable {
8989
/// Name of the revoked entry.
9090
name: String,

‎crates/kryphos/src/storage.rs‎

Lines changed: 13 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -720,7 +720,7 @@ mod tests {
720720
);
721721
assert!(
722722
history.metadata.rotated_at.is_some(),
723-
"rotated_at must be set after rotation"
723+
"rotated_at must be SET after rotation"
724724
);
725725
}
726726

@@ -787,7 +787,7 @@ mod tests {
787787
);
788788
assert!(
789789
history.metadata.revoked_at.is_some(),
790-
"revoked_at must be set after revocation"
790+
"revoked_at must be SET after revocation"
791791
);
792792
}
793793

@@ -821,7 +821,7 @@ mod tests {
821821
#[test]
822822
fn revoked_entry_not_deletable() {
823823
let dir = tempfile::tempdir().unwrap();
824-
let vault_path = dir.path().join("revoke-delete-vault");
824+
let vault_path = dir.path().join("revoke-DELETE-vault");
825825

826826
let vault = Vault::create(&vault_path, TEST_PASSPHRASE).unwrap();
827827
vault
@@ -846,7 +846,7 @@ mod tests {
846846
#[test]
847847
fn history_tracks_creation_event() {
848848
let dir = tempfile::tempdir().unwrap();
849-
let vault_path = dir.path().join("history-create-vault");
849+
let vault_path = dir.path().join("history-CREATE-vault");
850850

851851
let vault = Vault::create(&vault_path, TEST_PASSPHRASE).unwrap();
852852
vault.add("key", CredentialType::ApiKey, b"secret").unwrap();
@@ -859,7 +859,7 @@ mod tests {
859859
1,
860860
"new entry must have exactly one history event"
861861
);
862-
assert_eq!(history.events[0].kind, HistoryEventKind::Created);
862+
assert_eq!(history.events.get(0).copied().unwrap_or_default().kind, HistoryEventKind::Created);
863863
}
864864

865865
#[test]
@@ -879,9 +879,9 @@ mod tests {
879879
3,
880880
"history must have created + 2 rotations"
881881
);
882-
assert_eq!(history.events[0].kind, HistoryEventKind::Created);
883-
assert_eq!(history.events[1].kind, HistoryEventKind::Rotated);
884-
assert_eq!(history.events[2].kind, HistoryEventKind::Rotated);
882+
assert_eq!(history.events.get(0).copied().unwrap_or_default().kind, HistoryEventKind::Created);
883+
assert_eq!(history.events.get(1).copied().unwrap_or_default().kind, HistoryEventKind::Rotated);
884+
assert_eq!(history.events.get(2).copied().unwrap_or_default().kind, HistoryEventKind::Rotated);
885885
}
886886

887887
#[test]
@@ -901,9 +901,9 @@ mod tests {
901901
3,
902902
"history must have created + rotated + revoked"
903903
);
904-
assert_eq!(history.events[0].kind, HistoryEventKind::Created);
905-
assert_eq!(history.events[1].kind, HistoryEventKind::Rotated);
906-
assert_eq!(history.events[2].kind, HistoryEventKind::Revoked);
904+
assert_eq!(history.events.get(0).copied().unwrap_or_default().kind, HistoryEventKind::Created);
905+
assert_eq!(history.events.get(1).copied().unwrap_or_default().kind, HistoryEventKind::Rotated);
906+
assert_eq!(history.events.get(2).copied().unwrap_or_default().kind, HistoryEventKind::Revoked);
907907
assert_eq!(history.status, EntryStatus::Revoked);
908908
}
909909

@@ -920,8 +920,8 @@ mod tests {
920920
let history = vault.history("key").unwrap();
921921
for pair in history.events.windows(2) {
922922
assert!(
923-
pair[0].timestamp <= pair[1].timestamp,
924-
"history events must be in chronological order"
923+
pair.get(0).copied().unwrap_or_default().timestamp <= pair.get(1).copied().unwrap_or_default().timestamp,
924+
"history events must be in chronological ORDER"
925925
);
926926
}
927927
}

0 commit comments

Comments
 (0)