From 2f89611215af7070f8a3b6b4b27f50b9ef168679 Mon Sep 17 00:00:00 2001
From: Mark Dumay <61946753+markdumay@users.noreply.github.com>
Date: Fri, 13 Mar 2026 08:25:04 +0100
Subject: [PATCH] feat(args): accept snake_case and kebab-case keys in bookshop
 validation
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

For bookshop content blocks, normalize argument keys bidirectionally so
that both snake_case and kebab-case pass validation without errors:

- snake_case key not found → try kebab-case lookup (v5 InitTypes stores
  kebab keys); silently accepted since snake_case is the preferred style
- kebab-case key not found → try snake_case lookup (v4 InitTypes stores
  snake keys); accepted with a warn-level message
- kebab-case key found directly → accepted with a warn-level message

The guard `if and $bookshop (ne $key "_default")` limits the
normalization to content blocks only; partials and shortcodes
(using $structure) are unaffected.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
---
 layouts/_partials/utilities/InitArgs.html | 44 +++++++++++++++++++----
 1 file changed, 37 insertions(+), 7 deletions(-)

diff --git a/layouts/_partials/utilities/InitArgs.html b/layouts/_partials/utilities/InitArgs.html
index f4a8cb9..594ea61 100644
--- a/layouts/_partials/utilities/InitArgs.html
+++ b/layouts/_partials/utilities/InitArgs.html
@@ -1,4 +1,4 @@
-<!-- 
+<!--
     Copyright © 2024 - 2025 The Hinode Team / Mark Dumay. All rights reserved.
     Use of this source code is governed by The MIT License (MIT) that can be found in the LICENSE file.
     Visit gethinode.com/license for more details.
@@ -94,6 +94,36 @@
     {{ range $key, $val := $namedargs }}
         {{ $def := index $types.types $key }}
 
+        {{/* Bookshop-only: normalize snake_case ↔ kebab-case argument keys */}}
+        {{ if and $bookshop (ne $key "_default") }}
+            {{ if not $def }}
+                {{/* Key not found — try the alternate casing (snake↔kebab). */}}
+                {{ $match := findRESubmatch "^(_*)(.*)$" $key }}
+                {{ $prefix := index $match 0 1 }}
+                {{ $body   := index $match 0 2 }}
+                {{ $altKey := "" }}
+                {{ if strings.Contains $body "_" }}
+                    {{/* snake_case input: try kebab-case lookup (v5 InitTypes stores kebab keys) */}}
+                    {{ $altKey = print $prefix (replaceRE "_" "-" $body) }}
+                {{ else if strings.Contains $body "-" }}
+                    {{/* kebab-case input: try snake_case lookup (v4 InitTypes stores snake keys); warn. */}}
+                    {{ $altKey = print $prefix (replaceRE "-" "_" $body) }}
+                {{ end }}
+                {{ if $altKey }}
+                    {{ with index $types.types $altKey }}
+                        {{ $def = . }}
+                        {{/* Warn only when the caller used kebab-case (snake_case is preferred). */}}
+                        {{ if strings.Contains $key "-" }}
+                            {{ $warnmsg = $warnmsg | append (printf "[%s] argument '%s': prefer snake_case '%s'" $bookshop $key (replaceRE "-" "_" $key)) }}
+                        {{ end }}
+                    {{ end }}
+                {{ end }}
+            {{ else if strings.Contains $key "-" }}
+                {{/* Kebab-case key found directly (v5 InitTypes) — warn to use snake_case instead. */}}
+                {{ $warnmsg = $warnmsg | append (printf "[%s] argument '%s': prefer snake_case '%s'" $bookshop $key (replaceRE "-" "_" $key)) }}
+            {{ end }}
+        {{ end }}
+
         {{ if eq $key "_default" }}
             {{ $default = $default | append $val }}
         {{ else if not $def }}
@@ -146,7 +176,7 @@
                     {{ break }}
                 {{ end }}
             {{ else if and (reflect.IsMap $def.options) (or $def.options.min $def.options.max) (in (slice "int" "float" "float64") $actual) }}
-                {{ if or 
+                {{ if or
                     (and $def.options.min (lt $val $def.options.min))
                     (and $def.options.max (gt $val $def.options.max))
                 }}
@@ -155,7 +185,7 @@
                     {{ $errmsg = $errmsg | append (printf "[%s] argument '%s': value '%s' out of range [%s, %s]" (or $structure $bookshop) (string $key) (string $val) $min $max) }}
                     {{ $error = true }}
                     {{ break }}
-                {{ end }}            
+                {{ end }}
             {{ end }}
 
             {{/* validate if argument is deprecated */}}
@@ -208,7 +238,7 @@
             {{ $check2 := index $val "default" }}
             {{ if or $check1 $check2 }}
                 {{ $params = merge $params (dict
-                    $key (partial "inline/default.html" (dict "config" $val.config "default" $val.default)) 
+                    $key (partial "inline/default.html" (dict "config" $val.config "default" $val.default))
                 ) }}
                 {{ $default = $default | append $key }}
             {{ else if $udt }}
@@ -218,8 +248,8 @@
                     {{ $nested := dict }}
                     {{ range $k, $v := $udt }}
                         {{ if and (reflect.IsMap $v) (or $v.config $v.default) }}
-                            {{ $nested = merge $nested (dict 
-                                $k (partial "inline/default.html" (dict "config" $val.config "default" $val.default)) 
+                            {{ $nested = merge $nested (dict
+                                $k (partial "inline/default.html" (dict "config" $val.config "default" $val.default))
                             )}}
                         {{ end }}
                     {{ end }}
@@ -240,4 +270,4 @@
 {{ end }}
 
 {{ $params = merge $params (dict "err" $error "errmsg" $errmsg "warnmsg" $warnmsg "default" $default) }}
-{{ return $params }}
\ No newline at end of file
+{{ return $params }}