From 81cb2b71ebe8516ddd22baa59bd98761bfd6a49e Mon Sep 17 00:00:00 2001 From: Alexander Dinauer Date: Wed, 22 Jan 2025 09:43:21 +0100 Subject: [PATCH 1/2] Remove debug logs when searching for OpenTelemetry marker classes --- .../java/io/sentry/opentelemetry/OpenTelemetryUtil.java | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/sentry/src/main/java/io/sentry/opentelemetry/OpenTelemetryUtil.java b/sentry/src/main/java/io/sentry/opentelemetry/OpenTelemetryUtil.java index b491ab5278d..3bf7eac1a26 100644 --- a/sentry/src/main/java/io/sentry/opentelemetry/OpenTelemetryUtil.java +++ b/sentry/src/main/java/io/sentry/opentelemetry/OpenTelemetryUtil.java @@ -1,5 +1,6 @@ package io.sentry.opentelemetry; +import io.sentry.NoOpLogger; import io.sentry.SentryOpenTelemetryMode; import io.sentry.SentryOptions; import io.sentry.util.LoadClass; @@ -29,15 +30,15 @@ public static void applyIgnoredSpanOrigins( final @NotNull SentryOpenTelemetryMode openTelemetryMode = options.getOpenTelemetryMode(); if (SentryOpenTelemetryMode.AUTO.equals(openTelemetryMode)) { if (loadClass.isClassAvailable( - "io.sentry.opentelemetry.agent.AgentMarker", options.getLogger())) { + "io.sentry.opentelemetry.agent.AgentMarker", NoOpLogger.getInstance())) { return SpanUtils.ignoredSpanOriginsForOpenTelemetry(SentryOpenTelemetryMode.AGENT); } if (loadClass.isClassAvailable( - "io.sentry.opentelemetry.agent.AgentlessMarker", options.getLogger())) { + "io.sentry.opentelemetry.agent.AgentlessMarker", NoOpLogger.getInstance())) { return SpanUtils.ignoredSpanOriginsForOpenTelemetry(SentryOpenTelemetryMode.AGENTLESS); } if (loadClass.isClassAvailable( - "io.sentry.opentelemetry.agent.AgentlessSpringMarker", options.getLogger())) { + "io.sentry.opentelemetry.agent.AgentlessSpringMarker", NoOpLogger.getInstance())) { return SpanUtils.ignoredSpanOriginsForOpenTelemetry( SentryOpenTelemetryMode.AGENTLESS_SPRING); } From 2fa35c86f7e9b36368129e99b8a86309dec4a24b Mon Sep 17 00:00:00 2001 From: Alexander Dinauer Date: Thu, 23 Jan 2025 05:06:19 +0100 Subject: [PATCH 2/2] changelog --- CHANGELOG.md | 3 +++ 1 file changed, 3 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 2e4603cd4fa..c0dc15d200e 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -5,6 +5,9 @@ ### Fixes - Avoid logging an error when a float is passed in the manifest ([#4031](https://github.com/getsentry/sentry-java/pull/4031)) +- Remove `java.lang.ClassNotFoundException` debug logs when searching for OpenTelemetry marker classes ([#4091](https://github.com/getsentry/sentry-java/pull/4091)) + - There was up to three of these, one for `io.sentry.opentelemetry.agent.AgentMarker`, `io.sentry.opentelemetry.agent.AgentlessMarker` and `io.sentry.opentelemetry.agent.AgentlessSpringMarker`. + - These were not indicators of something being wrong but rather the SDK looking at what is available at runtime to configure itself accordingly. ## 8.0.0