From 9200eef9dd62500988c9d46efd7309c04837cd44 Mon Sep 17 00:00:00 2001 From: Ivana Kellyer Date: Fri, 19 Dec 2025 09:55:45 +0100 Subject: [PATCH 1/3] tests: General logs tests should use Sentry logs --- tests/test_logs.py | 12 ++++-------- 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/tests/test_logs.py b/tests/test_logs.py index 3b60651631..80ab58153c 100644 --- a/tests/test_logs.py +++ b/tests/test_logs.py @@ -349,9 +349,8 @@ def test_auto_flush_logs_after_100(sentry_init, capture_envelopes): sentry_init(enable_logs=True) envelopes = capture_envelopes() - python_logger = logging.Logger("test-logger") for i in range(200): - python_logger.warning("log #%d", i) + sentry_sdk.logger.warning("log #%d", i) for _ in range(500): time.sleep(1.0 / 100.0) @@ -368,8 +367,7 @@ def test_log_user_attributes(sentry_init, capture_envelopes): sentry_sdk.set_user({"id": "1", "email": "test@example.com", "username": "test"}) envelopes = capture_envelopes() - python_logger = logging.Logger("test-logger") - python_logger.warning("Hello, world!") + sentry_sdk.logger.warning("Hello, world!") get_client().flush() @@ -391,8 +389,7 @@ def test_log_no_user_attributes_if_no_pii(sentry_init, capture_envelopes): sentry_sdk.set_user({"id": "1", "email": "test@example.com", "username": "test"}) envelopes = capture_envelopes() - python_logger = logging.Logger("test-logger") - python_logger.warning("Hello, world!") + sentry_sdk.logger.warning("Hello, world!") get_client().flush() @@ -412,8 +409,7 @@ def test_auto_flush_logs_after_5s(sentry_init, capture_envelopes): sentry_init(enable_logs=True) envelopes = capture_envelopes() - python_logger = logging.Logger("test-logger") - python_logger.warning("log #%d", 1) + sentry_sdk.logger.warning("log") for _ in range(100): time.sleep(1.0 / 10.0) From e311d5c924c97df49818b3cf5a330bd0d6359b05 Mon Sep 17 00:00:00 2001 From: Ivana Kellyer Date: Fri, 19 Dec 2025 09:59:36 +0100 Subject: [PATCH 2/3] . --- tests/test_logs.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/test_logs.py b/tests/test_logs.py index 80ab58153c..1c366d143a 100644 --- a/tests/test_logs.py +++ b/tests/test_logs.py @@ -350,7 +350,7 @@ def test_auto_flush_logs_after_100(sentry_init, capture_envelopes): envelopes = capture_envelopes() for i in range(200): - sentry_sdk.logger.warning("log #%d", i) + sentry_sdk.logger.warning("log") for _ in range(500): time.sleep(1.0 / 100.0) From 1d37d0fcd3693221ebf4be35a4c89655396ac1ab Mon Sep 17 00:00:00 2001 From: Ivana Kellyer Date: Fri, 19 Dec 2025 10:05:09 +0100 Subject: [PATCH 3/3] gate behind 3.7 --- tests/test_logs.py | 3 +++ 1 file changed, 3 insertions(+) diff --git a/tests/test_logs.py b/tests/test_logs.py index 1c366d143a..3526917271 100644 --- a/tests/test_logs.py +++ b/tests/test_logs.py @@ -342,6 +342,7 @@ def test_logs_tied_to_spans(sentry_init, capture_envelopes): assert logs[0]["span_id"] == span.span_id +@minimum_python_37 def test_auto_flush_logs_after_100(sentry_init, capture_envelopes): """ If you log >100 logs, it should automatically trigger a flush. @@ -360,6 +361,7 @@ def test_auto_flush_logs_after_100(sentry_init, capture_envelopes): raise AssertionError("200 logs were never flushed after five seconds") +@minimum_python_37 def test_log_user_attributes(sentry_init, capture_envelopes): """User attributes are sent if enable_logs is True and send_default_pii is True.""" sentry_init(enable_logs=True, send_default_pii=True) @@ -382,6 +384,7 @@ def test_log_user_attributes(sentry_init, capture_envelopes): } +@minimum_python_37 def test_log_no_user_attributes_if_no_pii(sentry_init, capture_envelopes): """User attributes are not if PII sending is off.""" sentry_init(enable_logs=True, send_default_pii=False)