Skip to content

Commit ff6e598

Browse files
committed
Rust: Annotate failures with explanation.
1 parent fc5d5b4 commit ff6e598

File tree

1 file changed

+2
-2
lines changed
  • rust/ql/test/library-tests/dataflow/taint

1 file changed

+2
-2
lines changed

rust/ql/test/library-tests/dataflow/taint/main.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -139,7 +139,7 @@ use std::ops::{Add, Sub, Mul, Shl, Shr, BitOr, AddAssign, SubAssign, MulAssign,
139139

140140
fn std_ops() {
141141
sink(source(1).add(2i64)); // $ hasTaintFlow=1
142-
sink(source(1).add(2)); // $ MISSING: hasTaintFlow=1
142+
sink(source(1).add(2)); // $ MISSING: hasTaintFlow=1 --- the missing results here are due to failing to resolve targets for `add` etc where there's no explicit type
143143
sink(1i64.add(source(2))); // $ hasTaintFlow=2
144144
sink(1.add(source(2))); // $ MISSING: hasTaintFlow=2
145145

@@ -197,7 +197,7 @@ mod wrapping {
197197
a.add_assign(Wrapping(crate::source(3)));
198198
a += source(4);
199199
a += std::num::Wrapping(crate::source(5));
200-
sink(a); // $ hasTaintFlow=2 hasTaintFlow=4 MISSING: hasTaintFlow=3 hasTaintFlow=5
200+
sink(a); // $ hasTaintFlow=2 hasTaintFlow=4 MISSING: hasTaintFlow=3 hasTaintFlow=5 --- we don't currently find any `Call`s for `Wrapping` above
201201
}
202202
}
203203

0 commit comments

Comments
 (0)