From 1d386478a4f6b0507f5ae297f6090b91b0a94b13 Mon Sep 17 00:00:00 2001 From: Adam Setch Date: Tue, 24 Mar 2026 08:33:13 -0400 Subject: [PATCH] chore: biome format Signed-off-by: Adam Setch --- biome.json | 17 +++++++++++++---- src/renderer/__helpers__/test-utils.tsx | 1 - src/renderer/components/AllRead.tsx | 3 ++- src/renderer/components/Sidebar.tsx | 2 +- .../components/filters/FilterSection.test.tsx | 1 + .../components/filters/FilterSection.tsx | 2 +- .../components/filters/SearchFilter.test.tsx | 1 + .../components/filters/SearchFilter.tsx | 2 +- src/renderer/components/icons/LogoIcon.tsx | 1 + src/renderer/context/App.tsx | 2 +- src/renderer/index.html | 6 +++--- src/renderer/routes/Filters.test.tsx | 1 + src/renderer/routes/Filters.tsx | 4 ++-- .../utils/notifications/filters/filter.test.ts | 3 ++- .../utils/notifications/filters/filter.ts | 3 ++- .../utils/notifications/filters/reason.ts | 3 ++- .../utils/notifications/filters/search.ts | 4 ++-- .../utils/notifications/filters/state.ts | 4 ++-- .../utils/notifications/filters/subjectType.ts | 4 ++-- .../utils/notifications/filters/userType.ts | 4 ++-- .../utils/notifications/handlers/commit.test.ts | 3 ++- .../notifications/handlers/release.test.ts | 3 ++- 22 files changed, 46 insertions(+), 28 deletions(-) diff --git a/biome.json b/biome.json index 0dd9dad4c..00879bb71 100644 --- a/biome.json +++ b/biome.json @@ -28,7 +28,13 @@ ":BLANK_LINE:", ["**/constants", "**/constants/**"], ":BLANK_LINE:", - ["**/context/**", "**/hooks/**", "**/routes/**"], + [ + "**/context/**", + "**/hooks/**", + "**/routes/**", + "**/stores", + "**/stores/**" + ], ":BLANK_LINE:", [ "**/layout/**", @@ -55,9 +61,6 @@ }, "rules": { "recommended": true, - "a11y": { - "useKeyWithClickEvents": "off" - }, "correctness": { "noUnusedFunctionParameters": "error", "useExhaustiveDependencies": { @@ -111,6 +114,12 @@ "tailwindDirectives": true } }, + "html": { + "formatter": { + "enabled": true + }, + "experimentalFullSupportEnabled": true + }, "javascript": { "formatter": { "quoteStyle": "single", diff --git a/src/renderer/__helpers__/test-utils.tsx b/src/renderer/__helpers__/test-utils.tsx index 248081d0f..734999ce8 100644 --- a/src/renderer/__helpers__/test-utils.tsx +++ b/src/renderer/__helpers__/test-utils.tsx @@ -7,7 +7,6 @@ import { BaseStyles, ThemeProvider } from '@primer/react'; import { mockAuth, mockSettings } from '../__mocks__/state-mocks'; import { AppContext, type AppContextState } from '../context/App'; - import { type FiltersStore, useFiltersStore } from '../stores'; export { navigateMock } from './vitest.setup'; diff --git a/src/renderer/components/AllRead.tsx b/src/renderer/components/AllRead.tsx index f56526abe..fe84fdde2 100644 --- a/src/renderer/components/AllRead.tsx +++ b/src/renderer/components/AllRead.tsx @@ -2,9 +2,10 @@ import { type FC, useMemo } from 'react'; import { Constants } from '../constants'; +import { useFiltersStore } from '../stores'; + import { EmojiSplash } from './layout/EmojiSplash'; -import { useFiltersStore } from '../stores'; import { randomElement } from '../utils/core/random'; interface AllReadProps { diff --git a/src/renderer/components/Sidebar.tsx b/src/renderer/components/Sidebar.tsx index e84dd7b55..497215d53 100644 --- a/src/renderer/components/Sidebar.tsx +++ b/src/renderer/components/Sidebar.tsx @@ -17,8 +17,8 @@ import { APPLICATION } from '../../shared/constants'; import { useAppContext } from '../hooks/useAppContext'; import { useShortcutActions } from '../hooks/useShortcutActions'; - import { useFiltersStore } from '../stores'; + import { LogoIcon } from './icons/LogoIcon'; export const Sidebar: FC = () => { diff --git a/src/renderer/components/filters/FilterSection.test.tsx b/src/renderer/components/filters/FilterSection.test.tsx index 31e993af9..7c12180fd 100644 --- a/src/renderer/components/filters/FilterSection.test.tsx +++ b/src/renderer/components/filters/FilterSection.test.tsx @@ -8,6 +8,7 @@ import { mockMultipleAccountNotifications } from '../../__mocks__/notifications- import { mockSettings } from '../../__mocks__/state-mocks'; import { useFiltersStore } from '../../stores'; + import { stateFilter } from '../../utils/notifications/filters'; import { FilterSection } from './FilterSection'; diff --git a/src/renderer/components/filters/FilterSection.tsx b/src/renderer/components/filters/FilterSection.tsx index c5980199d..c313bf3be 100644 --- a/src/renderer/components/filters/FilterSection.tsx +++ b/src/renderer/components/filters/FilterSection.tsx @@ -4,11 +4,11 @@ import type { Icon } from '@primer/octicons-react'; import { Stack, Text } from '@primer/react'; import { useAppContext } from '../../hooks/useAppContext'; +import { type FiltersState, useFiltersStore } from '../../stores'; import { Checkbox } from '../fields/Checkbox'; import { Title } from '../primitives/Title'; -import { type FiltersState, useFiltersStore } from '../../stores'; import type { Filter } from '../../utils/notifications/filters'; import { RequiresDetailedNotificationWarning } from './RequiresDetailedNotificationsWarning'; diff --git a/src/renderer/components/filters/SearchFilter.test.tsx b/src/renderer/components/filters/SearchFilter.test.tsx index cea4d9bbb..28903601c 100644 --- a/src/renderer/components/filters/SearchFilter.test.tsx +++ b/src/renderer/components/filters/SearchFilter.test.tsx @@ -3,6 +3,7 @@ import { fireEvent, screen } from '@testing-library/react'; import { renderWithProviders } from '../../__helpers__/test-utils'; import { useFiltersStore } from '../../stores'; + import { SearchFilter } from './SearchFilter'; describe('renderer/components/filters/SearchFilter.tsx', () => { diff --git a/src/renderer/components/filters/SearchFilter.tsx b/src/renderer/components/filters/SearchFilter.tsx index 50a1fa024..ced759297 100644 --- a/src/renderer/components/filters/SearchFilter.tsx +++ b/src/renderer/components/filters/SearchFilter.tsx @@ -11,12 +11,12 @@ import { import { Stack, Text } from '@primer/react'; import { useAppContext } from '../../hooks/useAppContext'; +import { useFiltersStore } from '../../stores'; import { Title } from '../primitives/Title'; import { IconColor, type SearchToken, Size } from '../../types'; -import { useFiltersStore } from '../../stores'; import { hasExcludeSearchFilters, hasIncludeSearchFilters, diff --git a/src/renderer/components/icons/LogoIcon.tsx b/src/renderer/components/icons/LogoIcon.tsx index 7a1796b2a..975b981f8 100644 --- a/src/renderer/components/icons/LogoIcon.tsx +++ b/src/renderer/components/icons/LogoIcon.tsx @@ -24,6 +24,7 @@ export const LogoIcon: FC = ({ size = Size.SMALL, ...props }: LogoIconProps) => ( + // biome-ignore lint/a11y/useKeyWithClickEvents: Logo is purely decorative Gitify - - - + + + diff --git a/src/renderer/routes/Filters.test.tsx b/src/renderer/routes/Filters.test.tsx index 653a6e7a0..407a9943b 100644 --- a/src/renderer/routes/Filters.test.tsx +++ b/src/renderer/routes/Filters.test.tsx @@ -4,6 +4,7 @@ import userEvent from '@testing-library/user-event'; import { navigateMock, renderWithProviders } from '../__helpers__/test-utils'; import { type FiltersStore, useFiltersStore } from '../stores'; + import { FiltersRoute } from './Filters'; describe('renderer/routes/Filters.tsx', () => { diff --git a/src/renderer/routes/Filters.tsx b/src/renderer/routes/Filters.tsx index 3d238bb7d..97f5ebd1c 100644 --- a/src/renderer/routes/Filters.tsx +++ b/src/renderer/routes/Filters.tsx @@ -3,6 +3,8 @@ import type { FC } from 'react'; import { FilterIcon, FilterRemoveIcon } from '@primer/octicons-react'; import { Button, Stack, Tooltip } from '@primer/react'; +import { useFiltersStore } from '../stores'; + import { ReasonFilter } from '../components/filters/ReasonFilter'; import { SearchFilter } from '../components/filters/SearchFilter'; import { StateFilter } from '../components/filters/StateFilter'; @@ -13,8 +15,6 @@ import { Page } from '../components/layout/Page'; import { Footer } from '../components/primitives/Footer'; import { Header } from '../components/primitives/Header'; -import { useFiltersStore } from '../stores'; - export const FiltersRoute: FC = () => { const clearFilters = useFiltersStore((s) => s.reset); diff --git a/src/renderer/utils/notifications/filters/filter.test.ts b/src/renderer/utils/notifications/filters/filter.test.ts index 611434581..5b0b2c48f 100644 --- a/src/renderer/utils/notifications/filters/filter.test.ts +++ b/src/renderer/utils/notifications/filters/filter.test.ts @@ -1,9 +1,10 @@ import { mockPartialGitifyNotification } from '../../../__mocks__/notifications-mocks'; import { mockSettings } from '../../../__mocks__/state-mocks'; +import { useFiltersStore } from '../../../stores'; + import type { GitifyOwner, Link, SearchToken } from '../../../types'; -import { useFiltersStore } from '../../../stores'; import { filterBaseNotifications, filterDetailedNotifications } from './filter'; describe('renderer/utils/notifications/filters/filter.ts', () => { diff --git a/src/renderer/utils/notifications/filters/filter.ts b/src/renderer/utils/notifications/filters/filter.ts index aaeca8f82..7fef38ccd 100644 --- a/src/renderer/utils/notifications/filters/filter.ts +++ b/src/renderer/utils/notifications/filters/filter.ts @@ -1,3 +1,5 @@ +import useFiltersStore from '../../../stores/useFiltersStore'; + import type { GitifyNotification, GitifyNotificationState, @@ -5,7 +7,6 @@ import type { SettingsState, } from '../../../types'; -import useFiltersStore from '../../../stores/useFiltersStore'; import { BASE_SEARCH_QUALIFIERS, DETAILED_ONLY_SEARCH_QUALIFIERS, diff --git a/src/renderer/utils/notifications/filters/reason.ts b/src/renderer/utils/notifications/filters/reason.ts index da686820f..83d9c48fa 100644 --- a/src/renderer/utils/notifications/filters/reason.ts +++ b/src/renderer/utils/notifications/filters/reason.ts @@ -1,3 +1,5 @@ +import { useFiltersStore } from '../../../stores'; + import type { AccountNotifications, GitifyNotification, @@ -6,7 +8,6 @@ import type { } from '../../../types'; import type { Filter } from './types'; -import { useFiltersStore } from '../../../stores'; import { REASON_TYPE_DETAILS } from '../reason'; export const reasonFilter: Filter = { diff --git a/src/renderer/utils/notifications/filters/search.ts b/src/renderer/utils/notifications/filters/search.ts index a5eed7576..def86416b 100644 --- a/src/renderer/utils/notifications/filters/search.ts +++ b/src/renderer/utils/notifications/filters/search.ts @@ -1,7 +1,7 @@ -import type { GitifyNotification } from '../../../types'; - import { useFiltersStore } from '../../../stores'; +import type { GitifyNotification } from '../../../types'; + export const SEARCH_DELIMITER = ':'; const SEARCH_QUALIFIERS = { diff --git a/src/renderer/utils/notifications/filters/state.ts b/src/renderer/utils/notifications/filters/state.ts index f11e316fc..2a4579d4f 100644 --- a/src/renderer/utils/notifications/filters/state.ts +++ b/src/renderer/utils/notifications/filters/state.ts @@ -1,3 +1,5 @@ +import { useFiltersStore } from '../../../stores'; + import type { AccountNotifications, FilterStateType, @@ -7,8 +9,6 @@ import type { } from '../../../types'; import type { Filter } from './types'; -import { useFiltersStore } from '../../../stores'; - const STATE_TYPE_DETAILS: Record = { draft: { title: 'Draft', diff --git a/src/renderer/utils/notifications/filters/subjectType.ts b/src/renderer/utils/notifications/filters/subjectType.ts index 9a2859518..fdedd75cc 100644 --- a/src/renderer/utils/notifications/filters/subjectType.ts +++ b/src/renderer/utils/notifications/filters/subjectType.ts @@ -1,3 +1,5 @@ +import useFiltersStore from '../../../stores/useFiltersStore'; + import type { AccountNotifications, GitifyNotification, @@ -6,8 +8,6 @@ import type { } from '../../../types'; import type { Filter } from './types'; -import useFiltersStore from '../../../stores/useFiltersStore'; - const SUBJECT_TYPE_DETAILS: Record = { CheckSuite: { title: 'Check Suite', diff --git a/src/renderer/utils/notifications/filters/userType.ts b/src/renderer/utils/notifications/filters/userType.ts index 6568b66c4..3f0224c49 100644 --- a/src/renderer/utils/notifications/filters/userType.ts +++ b/src/renderer/utils/notifications/filters/userType.ts @@ -1,3 +1,5 @@ +import { useFiltersStore } from '../../../stores'; + import type { AccountNotifications, GitifyNotification, @@ -6,8 +8,6 @@ import type { } from '../../../types'; import type { Filter } from './types'; -import { useFiltersStore } from '../../../stores'; - type FilterableUserType = Extract; const USER_TYPE_DETAILS: Record = { diff --git a/src/renderer/utils/notifications/handlers/commit.test.ts b/src/renderer/utils/notifications/handlers/commit.test.ts index ce8cabf7a..996207e54 100644 --- a/src/renderer/utils/notifications/handlers/commit.test.ts +++ b/src/renderer/utils/notifications/handlers/commit.test.ts @@ -2,13 +2,14 @@ import { mockPartialGitifyNotification } from '../../../__mocks__/notifications- import { mockSettings } from '../../../__mocks__/state-mocks'; import { mockRawUser } from '../../api/__mocks__/response-mocks'; +import { useFiltersStore } from '../../../stores'; + import type { GitifyNotification, Link } from '../../../types'; import type { GetCommitCommentResponse, GetCommitResponse, } from '../../api/types'; -import { useFiltersStore } from '../../../stores'; import * as apiClient from '../../api/client'; import { commitHandler } from './commit'; diff --git a/src/renderer/utils/notifications/handlers/release.test.ts b/src/renderer/utils/notifications/handlers/release.test.ts index 13bccca96..1ad7667f9 100644 --- a/src/renderer/utils/notifications/handlers/release.test.ts +++ b/src/renderer/utils/notifications/handlers/release.test.ts @@ -2,10 +2,11 @@ import { mockPartialGitifyNotification } from '../../../__mocks__/notifications- import { mockSettings } from '../../../__mocks__/state-mocks'; import { mockRawUser } from '../../api/__mocks__/response-mocks'; +import { useFiltersStore } from '../../../stores'; + import type { GitifyNotification, Link } from '../../../types'; import type { GetReleaseResponse } from '../../api/types'; -import { useFiltersStore } from '../../../stores'; import * as apiClient from '../../api/client'; import { releaseHandler } from './release';