Changing to use the search function to reduce global objects that are not in the app context

Author: gjanders

README.md

@@ -329,6 +329,7 @@ As of October 2022, there are still no signs of version control within the Splun
 ### 1.2.18
 Updates to `splunkversioncontrol_backup_class.py`:
 - Remove the "color" flag from the navigation menu if it exists during the backup
+- Add in a search argument for the application context for a minor performance improvement
 
 ### 1.2.18
 Updates to `splunkversioncontrol_backup_class.py`:

bin/splunkversioncontrol_backup_class.py

@@ -193,7 +193,7 @@ def runQueries(self, app, endpoint, obj_type, fieldIgnoreList, aliasAttributes={
         creationSuccess = []
         #Keep a success list to be returned by this function
         #Use count=-1 to ensure we see all the objects
-        url = self.splunk_rest + "/servicesNS/-/" + app + endpoint + "?count=-1" + extra_args
+        url = f"{self.splunk_rest}/servicesNS/-/{app}{endpoint}?count=-1&search=eai:acl.app={app}{extra_args}"
         logger.debug("i=\"%s\" Running requests.get() on %s user=%s in app=%s, proxies_length=%s, sslVerify=%s" % (self.stanzaName, url, self.srcUsername, app, len(self.proxies), self.sslVerify))
 
         headers = {}
@@ -800,7 +800,7 @@ def macros(self, app):
 
         #servicesNS/-/-/properties/macros doesn't show private macros so using /configs/conf-macros to find all the macros
         #again with count=-1 to find all the available macros
-        url = self.splunk_rest + "/servicesNS/-/" + app + "/configs/conf-macros?count=-1"
+        url = f"{self.splunk_rest}/servicesNS/-/{app}/configs/conf-macros?count=-1&search=eai:acl.app={app}"
         logger.debug("i=\"%s\" Running requests.get() on url=%s with user=%s in app=%s for type macro proxies_length=%s, sslVerify=%s" % (self.stanzaName, url, self.srcUsername, app, len(self.proxies), self.sslVerify))
 
         headers = {}
@@ -1984,5 +1984,4 @@ def run_script(self):
             logger.warn("i=\"%s\" wiping the git directory, dir=%s to allow re-cloning on next run of the script" % (self.stanzaName, self.gitTempDir))
             shutil.rmtree(self.gitTempDir)
 
-        logger.info("i=\"%s\" Done" % (self.stanzaName))
-
+        logger.info("i=\"%s\" Done" % (self.stanzaName))