fix leaf coercion loop.

Author: gmac

lib/graphql/cardinal/executor/hot_paths.rb

@@ -55,16 +55,17 @@ def coerce_leaf_value(exec_field, current_type, val)
             report_exception("#{INCORRECT_LIST_VALUE}#{val.class}", field: exec_field)
             return build_missing_value(exec_field, current_type, nil)
           end
-          
+
           current_type = current_type.of_type while current_type.non_null?
 
-          val.each { coerce_leaf_value(exec_field, current_type.of_type, _1) }
+          val.map { coerce_leaf_value(exec_field, current_type.of_type, _1) }
         else
           begin
             current_type.unwrap.coerce_result(val, @context)
           rescue StandardError => e
-            report_exception("Coercion error", field: exec_field)
-            build_missing_value(exec_field, current_type, val)
+            report_exception("Error building leaf result", error: e, field: exec_field)
+            error = InternalError.new(path: exec_field.path, base: false)
+            build_missing_value(exec_field, current_type, error)
           end
         end
       end

test/graphql/cardinal/executor/introspection_test.rb

@@ -162,7 +162,7 @@ def test_introspect_directive_type
       "args" => [{ "name" => "key" }],
       "description" => "@stitch description",
       "isRepeatable" => true,
-      "locations" => [:FIELD_DEFINITION],
+      "locations" => ["FIELD_DEFINITION"],
       "name" => "stitch"
     }
 
@@ -171,7 +171,7 @@ def test_introspect_directive_type
 
   def test_introspect_type_access
     result = execute_query(%|{
-      __type(name: "Widget") { 
+      __type(name: "Widget") {
         description
         kind
         name
@@ -279,10 +279,10 @@ def test_introspect_type_possible_types
 
   def test_introspect_type_specified_by_url
     result = execute_query(%|{
-      scalar: __type(name: "String") { 
+      scalar: __type(name: "String") {
         specifiedByURL
       }
-      non_scalar: __type(name: "Widget") { 
+      non_scalar: __type(name: "Widget") {
         specifiedByURL
       }
     }|)
@@ -303,7 +303,7 @@ def test_introspect_type_specified_by_url
 
   def test_introspect_type_kind_of_type
     result = execute_query(%|{
-      __type(name: "Mutation") { 
+      __type(name: "Mutation") {
         name
         kind
         ofType { name }
@@ -361,7 +361,7 @@ def test_introspect_type_kind_of_type
 
   def test_introspect_enum_value
     result = execute_query(%|{
-      __type(name: "Status") { 
+      __type(name: "Status") {
         enumValues(includeDeprecated: true) {
           deprecationReason
           description
@@ -399,7 +399,7 @@ def test_introspect_enum_value
 
   def test_introspect_field
     result = execute_query(%|{
-      __type(name: "Query") { 
+      __type(name: "Query") {
         fields(includeDeprecated: true) {
           args { name }
           deprecationReason
@@ -452,7 +452,7 @@ def test_introspect_field
 
   def test_introspect_arguments
     result = execute_query(%|{
-      __type(name: "Mutation") { 
+      __type(name: "Mutation") {
         fields {
           some: args { name }
           all: args(includeDeprecated: true) {
@@ -510,7 +510,7 @@ def test_introspect_argument_default_values
     |)
 
     result = execute_query(%|{
-      __type(name: "Query") { 
+      __type(name: "Query") {
         fields {
           args { defaultValue }
         }