fix: randomize heredoc delimiter in GITHUB_OUTPUT writes#527
Open
fg0x0 wants to merge 1 commit into
Open
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Replace fixed 'EOF' heredoc delimiter with a random per-invocation
delimiter (ghdelim_<random>) when writing gemini_response and
gemini_errors to $GITHUB_OUTPUT.
The fixed 'EOF' delimiter allows an LLM response containing a bare
'EOF' line to close the heredoc early. Subsequent name=value lines
in the response then become arbitrary step outputs, enabling bash
injection in any downstream consumer workflow that interpolates
${{ steps.gemini_run.outputs.X }} into a run: block.
This follows the canonical pattern from GitHub's official docs:
https://docs.github.com/en/actions/writing-workflows/choosing-what-your-workflow-does/workflow-commands-for-github-actions#multiline-strings
Fixes the vulnerability described in:
- Google VRP Issue #514026965
- Related to GHSA-62f2-6rx8-v262 (TOML template fix)
Present since v0.1.12 (PR google-github-actions#247, 2025-08-25).
1f02a38 to
52820a0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Randomize the heredoc delimiter used when writing
gemini_responseandgemini_errorsto$GITHUB_OUTPUTinaction.yml.The fixed
EOFdelimiter allows an LLM response containing a bareEOFline to close the heredoc early. Subsequentname=valuelines in the response then become arbitrary step outputs, enabling bash injection in downstream consumer workflows.Changes
echo "gemini_response<<EOF"with a randomghdelim_<hex>delimiterecho "gemini_errors<<EOF"with a randomghdelim_<hex>delimiteropenssl rand -hex 16per GitHub's canonical patternTesting
Fixes #526
References