Skip to content
This repository was archived by the owner on Sep 4, 2025. It is now read-only.

Add the Source field in the ErrorObject structure#134

Open
denouche wants to merge 1 commit into
google:masterfrom
denouche:addErrorObjectSource
Open

Add the Source field in the ErrorObject structure#134
denouche wants to merge 1 commit into
google:masterfrom
denouche:addErrorObjectSource

Conversation

@denouche

Copy link
Copy Markdown

Closes #130

@googlebot

Copy link
Copy Markdown

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers
  • Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the project maintainer to go/cla#troubleshoot.
  • The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
  • The email used to register you as an authorized contributor must also be attached to your GitHub account.

@denouche

Copy link
Copy Markdown
Author

I signed it!

@googlebot

Copy link
Copy Markdown

CLAs look good, thanks!

@denouche

denouche commented Apr 4, 2018

Copy link
Copy Markdown
Author

Hello? What about this PR?
Thanks!

@denouche

Copy link
Copy Markdown
Author

Hi
@aren55555 @shwoodard , is there anything blocking this PR?
Thanks!

@timrourke

Copy link
Copy Markdown

➕ I would like to see this implemented as well, I need the pointers/parameters for my use case. I suspect many Ember users would find this generally useful, since Ember Data can mark the fields in a given Ember Data Model as invalid due to some invalid request, but Ember Data needs the pointer to the fields to do this.

@aren55555 @shwoodard Anything else needed to get this merged?

@denouche

denouche commented Sep 4, 2018

Copy link
Copy Markdown
Author

@aren55555 @shwoodard could we merge this one please?

@ezekg

ezekg commented Apr 2, 2019

Copy link
Copy Markdown

Can we get an update on this?

@kfreiman

Copy link
Copy Markdown

@aren55555 @shwoodard could you merge this one please?

@rio

rio commented Feb 18, 2020

Copy link
Copy Markdown

Would be nice to have this in here! @aren55555 @shwoodard any chance of clicking that sweet merge button?

@Shandur

Shandur commented Apr 10, 2021

Copy link
Copy Markdown

Up :)

@adamweiner

Copy link
Copy Markdown

+1 @aren55555 🙏

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support of source attribute in ErrorObject struct

10 participants