From d64fc70f825eb695c0c89c355dbcdf04915d6a1e Mon Sep 17 00:00:00 2001 From: Daniel Sanche Date: Tue, 10 Mar 2026 11:05:56 -0700 Subject: [PATCH 1/3] fix: async operation samples --- gapic/templates/examples/feature_fragments.j2 | 13 +-- tests/unit/samplegen/test_template.py | 80 ++++++++++++++++++- 2 files changed, 81 insertions(+), 12 deletions(-) diff --git a/gapic/templates/examples/feature_fragments.j2 b/gapic/templates/examples/feature_fragments.j2 index 66815cbe8f..27271881f5 100644 --- a/gapic/templates/examples/feature_fragments.j2 +++ b/gapic/templates/examples/feature_fragments.j2 @@ -230,7 +230,7 @@ request=request {# Note: this doesn't deal with enums or unions #} {# LROs return operation objects and paged requests return pager objects #} {% if transport == "grpc-async" and calling_form not in -[calling_form_enum.LongRunningRequestPromise, calling_form_enum.RequestPagedAll] %} +[calling_form_enum.RequestPaged, calling_form_enum.RequestPagedAll] %} await{{ " "}} {%- endif -%} {% if calling_form in [calling_form_enum.RequestStreamingBidi, @@ -242,13 +242,6 @@ client.{{ render_method_name(sample)|trim }}({{ render_request_params_unary(samp {% endif %} {% endmacro %} -{% macro operation_text(transport) %} -{% if transport == "grpc-async" %} -(await operation) -{% else %} -operation -{% endif %} -{% endmacro %} {# Setting up the method invocation is the responsibility of the caller: #} {# it's just easier to set up client side streaming and other things from outside this macro. #} @@ -294,9 +287,7 @@ operation = {{ method_invocation_text|trim }} print("Waiting for operation to complete...") -{% with operation_text = operation_text(transport) %} -response = {{ operation_text|trim }}.result() -{% endwith %} +response = {% if transport == "grpc-async" %}await {% endif %}operation.result() # Handle the response {% for statement in response_statements %} diff --git a/tests/unit/samplegen/test_template.py b/tests/unit/samplegen/test_template.py index 9d984e0e1b..270877256d 100644 --- a/tests/unit/samplegen/test_template.py +++ b/tests/unit/samplegen/test_template.py @@ -957,7 +957,7 @@ def test_render_calling_form_longrunning_async(): print("Waiting for operation to complete...") - response = (await operation).result() + response = await operation.result() # Handle the response print("Test print statement") @@ -1020,6 +1020,84 @@ def test_render_method_call_basic_async(): ) +def test_render_method_call_lro_async(): + check_template( + """ + {% import "feature_fragments.j2" as frags %} + {{ frags.render_method_call({"rpc": "CategorizeMollusc", + "request": request, + "is_internal": False, + }, + calling_form, calling_form_enum, transport) }} + """, + """ + await client.categorize_mollusc(request=request) + """, + request=samplegen.FullRequest( + request_list=[ + samplegen.TransformedRequest(base="video", body=True, single=None), + samplegen.TransformedRequest(base="audio", body=True, single=None), + samplegen.TransformedRequest(base="guess", body=True, single=None), + ], + ), + calling_form_enum=CallingForm, + calling_form=CallingForm.LongRunningRequestPromise, + transport="grpc-async", + ) + + +def test_render_method_call_paged_async(): + check_template( + """ + {% import "feature_fragments.j2" as frags %} + {{ frags.render_method_call({"rpc": "CategorizeMollusc", + "request": request, + "is_internal": False, + }, + calling_form, calling_form_enum, transport) }} + """, + """ + client.categorize_mollusc(request=request) + """, + request=samplegen.FullRequest( + request_list=[ + samplegen.TransformedRequest(base="video", body=True, single=None), + samplegen.TransformedRequest(base="audio", body=True, single=None), + samplegen.TransformedRequest(base="guess", body=True, single=None), + ], + ), + calling_form_enum=CallingForm, + calling_form=CallingForm.RequestPaged, + transport="grpc-async", + ) + + +def test_render_method_call_paged_all_async(): + check_template( + """ + {% import "feature_fragments.j2" as frags %} + {{ frags.render_method_call({"rpc": "CategorizeMollusc", + "request": request, + "is_internal": False, + }, + calling_form, calling_form_enum, transport) }} + """, + """ + client.categorize_mollusc(request=request) + """, + request=samplegen.FullRequest( + request_list=[ + samplegen.TransformedRequest(base="video", body=True, single=None), + samplegen.TransformedRequest(base="audio", body=True, single=None), + samplegen.TransformedRequest(base="guess", body=True, single=None), + ], + ), + calling_form_enum=CallingForm, + calling_form=CallingForm.RequestPagedAll, + transport="grpc-async", + ) + + def test_render_method_call_basic_flattenable(): check_template( """ From 7b25c90cccdadc6823d20e05458ce79654b81dc9 Mon Sep 17 00:00:00 2001 From: Daniel Sanche Date: Tue, 10 Mar 2026 14:03:11 -0700 Subject: [PATCH 2/3] regenerated goldens --- .../services/asset_service/async_client.py | 8 ++--- ...ce_analyze_iam_policy_longrunning_async.py | 4 +-- ...rated_asset_service_export_assets_async.py | 4 +-- .../services/eventarc/async_client.py | 32 +++++++++---------- ...generated_eventarc_create_channel_async.py | 4 +-- ...ventarc_create_channel_connection_async.py | 4 +-- ...generated_eventarc_create_trigger_async.py | 4 +-- ...generated_eventarc_delete_channel_async.py | 4 +-- ...ventarc_delete_channel_connection_async.py | 4 +-- ...generated_eventarc_delete_trigger_async.py | 4 +-- ...generated_eventarc_update_channel_async.py | 4 +-- ...generated_eventarc_update_trigger_async.py | 4 +-- .../config_service_v2/async_client.py | 20 ++++++------ ...onfig_service_v2_copy_log_entries_async.py | 4 +-- ...ig_service_v2_create_bucket_async_async.py | 4 +-- ...ted_config_service_v2_create_link_async.py | 4 +-- ...ted_config_service_v2_delete_link_async.py | 4 +-- ...ig_service_v2_update_bucket_async_async.py | 4 +-- .../config_service_v2/async_client.py | 20 ++++++------ ...vice_v2_copy_log_entries_async_internal.py | 4 +-- ...ig_service_v2_create_bucket_async_async.py | 4 +-- ...g_service_v2_create_link_async_internal.py | 4 +-- ...g_service_v2_delete_link_async_internal.py | 4 +-- ...ig_service_v2_update_bucket_async_async.py | 4 +-- .../services/cloud_redis/async_client.py | 32 +++++++++---------- ...rated_cloud_redis_create_instance_async.py | 4 +-- ...rated_cloud_redis_delete_instance_async.py | 4 +-- ...rated_cloud_redis_export_instance_async.py | 4 +-- ...ted_cloud_redis_failover_instance_async.py | 4 +-- ...rated_cloud_redis_import_instance_async.py | 4 +-- ...loud_redis_reschedule_maintenance_async.py | 4 +-- ...rated_cloud_redis_update_instance_async.py | 4 +-- ...ated_cloud_redis_upgrade_instance_async.py | 4 +-- .../services/cloud_redis/async_client.py | 12 +++---- ...rated_cloud_redis_create_instance_async.py | 4 +-- ...rated_cloud_redis_delete_instance_async.py | 4 +-- ...rated_cloud_redis_update_instance_async.py | 4 +-- 37 files changed, 124 insertions(+), 124 deletions(-) diff --git a/tests/integration/goldens/asset/google/cloud/asset_v1/services/asset_service/async_client.py b/tests/integration/goldens/asset/google/cloud/asset_v1/services/asset_service/async_client.py index b769fef679..5bd6bd0b89 100755 --- a/tests/integration/goldens/asset/google/cloud/asset_v1/services/asset_service/async_client.py +++ b/tests/integration/goldens/asset/google/cloud/asset_v1/services/asset_service/async_client.py @@ -322,11 +322,11 @@ async def sample_export_assets(): ) # Make the request - operation = client.export_assets(request=request) + operation = await client.export_assets(request=request) print("Waiting for operation to complete...") - response = (await operation).result() + response = await operation.result() # Handle the response print(response) @@ -1727,11 +1727,11 @@ async def sample_analyze_iam_policy_longrunning(): ) # Make the request - operation = client.analyze_iam_policy_longrunning(request=request) + operation = await client.analyze_iam_policy_longrunning(request=request) print("Waiting for operation to complete...") - response = (await operation).result() + response = await operation.result() # Handle the response print(response) diff --git a/tests/integration/goldens/asset/samples/generated_samples/cloudasset_v1_generated_asset_service_analyze_iam_policy_longrunning_async.py b/tests/integration/goldens/asset/samples/generated_samples/cloudasset_v1_generated_asset_service_analyze_iam_policy_longrunning_async.py index 677d79556e..ced3d62112 100755 --- a/tests/integration/goldens/asset/samples/generated_samples/cloudasset_v1_generated_asset_service_analyze_iam_policy_longrunning_async.py +++ b/tests/integration/goldens/asset/samples/generated_samples/cloudasset_v1_generated_asset_service_analyze_iam_policy_longrunning_async.py @@ -51,11 +51,11 @@ async def sample_analyze_iam_policy_longrunning(): ) # Make the request - operation = client.analyze_iam_policy_longrunning(request=request) + operation = await client.analyze_iam_policy_longrunning(request=request) print("Waiting for operation to complete...") - response = (await operation).result() + response = await operation.result() # Handle the response print(response) diff --git a/tests/integration/goldens/asset/samples/generated_samples/cloudasset_v1_generated_asset_service_export_assets_async.py b/tests/integration/goldens/asset/samples/generated_samples/cloudasset_v1_generated_asset_service_export_assets_async.py index 61934e88f0..aad81a353e 100755 --- a/tests/integration/goldens/asset/samples/generated_samples/cloudasset_v1_generated_asset_service_export_assets_async.py +++ b/tests/integration/goldens/asset/samples/generated_samples/cloudasset_v1_generated_asset_service_export_assets_async.py @@ -48,11 +48,11 @@ async def sample_export_assets(): ) # Make the request - operation = client.export_assets(request=request) + operation = await client.export_assets(request=request) print("Waiting for operation to complete...") - response = (await operation).result() + response = await operation.result() # Handle the response print(response) diff --git a/tests/integration/goldens/eventarc/google/cloud/eventarc_v1/services/eventarc/async_client.py b/tests/integration/goldens/eventarc/google/cloud/eventarc_v1/services/eventarc/async_client.py index a122de3592..a62c40bb05 100755 --- a/tests/integration/goldens/eventarc/google/cloud/eventarc_v1/services/eventarc/async_client.py +++ b/tests/integration/goldens/eventarc/google/cloud/eventarc_v1/services/eventarc/async_client.py @@ -564,11 +564,11 @@ async def sample_create_trigger(): ) # Make the request - operation = client.create_trigger(request=request) + operation = await client.create_trigger(request=request) print("Waiting for operation to complete...") - response = (await operation).result() + response = await operation.result() # Handle the response print(response) @@ -703,11 +703,11 @@ async def sample_update_trigger(): ) # Make the request - operation = client.update_trigger(request=request) + operation = await client.update_trigger(request=request) print("Waiting for operation to complete...") - response = (await operation).result() + response = await operation.result() # Handle the response print(response) @@ -845,11 +845,11 @@ async def sample_delete_trigger(): ) # Make the request - operation = client.delete_trigger(request=request) + operation = await client.delete_trigger(request=request) print("Waiting for operation to complete...") - response = (await operation).result() + response = await operation.result() # Handle the response print(response) @@ -1218,11 +1218,11 @@ async def sample_create_channel(): ) # Make the request - operation = client.create_channel(request=request) + operation = await client.create_channel(request=request) print("Waiting for operation to complete...") - response = (await operation).result() + response = await operation.result() # Handle the response print(response) @@ -1359,11 +1359,11 @@ async def sample_update_channel(): ) # Make the request - operation = client.update_channel(request=request) + operation = await client.update_channel(request=request) print("Waiting for operation to complete...") - response = (await operation).result() + response = await operation.result() # Handle the response print(response) @@ -1493,11 +1493,11 @@ async def sample_delete_channel(): ) # Make the request - operation = client.delete_channel(request=request) + operation = await client.delete_channel(request=request) print("Waiting for operation to complete...") - response = (await operation).result() + response = await operation.result() # Handle the response print(response) @@ -2084,11 +2084,11 @@ async def sample_create_channel_connection(): ) # Make the request - operation = client.create_channel_connection(request=request) + operation = await client.create_channel_connection(request=request) print("Waiting for operation to complete...") - response = (await operation).result() + response = await operation.result() # Handle the response print(response) @@ -2225,11 +2225,11 @@ async def sample_delete_channel_connection(): ) # Make the request - operation = client.delete_channel_connection(request=request) + operation = await client.delete_channel_connection(request=request) print("Waiting for operation to complete...") - response = (await operation).result() + response = await operation.result() # Handle the response print(response) diff --git a/tests/integration/goldens/eventarc/samples/generated_samples/eventarc_v1_generated_eventarc_create_channel_async.py b/tests/integration/goldens/eventarc/samples/generated_samples/eventarc_v1_generated_eventarc_create_channel_async.py index 48d01b7a94..bf84faf9b5 100755 --- a/tests/integration/goldens/eventarc/samples/generated_samples/eventarc_v1_generated_eventarc_create_channel_async.py +++ b/tests/integration/goldens/eventarc/samples/generated_samples/eventarc_v1_generated_eventarc_create_channel_async.py @@ -51,11 +51,11 @@ async def sample_create_channel(): ) # Make the request - operation = client.create_channel(request=request) + operation = await client.create_channel(request=request) print("Waiting for operation to complete...") - response = (await operation).result() + response = await operation.result() # Handle the response print(response) diff --git a/tests/integration/goldens/eventarc/samples/generated_samples/eventarc_v1_generated_eventarc_create_channel_connection_async.py b/tests/integration/goldens/eventarc/samples/generated_samples/eventarc_v1_generated_eventarc_create_channel_connection_async.py index be468f4ec6..f954539991 100755 --- a/tests/integration/goldens/eventarc/samples/generated_samples/eventarc_v1_generated_eventarc_create_channel_connection_async.py +++ b/tests/integration/goldens/eventarc/samples/generated_samples/eventarc_v1_generated_eventarc_create_channel_connection_async.py @@ -50,11 +50,11 @@ async def sample_create_channel_connection(): ) # Make the request - operation = client.create_channel_connection(request=request) + operation = await client.create_channel_connection(request=request) print("Waiting for operation to complete...") - response = (await operation).result() + response = await operation.result() # Handle the response print(response) diff --git a/tests/integration/goldens/eventarc/samples/generated_samples/eventarc_v1_generated_eventarc_create_trigger_async.py b/tests/integration/goldens/eventarc/samples/generated_samples/eventarc_v1_generated_eventarc_create_trigger_async.py index 92756c2163..c8fc4605e1 100755 --- a/tests/integration/goldens/eventarc/samples/generated_samples/eventarc_v1_generated_eventarc_create_trigger_async.py +++ b/tests/integration/goldens/eventarc/samples/generated_samples/eventarc_v1_generated_eventarc_create_trigger_async.py @@ -54,11 +54,11 @@ async def sample_create_trigger(): ) # Make the request - operation = client.create_trigger(request=request) + operation = await client.create_trigger(request=request) print("Waiting for operation to complete...") - response = (await operation).result() + response = await operation.result() # Handle the response print(response) diff --git a/tests/integration/goldens/eventarc/samples/generated_samples/eventarc_v1_generated_eventarc_delete_channel_async.py b/tests/integration/goldens/eventarc/samples/generated_samples/eventarc_v1_generated_eventarc_delete_channel_async.py index eb88c5b18e..df1f80810c 100755 --- a/tests/integration/goldens/eventarc/samples/generated_samples/eventarc_v1_generated_eventarc_delete_channel_async.py +++ b/tests/integration/goldens/eventarc/samples/generated_samples/eventarc_v1_generated_eventarc_delete_channel_async.py @@ -45,11 +45,11 @@ async def sample_delete_channel(): ) # Make the request - operation = client.delete_channel(request=request) + operation = await client.delete_channel(request=request) print("Waiting for operation to complete...") - response = (await operation).result() + response = await operation.result() # Handle the response print(response) diff --git a/tests/integration/goldens/eventarc/samples/generated_samples/eventarc_v1_generated_eventarc_delete_channel_connection_async.py b/tests/integration/goldens/eventarc/samples/generated_samples/eventarc_v1_generated_eventarc_delete_channel_connection_async.py index 7bc0ecfb2b..5343ff4d0f 100755 --- a/tests/integration/goldens/eventarc/samples/generated_samples/eventarc_v1_generated_eventarc_delete_channel_connection_async.py +++ b/tests/integration/goldens/eventarc/samples/generated_samples/eventarc_v1_generated_eventarc_delete_channel_connection_async.py @@ -44,11 +44,11 @@ async def sample_delete_channel_connection(): ) # Make the request - operation = client.delete_channel_connection(request=request) + operation = await client.delete_channel_connection(request=request) print("Waiting for operation to complete...") - response = (await operation).result() + response = await operation.result() # Handle the response print(response) diff --git a/tests/integration/goldens/eventarc/samples/generated_samples/eventarc_v1_generated_eventarc_delete_trigger_async.py b/tests/integration/goldens/eventarc/samples/generated_samples/eventarc_v1_generated_eventarc_delete_trigger_async.py index 3f11794329..365a0a068f 100755 --- a/tests/integration/goldens/eventarc/samples/generated_samples/eventarc_v1_generated_eventarc_delete_trigger_async.py +++ b/tests/integration/goldens/eventarc/samples/generated_samples/eventarc_v1_generated_eventarc_delete_trigger_async.py @@ -45,11 +45,11 @@ async def sample_delete_trigger(): ) # Make the request - operation = client.delete_trigger(request=request) + operation = await client.delete_trigger(request=request) print("Waiting for operation to complete...") - response = (await operation).result() + response = await operation.result() # Handle the response print(response) diff --git a/tests/integration/goldens/eventarc/samples/generated_samples/eventarc_v1_generated_eventarc_update_channel_async.py b/tests/integration/goldens/eventarc/samples/generated_samples/eventarc_v1_generated_eventarc_update_channel_async.py index a2ce3afb32..dd61b4d710 100755 --- a/tests/integration/goldens/eventarc/samples/generated_samples/eventarc_v1_generated_eventarc_update_channel_async.py +++ b/tests/integration/goldens/eventarc/samples/generated_samples/eventarc_v1_generated_eventarc_update_channel_async.py @@ -44,11 +44,11 @@ async def sample_update_channel(): ) # Make the request - operation = client.update_channel(request=request) + operation = await client.update_channel(request=request) print("Waiting for operation to complete...") - response = (await operation).result() + response = await operation.result() # Handle the response print(response) diff --git a/tests/integration/goldens/eventarc/samples/generated_samples/eventarc_v1_generated_eventarc_update_trigger_async.py b/tests/integration/goldens/eventarc/samples/generated_samples/eventarc_v1_generated_eventarc_update_trigger_async.py index 0eba9dd1a6..8782f34f53 100755 --- a/tests/integration/goldens/eventarc/samples/generated_samples/eventarc_v1_generated_eventarc_update_trigger_async.py +++ b/tests/integration/goldens/eventarc/samples/generated_samples/eventarc_v1_generated_eventarc_update_trigger_async.py @@ -44,11 +44,11 @@ async def sample_update_trigger(): ) # Make the request - operation = client.update_trigger(request=request) + operation = await client.update_trigger(request=request) print("Waiting for operation to complete...") - response = (await operation).result() + response = await operation.result() # Handle the response print(response) diff --git a/tests/integration/goldens/logging/google/cloud/logging_v2/services/config_service_v2/async_client.py b/tests/integration/goldens/logging/google/cloud/logging_v2/services/config_service_v2/async_client.py index bb6373fa8d..9866a10f25 100755 --- a/tests/integration/goldens/logging/google/cloud/logging_v2/services/config_service_v2/async_client.py +++ b/tests/integration/goldens/logging/google/cloud/logging_v2/services/config_service_v2/async_client.py @@ -520,11 +520,11 @@ async def sample_create_bucket_async(): ) # Make the request - operation = client.create_bucket_async(request=request) + operation = await client.create_bucket_async(request=request) print("Waiting for operation to complete...") - response = (await operation).result() + response = await operation.result() # Handle the response print(response) @@ -625,11 +625,11 @@ async def sample_update_bucket_async(): ) # Make the request - operation = client.update_bucket_async(request=request) + operation = await client.update_bucket_async(request=request) print("Waiting for operation to complete...") - response = (await operation).result() + response = await operation.result() # Handle the response print(response) @@ -2177,11 +2177,11 @@ async def sample_create_link(): ) # Make the request - operation = client.create_link(request=request) + operation = await client.create_link(request=request) print("Waiting for operation to complete...") - response = (await operation).result() + response = await operation.result() # Handle the response print(response) @@ -2322,11 +2322,11 @@ async def sample_delete_link(): ) # Make the request - operation = client.delete_link(request=request) + operation = await client.delete_link(request=request) print("Waiting for operation to complete...") - response = (await operation).result() + response = await operation.result() # Handle the response print(response) @@ -3840,11 +3840,11 @@ async def sample_copy_log_entries(): ) # Make the request - operation = client.copy_log_entries(request=request) + operation = await client.copy_log_entries(request=request) print("Waiting for operation to complete...") - response = (await operation).result() + response = await operation.result() # Handle the response print(response) diff --git a/tests/integration/goldens/logging/samples/generated_samples/logging_v2_generated_config_service_v2_copy_log_entries_async.py b/tests/integration/goldens/logging/samples/generated_samples/logging_v2_generated_config_service_v2_copy_log_entries_async.py index 2d10cffeea..e395997992 100755 --- a/tests/integration/goldens/logging/samples/generated_samples/logging_v2_generated_config_service_v2_copy_log_entries_async.py +++ b/tests/integration/goldens/logging/samples/generated_samples/logging_v2_generated_config_service_v2_copy_log_entries_async.py @@ -45,11 +45,11 @@ async def sample_copy_log_entries(): ) # Make the request - operation = client.copy_log_entries(request=request) + operation = await client.copy_log_entries(request=request) print("Waiting for operation to complete...") - response = (await operation).result() + response = await operation.result() # Handle the response print(response) diff --git a/tests/integration/goldens/logging/samples/generated_samples/logging_v2_generated_config_service_v2_create_bucket_async_async.py b/tests/integration/goldens/logging/samples/generated_samples/logging_v2_generated_config_service_v2_create_bucket_async_async.py index 6813a6f3a3..d7f66d809a 100755 --- a/tests/integration/goldens/logging/samples/generated_samples/logging_v2_generated_config_service_v2_create_bucket_async_async.py +++ b/tests/integration/goldens/logging/samples/generated_samples/logging_v2_generated_config_service_v2_create_bucket_async_async.py @@ -45,11 +45,11 @@ async def sample_create_bucket_async(): ) # Make the request - operation = client.create_bucket_async(request=request) + operation = await client.create_bucket_async(request=request) print("Waiting for operation to complete...") - response = (await operation).result() + response = await operation.result() # Handle the response print(response) diff --git a/tests/integration/goldens/logging/samples/generated_samples/logging_v2_generated_config_service_v2_create_link_async.py b/tests/integration/goldens/logging/samples/generated_samples/logging_v2_generated_config_service_v2_create_link_async.py index f4521b6e1a..0bb48a0774 100755 --- a/tests/integration/goldens/logging/samples/generated_samples/logging_v2_generated_config_service_v2_create_link_async.py +++ b/tests/integration/goldens/logging/samples/generated_samples/logging_v2_generated_config_service_v2_create_link_async.py @@ -45,11 +45,11 @@ async def sample_create_link(): ) # Make the request - operation = client.create_link(request=request) + operation = await client.create_link(request=request) print("Waiting for operation to complete...") - response = (await operation).result() + response = await operation.result() # Handle the response print(response) diff --git a/tests/integration/goldens/logging/samples/generated_samples/logging_v2_generated_config_service_v2_delete_link_async.py b/tests/integration/goldens/logging/samples/generated_samples/logging_v2_generated_config_service_v2_delete_link_async.py index 2637bae7aa..6728984a02 100755 --- a/tests/integration/goldens/logging/samples/generated_samples/logging_v2_generated_config_service_v2_delete_link_async.py +++ b/tests/integration/goldens/logging/samples/generated_samples/logging_v2_generated_config_service_v2_delete_link_async.py @@ -44,11 +44,11 @@ async def sample_delete_link(): ) # Make the request - operation = client.delete_link(request=request) + operation = await client.delete_link(request=request) print("Waiting for operation to complete...") - response = (await operation).result() + response = await operation.result() # Handle the response print(response) diff --git a/tests/integration/goldens/logging/samples/generated_samples/logging_v2_generated_config_service_v2_update_bucket_async_async.py b/tests/integration/goldens/logging/samples/generated_samples/logging_v2_generated_config_service_v2_update_bucket_async_async.py index 7edf95a4c6..4f9dde2bc0 100755 --- a/tests/integration/goldens/logging/samples/generated_samples/logging_v2_generated_config_service_v2_update_bucket_async_async.py +++ b/tests/integration/goldens/logging/samples/generated_samples/logging_v2_generated_config_service_v2_update_bucket_async_async.py @@ -44,11 +44,11 @@ async def sample_update_bucket_async(): ) # Make the request - operation = client.update_bucket_async(request=request) + operation = await client.update_bucket_async(request=request) print("Waiting for operation to complete...") - response = (await operation).result() + response = await operation.result() # Handle the response print(response) diff --git a/tests/integration/goldens/logging_internal/google/cloud/logging_v2/services/config_service_v2/async_client.py b/tests/integration/goldens/logging_internal/google/cloud/logging_v2/services/config_service_v2/async_client.py index b2fc579342..8ed962f33c 100755 --- a/tests/integration/goldens/logging_internal/google/cloud/logging_v2/services/config_service_v2/async_client.py +++ b/tests/integration/goldens/logging_internal/google/cloud/logging_v2/services/config_service_v2/async_client.py @@ -520,11 +520,11 @@ async def sample_create_bucket_async(): ) # Make the request - operation = client.create_bucket_async(request=request) + operation = await client.create_bucket_async(request=request) print("Waiting for operation to complete...") - response = (await operation).result() + response = await operation.result() # Handle the response print(response) @@ -625,11 +625,11 @@ async def sample_update_bucket_async(): ) # Make the request - operation = client.update_bucket_async(request=request) + operation = await client.update_bucket_async(request=request) print("Waiting for operation to complete...") - response = (await operation).result() + response = await operation.result() # Handle the response print(response) @@ -2177,11 +2177,11 @@ async def sample_create_link(): ) # Make the request - operation = client._create_link(request=request) + operation = await client._create_link(request=request) print("Waiting for operation to complete...") - response = (await operation).result() + response = await operation.result() # Handle the response print(response) @@ -2322,11 +2322,11 @@ async def sample_delete_link(): ) # Make the request - operation = client._delete_link(request=request) + operation = await client._delete_link(request=request) print("Waiting for operation to complete...") - response = (await operation).result() + response = await operation.result() # Handle the response print(response) @@ -3840,11 +3840,11 @@ async def sample_copy_log_entries(): ) # Make the request - operation = client._copy_log_entries(request=request) + operation = await client._copy_log_entries(request=request) print("Waiting for operation to complete...") - response = (await operation).result() + response = await operation.result() # Handle the response print(response) diff --git a/tests/integration/goldens/logging_internal/samples/generated_samples/logging_v2_generated_config_service_v2_copy_log_entries_async_internal.py b/tests/integration/goldens/logging_internal/samples/generated_samples/logging_v2_generated_config_service_v2_copy_log_entries_async_internal.py index 9b38e9b48e..694c55cbeb 100755 --- a/tests/integration/goldens/logging_internal/samples/generated_samples/logging_v2_generated_config_service_v2_copy_log_entries_async_internal.py +++ b/tests/integration/goldens/logging_internal/samples/generated_samples/logging_v2_generated_config_service_v2_copy_log_entries_async_internal.py @@ -45,11 +45,11 @@ async def sample_copy_log_entries(): ) # Make the request - operation = client._copy_log_entries(request=request) + operation = await client._copy_log_entries(request=request) print("Waiting for operation to complete...") - response = (await operation).result() + response = await operation.result() # Handle the response print(response) diff --git a/tests/integration/goldens/logging_internal/samples/generated_samples/logging_v2_generated_config_service_v2_create_bucket_async_async.py b/tests/integration/goldens/logging_internal/samples/generated_samples/logging_v2_generated_config_service_v2_create_bucket_async_async.py index d5125a9cdf..7761a29485 100755 --- a/tests/integration/goldens/logging_internal/samples/generated_samples/logging_v2_generated_config_service_v2_create_bucket_async_async.py +++ b/tests/integration/goldens/logging_internal/samples/generated_samples/logging_v2_generated_config_service_v2_create_bucket_async_async.py @@ -45,11 +45,11 @@ async def sample_create_bucket_async(): ) # Make the request - operation = client.create_bucket_async(request=request) + operation = await client.create_bucket_async(request=request) print("Waiting for operation to complete...") - response = (await operation).result() + response = await operation.result() # Handle the response print(response) diff --git a/tests/integration/goldens/logging_internal/samples/generated_samples/logging_v2_generated_config_service_v2_create_link_async_internal.py b/tests/integration/goldens/logging_internal/samples/generated_samples/logging_v2_generated_config_service_v2_create_link_async_internal.py index 58675aa3d0..bc2214e788 100755 --- a/tests/integration/goldens/logging_internal/samples/generated_samples/logging_v2_generated_config_service_v2_create_link_async_internal.py +++ b/tests/integration/goldens/logging_internal/samples/generated_samples/logging_v2_generated_config_service_v2_create_link_async_internal.py @@ -45,11 +45,11 @@ async def sample_create_link(): ) # Make the request - operation = client._create_link(request=request) + operation = await client._create_link(request=request) print("Waiting for operation to complete...") - response = (await operation).result() + response = await operation.result() # Handle the response print(response) diff --git a/tests/integration/goldens/logging_internal/samples/generated_samples/logging_v2_generated_config_service_v2_delete_link_async_internal.py b/tests/integration/goldens/logging_internal/samples/generated_samples/logging_v2_generated_config_service_v2_delete_link_async_internal.py index 1429cfaa7c..c3cfea93c7 100755 --- a/tests/integration/goldens/logging_internal/samples/generated_samples/logging_v2_generated_config_service_v2_delete_link_async_internal.py +++ b/tests/integration/goldens/logging_internal/samples/generated_samples/logging_v2_generated_config_service_v2_delete_link_async_internal.py @@ -44,11 +44,11 @@ async def sample_delete_link(): ) # Make the request - operation = client._delete_link(request=request) + operation = await client._delete_link(request=request) print("Waiting for operation to complete...") - response = (await operation).result() + response = await operation.result() # Handle the response print(response) diff --git a/tests/integration/goldens/logging_internal/samples/generated_samples/logging_v2_generated_config_service_v2_update_bucket_async_async.py b/tests/integration/goldens/logging_internal/samples/generated_samples/logging_v2_generated_config_service_v2_update_bucket_async_async.py index dfad5f4a52..452fa73bc3 100755 --- a/tests/integration/goldens/logging_internal/samples/generated_samples/logging_v2_generated_config_service_v2_update_bucket_async_async.py +++ b/tests/integration/goldens/logging_internal/samples/generated_samples/logging_v2_generated_config_service_v2_update_bucket_async_async.py @@ -44,11 +44,11 @@ async def sample_update_bucket_async(): ) # Make the request - operation = client.update_bucket_async(request=request) + operation = await client.update_bucket_async(request=request) print("Waiting for operation to complete...") - response = (await operation).result() + response = await operation.result() # Handle the response print(response) diff --git a/tests/integration/goldens/redis/google/cloud/redis_v1/services/cloud_redis/async_client.py b/tests/integration/goldens/redis/google/cloud/redis_v1/services/cloud_redis/async_client.py index 402a673002..f546c58dce 100755 --- a/tests/integration/goldens/redis/google/cloud/redis_v1/services/cloud_redis/async_client.py +++ b/tests/integration/goldens/redis/google/cloud/redis_v1/services/cloud_redis/async_client.py @@ -682,11 +682,11 @@ async def sample_create_instance(): ) # Make the request - operation = client.create_instance(request=request) + operation = await client.create_instance(request=request) print("Waiting for operation to complete...") - response = (await operation).result() + response = await operation.result() # Handle the response print(response) @@ -839,11 +839,11 @@ async def sample_update_instance(): ) # Make the request - operation = client.update_instance(request=request) + operation = await client.update_instance(request=request) print("Waiting for operation to complete...") - response = (await operation).result() + response = await operation.result() # Handle the response print(response) @@ -980,11 +980,11 @@ async def sample_upgrade_instance(): ) # Make the request - operation = client.upgrade_instance(request=request) + operation = await client.upgrade_instance(request=request) print("Waiting for operation to complete...") - response = (await operation).result() + response = await operation.result() # Handle the response print(response) @@ -1124,11 +1124,11 @@ async def sample_import_instance(): ) # Make the request - operation = client.import_instance(request=request) + operation = await client.import_instance(request=request) print("Waiting for operation to complete...") - response = (await operation).result() + response = await operation.result() # Handle the response print(response) @@ -1265,11 +1265,11 @@ async def sample_export_instance(): ) # Make the request - operation = client.export_instance(request=request) + operation = await client.export_instance(request=request) print("Waiting for operation to complete...") - response = (await operation).result() + response = await operation.result() # Handle the response print(response) @@ -1399,11 +1399,11 @@ async def sample_failover_instance(): ) # Make the request - operation = client.failover_instance(request=request) + operation = await client.failover_instance(request=request) print("Waiting for operation to complete...") - response = (await operation).result() + response = await operation.result() # Handle the response print(response) @@ -1532,11 +1532,11 @@ async def sample_delete_instance(): ) # Make the request - operation = client.delete_instance(request=request) + operation = await client.delete_instance(request=request) print("Waiting for operation to complete...") - response = (await operation).result() + response = await operation.result() # Handle the response print(response) @@ -1665,11 +1665,11 @@ async def sample_reschedule_maintenance(): ) # Make the request - operation = client.reschedule_maintenance(request=request) + operation = await client.reschedule_maintenance(request=request) print("Waiting for operation to complete...") - response = (await operation).result() + response = await operation.result() # Handle the response print(response) diff --git a/tests/integration/goldens/redis/samples/generated_samples/redis_v1_generated_cloud_redis_create_instance_async.py b/tests/integration/goldens/redis/samples/generated_samples/redis_v1_generated_cloud_redis_create_instance_async.py index e263e176c7..6cb8469248 100755 --- a/tests/integration/goldens/redis/samples/generated_samples/redis_v1_generated_cloud_redis_create_instance_async.py +++ b/tests/integration/goldens/redis/samples/generated_samples/redis_v1_generated_cloud_redis_create_instance_async.py @@ -51,11 +51,11 @@ async def sample_create_instance(): ) # Make the request - operation = client.create_instance(request=request) + operation = await client.create_instance(request=request) print("Waiting for operation to complete...") - response = (await operation).result() + response = await operation.result() # Handle the response print(response) diff --git a/tests/integration/goldens/redis/samples/generated_samples/redis_v1_generated_cloud_redis_delete_instance_async.py b/tests/integration/goldens/redis/samples/generated_samples/redis_v1_generated_cloud_redis_delete_instance_async.py index 720fc67ee3..45dcc1896a 100755 --- a/tests/integration/goldens/redis/samples/generated_samples/redis_v1_generated_cloud_redis_delete_instance_async.py +++ b/tests/integration/goldens/redis/samples/generated_samples/redis_v1_generated_cloud_redis_delete_instance_async.py @@ -44,11 +44,11 @@ async def sample_delete_instance(): ) # Make the request - operation = client.delete_instance(request=request) + operation = await client.delete_instance(request=request) print("Waiting for operation to complete...") - response = (await operation).result() + response = await operation.result() # Handle the response print(response) diff --git a/tests/integration/goldens/redis/samples/generated_samples/redis_v1_generated_cloud_redis_export_instance_async.py b/tests/integration/goldens/redis/samples/generated_samples/redis_v1_generated_cloud_redis_export_instance_async.py index 321ab7af35..dff957f67c 100755 --- a/tests/integration/goldens/redis/samples/generated_samples/redis_v1_generated_cloud_redis_export_instance_async.py +++ b/tests/integration/goldens/redis/samples/generated_samples/redis_v1_generated_cloud_redis_export_instance_async.py @@ -48,11 +48,11 @@ async def sample_export_instance(): ) # Make the request - operation = client.export_instance(request=request) + operation = await client.export_instance(request=request) print("Waiting for operation to complete...") - response = (await operation).result() + response = await operation.result() # Handle the response print(response) diff --git a/tests/integration/goldens/redis/samples/generated_samples/redis_v1_generated_cloud_redis_failover_instance_async.py b/tests/integration/goldens/redis/samples/generated_samples/redis_v1_generated_cloud_redis_failover_instance_async.py index 1aeb9312d7..85e18c6dff 100755 --- a/tests/integration/goldens/redis/samples/generated_samples/redis_v1_generated_cloud_redis_failover_instance_async.py +++ b/tests/integration/goldens/redis/samples/generated_samples/redis_v1_generated_cloud_redis_failover_instance_async.py @@ -44,11 +44,11 @@ async def sample_failover_instance(): ) # Make the request - operation = client.failover_instance(request=request) + operation = await client.failover_instance(request=request) print("Waiting for operation to complete...") - response = (await operation).result() + response = await operation.result() # Handle the response print(response) diff --git a/tests/integration/goldens/redis/samples/generated_samples/redis_v1_generated_cloud_redis_import_instance_async.py b/tests/integration/goldens/redis/samples/generated_samples/redis_v1_generated_cloud_redis_import_instance_async.py index 2914c06d1b..8067998500 100755 --- a/tests/integration/goldens/redis/samples/generated_samples/redis_v1_generated_cloud_redis_import_instance_async.py +++ b/tests/integration/goldens/redis/samples/generated_samples/redis_v1_generated_cloud_redis_import_instance_async.py @@ -48,11 +48,11 @@ async def sample_import_instance(): ) # Make the request - operation = client.import_instance(request=request) + operation = await client.import_instance(request=request) print("Waiting for operation to complete...") - response = (await operation).result() + response = await operation.result() # Handle the response print(response) diff --git a/tests/integration/goldens/redis/samples/generated_samples/redis_v1_generated_cloud_redis_reschedule_maintenance_async.py b/tests/integration/goldens/redis/samples/generated_samples/redis_v1_generated_cloud_redis_reschedule_maintenance_async.py index b5c91c28e6..fd314bcf69 100755 --- a/tests/integration/goldens/redis/samples/generated_samples/redis_v1_generated_cloud_redis_reschedule_maintenance_async.py +++ b/tests/integration/goldens/redis/samples/generated_samples/redis_v1_generated_cloud_redis_reschedule_maintenance_async.py @@ -45,11 +45,11 @@ async def sample_reschedule_maintenance(): ) # Make the request - operation = client.reschedule_maintenance(request=request) + operation = await client.reschedule_maintenance(request=request) print("Waiting for operation to complete...") - response = (await operation).result() + response = await operation.result() # Handle the response print(response) diff --git a/tests/integration/goldens/redis/samples/generated_samples/redis_v1_generated_cloud_redis_update_instance_async.py b/tests/integration/goldens/redis/samples/generated_samples/redis_v1_generated_cloud_redis_update_instance_async.py index 4d31d03f75..4243eca301 100755 --- a/tests/integration/goldens/redis/samples/generated_samples/redis_v1_generated_cloud_redis_update_instance_async.py +++ b/tests/integration/goldens/redis/samples/generated_samples/redis_v1_generated_cloud_redis_update_instance_async.py @@ -49,11 +49,11 @@ async def sample_update_instance(): ) # Make the request - operation = client.update_instance(request=request) + operation = await client.update_instance(request=request) print("Waiting for operation to complete...") - response = (await operation).result() + response = await operation.result() # Handle the response print(response) diff --git a/tests/integration/goldens/redis/samples/generated_samples/redis_v1_generated_cloud_redis_upgrade_instance_async.py b/tests/integration/goldens/redis/samples/generated_samples/redis_v1_generated_cloud_redis_upgrade_instance_async.py index 7fe2c60323..43cba54d61 100755 --- a/tests/integration/goldens/redis/samples/generated_samples/redis_v1_generated_cloud_redis_upgrade_instance_async.py +++ b/tests/integration/goldens/redis/samples/generated_samples/redis_v1_generated_cloud_redis_upgrade_instance_async.py @@ -45,11 +45,11 @@ async def sample_upgrade_instance(): ) # Make the request - operation = client.upgrade_instance(request=request) + operation = await client.upgrade_instance(request=request) print("Waiting for operation to complete...") - response = (await operation).result() + response = await operation.result() # Handle the response print(response) diff --git a/tests/integration/goldens/redis_selective/google/cloud/redis_v1/services/cloud_redis/async_client.py b/tests/integration/goldens/redis_selective/google/cloud/redis_v1/services/cloud_redis/async_client.py index a1e1918ef2..f3f3bb80d0 100755 --- a/tests/integration/goldens/redis_selective/google/cloud/redis_v1/services/cloud_redis/async_client.py +++ b/tests/integration/goldens/redis_selective/google/cloud/redis_v1/services/cloud_redis/async_client.py @@ -574,11 +574,11 @@ async def sample_create_instance(): ) # Make the request - operation = client.create_instance(request=request) + operation = await client.create_instance(request=request) print("Waiting for operation to complete...") - response = (await operation).result() + response = await operation.result() # Handle the response print(response) @@ -731,11 +731,11 @@ async def sample_update_instance(): ) # Make the request - operation = client.update_instance(request=request) + operation = await client.update_instance(request=request) print("Waiting for operation to complete...") - response = (await operation).result() + response = await operation.result() # Handle the response print(response) @@ -870,11 +870,11 @@ async def sample_delete_instance(): ) # Make the request - operation = client.delete_instance(request=request) + operation = await client.delete_instance(request=request) print("Waiting for operation to complete...") - response = (await operation).result() + response = await operation.result() # Handle the response print(response) diff --git a/tests/integration/goldens/redis_selective/samples/generated_samples/redis_v1_generated_cloud_redis_create_instance_async.py b/tests/integration/goldens/redis_selective/samples/generated_samples/redis_v1_generated_cloud_redis_create_instance_async.py index e263e176c7..6cb8469248 100755 --- a/tests/integration/goldens/redis_selective/samples/generated_samples/redis_v1_generated_cloud_redis_create_instance_async.py +++ b/tests/integration/goldens/redis_selective/samples/generated_samples/redis_v1_generated_cloud_redis_create_instance_async.py @@ -51,11 +51,11 @@ async def sample_create_instance(): ) # Make the request - operation = client.create_instance(request=request) + operation = await client.create_instance(request=request) print("Waiting for operation to complete...") - response = (await operation).result() + response = await operation.result() # Handle the response print(response) diff --git a/tests/integration/goldens/redis_selective/samples/generated_samples/redis_v1_generated_cloud_redis_delete_instance_async.py b/tests/integration/goldens/redis_selective/samples/generated_samples/redis_v1_generated_cloud_redis_delete_instance_async.py index 720fc67ee3..45dcc1896a 100755 --- a/tests/integration/goldens/redis_selective/samples/generated_samples/redis_v1_generated_cloud_redis_delete_instance_async.py +++ b/tests/integration/goldens/redis_selective/samples/generated_samples/redis_v1_generated_cloud_redis_delete_instance_async.py @@ -44,11 +44,11 @@ async def sample_delete_instance(): ) # Make the request - operation = client.delete_instance(request=request) + operation = await client.delete_instance(request=request) print("Waiting for operation to complete...") - response = (await operation).result() + response = await operation.result() # Handle the response print(response) diff --git a/tests/integration/goldens/redis_selective/samples/generated_samples/redis_v1_generated_cloud_redis_update_instance_async.py b/tests/integration/goldens/redis_selective/samples/generated_samples/redis_v1_generated_cloud_redis_update_instance_async.py index 4d31d03f75..4243eca301 100755 --- a/tests/integration/goldens/redis_selective/samples/generated_samples/redis_v1_generated_cloud_redis_update_instance_async.py +++ b/tests/integration/goldens/redis_selective/samples/generated_samples/redis_v1_generated_cloud_redis_update_instance_async.py @@ -49,11 +49,11 @@ async def sample_update_instance(): ) # Make the request - operation = client.update_instance(request=request) + operation = await client.update_instance(request=request) print("Waiting for operation to complete...") - response = (await operation).result() + response = await operation.result() # Handle the response print(response) From f2be3f784bacf7034e0aedf5d901e23acc80d542 Mon Sep 17 00:00:00 2001 From: Daniel Sanche Date: Tue, 10 Mar 2026 15:24:17 -0700 Subject: [PATCH 3/3] updated golden --- ...lusca_v1_generated_snippets_method_lro_signatures_async.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/snippetgen/goldens/mollusca_v1_generated_snippets_method_lro_signatures_async.py b/tests/snippetgen/goldens/mollusca_v1_generated_snippets_method_lro_signatures_async.py index 14976e879c..20174fd710 100644 --- a/tests/snippetgen/goldens/mollusca_v1_generated_snippets_method_lro_signatures_async.py +++ b/tests/snippetgen/goldens/mollusca_v1_generated_snippets_method_lro_signatures_async.py @@ -52,11 +52,11 @@ async def sample_method_lro_signatures(): ) # Make the request - operation = client.method_lro_signatures(request=request) + operation = await client.method_lro_signatures(request=request) print("Waiting for operation to complete...") - response = (await operation).result() + response = await operation.result() # Handle the response print(response)