From 08491e130897eb27518e4a5b2d549f4297640687 Mon Sep 17 00:00:00 2001 From: Sofia Leon Date: Fri, 13 Mar 2026 00:26:31 +0000 Subject: [PATCH 1/6] fix syncpack config --- .syncpackrc.json | 30 ++++++++++++++++++++++++------ package.json | 4 ++-- 2 files changed, 26 insertions(+), 8 deletions(-) diff --git a/.syncpackrc.json b/.syncpackrc.json index 566d7eec0..d60b220e0 100644 --- a/.syncpackrc.json +++ b/.syncpackrc.json @@ -1,12 +1,30 @@ { - "dependencyTypes": ["prod"], + "$schema": "./node_modules/syncpack/schema.json", "versionGroups": [ { - "label": "Allow minor and patch version bumps", - "dependencies": ["**"], - "packages": ["**"], - "sameMinorNew": true, - "dependencyTypes": ["prod"] + "label": "Sync production and internal dependencies to the highest version", + "dependencyTypes": [ + "prod", + "local" + ], + "packages": ["**"] + }, + { + "label": "Ignore all other dependency types (e.g., devDependencies)", + "dependencyTypes": ["**"], + "isIgnored": true + } + ], + "semverGroups": [ + { + "label": "Preserve ^ range", + "specifierTypes": ["range"], + "range": "^" + }, + { + "label": "Preserve exact version", + "specifierTypes": ["exact"], + "range": "" } ] } \ No newline at end of file diff --git a/package.json b/package.json index 417d0d23b..c0af93824 100644 --- a/package.json +++ b/package.json @@ -17,9 +17,9 @@ }, "scripts": { "lint-fix": "ci/lint-fix.sh", - "syncpack-fix": "syncpack fix-mismatches" + "syncpack-fix": "syncpack fix" }, "devDependencies": { - "syncpack": "^13.0.4" + "syncpack": "^14.0.2" } } From d724262a5bf46196796f595b63f137bd678d6e4b Mon Sep 17 00:00:00 2001 From: Sofia Leon Date: Fri, 13 Mar 2026 00:36:16 +0000 Subject: [PATCH 2/6] retry syncpack config --- .syncpackrc.json | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/.syncpackrc.json b/.syncpackrc.json index d60b220e0..cf54e09dd 100644 --- a/.syncpackrc.json +++ b/.syncpackrc.json @@ -1,6 +1,11 @@ { "$schema": "./node_modules/syncpack/schema.json", "versionGroups": [ + { + "label": "Ignore special specifier types (files, git, etc)", + "specifierTypes": ["file", "git", "url", "alias", "link", "unsupported", "workspace-protocol"], + "isIgnored": true + }, { "label": "Sync production and internal dependencies to the highest version", "dependencyTypes": [ @@ -10,7 +15,7 @@ "packages": ["**"] }, { - "label": "Ignore all other dependency types (e.g., devDependencies)", + "label": "Ignore all other dependency types", "dependencyTypes": ["**"], "isIgnored": true } From 44a27aede554c88b8e27aa10534b771c8f9de84a Mon Sep 17 00:00:00 2001 From: Sofia Leon Date: Fri, 13 Mar 2026 00:42:06 +0000 Subject: [PATCH 3/6] retry syncpack --- .syncpackrc.json | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/.syncpackrc.json b/.syncpackrc.json index cf54e09dd..baf295d28 100644 --- a/.syncpackrc.json +++ b/.syncpackrc.json @@ -7,12 +7,13 @@ "isIgnored": true }, { - "label": "Sync production and internal dependencies to the highest version", + "label": "Sync production and internal dependencies to the same major version", "dependencyTypes": [ "prod", "local" ], - "packages": ["**"] + "packages": ["**"], + "policy": "sameMajor" }, { "label": "Ignore all other dependency types", From df32feb2ace32384c3b47363dfb9f9c5a83bcb48 Mon Sep 17 00:00:00 2001 From: Sofia Leon Date: Fri, 13 Mar 2026 00:44:19 +0000 Subject: [PATCH 4/6] retry syncpack --- .syncpackrc.json | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/.syncpackrc.json b/.syncpackrc.json index baf295d28..cf54e09dd 100644 --- a/.syncpackrc.json +++ b/.syncpackrc.json @@ -7,13 +7,12 @@ "isIgnored": true }, { - "label": "Sync production and internal dependencies to the same major version", + "label": "Sync production and internal dependencies to the highest version", "dependencyTypes": [ "prod", "local" ], - "packages": ["**"], - "policy": "sameMajor" + "packages": ["**"] }, { "label": "Ignore all other dependency types", From f0236aa5d5ba325944b58e64541d669aa372be8d Mon Sep 17 00:00:00 2001 From: Sofia Leon Date: Fri, 13 Mar 2026 00:52:04 +0000 Subject: [PATCH 5/6] retry --- .syncpackrc.json | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/.syncpackrc.json b/.syncpackrc.json index cf54e09dd..f52ae6efc 100644 --- a/.syncpackrc.json +++ b/.syncpackrc.json @@ -22,12 +22,18 @@ ], "semverGroups": [ { - "label": "Preserve ^ range", + "label": "Use ^ for internal references in samples", + "packages": ["**-samples", "puppeteer-example", "nodejs-docs-samples-**", "appengine-cloudtasks", "nodejs-run", "nodejs-life-sciences", "nodejs-binary-authorization", "nodejs-vpc-access"], + "dependencyTypes": ["**"], + "range": "^" + }, + { + "label": "Preserve ^ range for all other dependencies", "specifierTypes": ["range"], "range": "^" }, { - "label": "Preserve exact version", + "label": "Preserve exact version for all other dependencies", "specifierTypes": ["exact"], "range": "" } From d98885f71dab8d53946b059218591bb61b9521f2 Mon Sep 17 00:00:00 2001 From: Sofia Leon Date: Fri, 13 Mar 2026 00:56:08 +0000 Subject: [PATCH 6/6] revmoe syncpack --- .github/workflows/syncpack.yaml | 19 --------------- .syncpackrc.json | 41 --------------------------------- package.json | 6 +---- 3 files changed, 1 insertion(+), 65 deletions(-) delete mode 100644 .github/workflows/syncpack.yaml delete mode 100644 .syncpackrc.json diff --git a/.github/workflows/syncpack.yaml b/.github/workflows/syncpack.yaml deleted file mode 100644 index 9160d2b82..000000000 --- a/.github/workflows/syncpack.yaml +++ /dev/null @@ -1,19 +0,0 @@ -on: - push: - branches: - - main - pull_request: - -name: syncpack - -jobs: - syncpack: - runs-on: ubuntu-latest - steps: - - uses: actions/checkout@v5 - - uses: actions/setup-node@v4 - with: - node-version: 18 - - run: npm install - - run: npm install -g syncpack - - run: syncpack list-mismatches diff --git a/.syncpackrc.json b/.syncpackrc.json deleted file mode 100644 index f52ae6efc..000000000 --- a/.syncpackrc.json +++ /dev/null @@ -1,41 +0,0 @@ -{ - "$schema": "./node_modules/syncpack/schema.json", - "versionGroups": [ - { - "label": "Ignore special specifier types (files, git, etc)", - "specifierTypes": ["file", "git", "url", "alias", "link", "unsupported", "workspace-protocol"], - "isIgnored": true - }, - { - "label": "Sync production and internal dependencies to the highest version", - "dependencyTypes": [ - "prod", - "local" - ], - "packages": ["**"] - }, - { - "label": "Ignore all other dependency types", - "dependencyTypes": ["**"], - "isIgnored": true - } - ], - "semverGroups": [ - { - "label": "Use ^ for internal references in samples", - "packages": ["**-samples", "puppeteer-example", "nodejs-docs-samples-**", "appengine-cloudtasks", "nodejs-run", "nodejs-life-sciences", "nodejs-binary-authorization", "nodejs-vpc-access"], - "dependencyTypes": ["**"], - "range": "^" - }, - { - "label": "Preserve ^ range for all other dependencies", - "specifierTypes": ["range"], - "range": "^" - }, - { - "label": "Preserve exact version for all other dependencies", - "specifierTypes": ["exact"], - "range": "" - } - ] -} \ No newline at end of file diff --git a/package.json b/package.json index c0af93824..2c4f4a0e4 100644 --- a/package.json +++ b/package.json @@ -16,10 +16,6 @@ "url": "https://github.com/googleapis/google-cloud-node-core/issues" }, "scripts": { - "lint-fix": "ci/lint-fix.sh", - "syncpack-fix": "syncpack fix" - }, - "devDependencies": { - "syncpack": "^14.0.2" + "lint-fix": "ci/lint-fix.sh" } }