fix: remove message from inventory when nack with response

Author: Luisgustavom1

src/subscriber.ts

@@ -887,6 +887,8 @@ export class Subscriber extends EventEmitter {
     const latency = (Date.now() - startTime) / 1000;
     this._latencies.add(latency);
 
+    this._inventory.remove(message);
+
     // No exception means Success.
     return AckResponses.Success;
   }

test/subscriber.ts

@@ -698,10 +698,32 @@ describe('Subscriber', () => {
   });
 
   describe('nack', () => {
+    it('should remove the message from the inventory', async () => {
+      const inventory: FakeLeaseManager = stubs.get('inventory');
+      const stub = sandbox.stub(inventory, 'remove').withArgs(message);
+
+      await subscriber.nack(message);
+
+      assert.strictEqual(stub.callCount, 1);
+    });
+  });
+
+  describe('nackWithResponse', () => {
+    it('should remove the message from the inventory', async () => {
+      const inventory: FakeLeaseManager = stubs.get('inventory');
+      const stub = sandbox.stub(inventory, 'remove').withArgs(message);
+
+      await subscriber.nackWithResponse(message);
+
+      assert.strictEqual(stub.callCount, 1);
+    });
+  });
+
+  describe('ackWithResponse', () => {
     it('should modAck the message with a 0 deadline', async () => {
       const stub = sandbox.stub(subscriber, 'modAck');
 
-      await subscriber.nack(message);
+      await subscriber.ackWithResponse(message);
 
       const [msg, deadline] = stub.lastCall.args;
 
@@ -713,7 +735,7 @@ describe('Subscriber', () => {
       const inventory: FakeLeaseManager = stubs.get('inventory');
       const stub = sandbox.stub(inventory, 'remove').withArgs(message);
 
-      await subscriber.nack(message);
+      await subscriber.ackWithResponse(message);
 
       assert.strictEqual(stub.callCount, 1);
     });