Commit 919ed76
committed
fix: Only send mtlsEndpoint if it is non-null (#3767)
Temporary fix to only plumb the mtlsEndpoint to the gRPCChannelProviders
if this has been set with a non-null value. Validation will still go
through if it is set with bogus values.
Issue reported in googleapis/java-bigtable#2565
This seems to due to how Bigtable wrappers the generated stubs. BigTable
manually calls setEndpoint to for the StubSettings, but does not do the
equivalent for setMtlsEndpoint. The EndpointContext is only aware of the
TLS endpoint and passes a null value to the ChannelProviders.
Potential longer term fix: BigTable's wrappers would need to set the
mTLS Endpoint. This would be needed for BigTable to support S2A. This
does not impact any of BigTable's existing functionality as the endpoint
resolution for all non-S2A flows is done via `setEndpoint()`.1 parent 9784c5d commit 919ed76
File tree
2 files changed
+132
-41
lines changed- gax-java/gax/src
- main/java/com/google/api/gax/rpc
- test/java/com/google/api/gax/rpc
2 files changed
+132
-41
lines changedLines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
223 | 223 | | |
224 | 224 | | |
225 | 225 | | |
226 | | - | |
| 226 | + | |
227 | 227 | | |
228 | 228 | | |
229 | 229 | | |
| |||
0 commit comments