Close redis after tests

Author: Tommel71

.gitignore

@@ -96,7 +96,3 @@ local
 tests/test_loki_generated.py
 tests/loki_generated_calls.json
 tests/migration_timing_report.json
-clients/python/MIGRATION_ISSUES.md
-CRITICAL_ISSUES_SUMMARY.md
-COMPATIBILITY_ANALYSIS.md
-clients/python/COMPATIBILITY_QUICK_REFERENCE.md

gsrest/app.py

@@ -4,6 +4,7 @@
 import logging.handlers
 import os
 import re
+import traceback
 from contextlib import asynccontextmanager
 from typing import Any, Optional
 
@@ -363,6 +364,11 @@ async def teardown_database(app: FastAPI):
     logger.info(app.state.tagstore_engine.pool.status())
     logger.info("Closed Tagstore connection.")
 
+    # Close Redis client if it exists
+    if getattr(app.state, "redis_client", None):
+        await app.state.redis_client.aclose()
+        logger.info("Closed Redis connection.")
+
 
 class ConceptsCacheServiceFastAPI(ConceptProtocol):
     """FastAPI-compatible concepts cache service"""
@@ -407,6 +413,9 @@ async def setup_services(app: FastAPI):
         redis_client = None
         log_tag_access_prefix = None
 
+    # Store redis_client on app.state for cleanup during shutdown
+    app.state.redis_client = redis_client
+
     app.state.services = ServiceContainer(
         config=config,
         db=app.state.db,
@@ -465,6 +474,7 @@ async def setup_plugins(app: FastAPI):
             setup_gen = subcl.setup(setup_args)
             if hasattr(setup_gen, "__anext__"):
                 await setup_gen.__anext__()
+                app.state.plugin_cleanup_generators.append(setup_gen)
 
 
 @asynccontextmanager
@@ -478,21 +488,40 @@ async def lifespan(app: FastAPI):
     yield
 
     # Shutdown
+    # Close plugin cleanup generators
+    for gen in getattr(app.state, "plugin_cleanup_generators", []):
+        try:
+            await gen.aclose()
+        except Exception as e:
+            logger.warning(f"Error closing plugin generator: {e}")
+
     await teardown_database(app)
 
 
+def _get_request_context(request: Request) -> str:
+    """Get user and URL context for error logging."""
+    username = request.headers.get("X-Consumer-Username", "unknown")
+    return f"URL: {request.url} | User: {username}"
+
+
 def _register_exception_handlers(app: FastAPI):
     """Register common exception handlers on the app"""
 
     @app.exception_handler(NotFoundException)
     async def not_found_handler(request: Request, exc: NotFoundException):
+        logger.warning(
+            f"NotFoundException: {exc.get_user_msg()} | {_get_request_context(request)}"
+        )
         return JSONResponse(
             status_code=404,
             content={"detail": exc.get_user_msg()},
         )
 
     @app.exception_handler(BadUserInputException)
     async def bad_input_handler(request: Request, exc: BadUserInputException):
+        logger.warning(
+            f"BadUserInputException: {exc.get_user_msg()} | {_get_request_context(request)}"
+        )
         return JSONResponse(
             status_code=400,
             content={"detail": exc.get_user_msg()},
@@ -502,18 +531,31 @@ async def bad_input_handler(request: Request, exc: BadUserInputException):
     async def feature_not_available_handler(
         request: Request, exc: FeatureNotAvailableException
     ):
+        logger.warning(
+            f"FeatureNotAvailableException: {exc.get_user_msg()} | {_get_request_context(request)}"
+        )
         return JSONResponse(
             status_code=400,
             content={"detail": exc.get_user_msg()},
         )
 
     @app.exception_handler(GsTimeoutException)
     async def timeout_handler(request: Request, exc: GsTimeoutException):
+        logger.warning(f"GsTimeoutException | {_get_request_context(request)}")
         return JSONResponse(
             status_code=408,
             content={"detail": "Request timeout"},
         )
 
+    @app.exception_handler(Exception)
+    async def unhandled_exception_handler(request: Request, exc: Exception):
+        tb = "".join(traceback.format_exception(type(exc), exc, exc.__traceback__))
+        logger.error(f"Unhandled exception | {_get_request_context(request)}\n{tb}")
+        return JSONResponse(
+            status_code=500,
+            content={"detail": "Internal server error"},
+        )
+
 
 def _register_routers(app: FastAPI):
     """Register all API routers on the app.