From f1a9368b0367594c31f3ec25d43eb24ef59ef74e Mon Sep 17 00:00:00 2001 From: Andy Spaven <16537059+AndySpaven@users.noreply.github.com> Date: Wed, 5 Nov 2025 13:37:44 +0000 Subject: [PATCH 1/3] API-8737 - Migrate to OQE --- .../connectors/ThirdPartyApplicationConnector.scala | 2 +- .../support/ThirdPartyApplicationService.scala | 2 +- project/AppDependencies.scala | 4 ++-- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/app/uk/gov/hmrc/pushpullnotificationsapi/connectors/ThirdPartyApplicationConnector.scala b/app/uk/gov/hmrc/pushpullnotificationsapi/connectors/ThirdPartyApplicationConnector.scala index 1239bbac..e7f713dd 100644 --- a/app/uk/gov/hmrc/pushpullnotificationsapi/connectors/ThirdPartyApplicationConnector.scala +++ b/app/uk/gov/hmrc/pushpullnotificationsapi/connectors/ThirdPartyApplicationConnector.scala @@ -33,6 +33,6 @@ import uk.gov.hmrc.pushpullnotificationsapi.config.AppConfig class ThirdPartyApplicationConnector @Inject() (http: HttpClientV2, appConfig: AppConfig)(implicit ec: ExecutionContext) { def getApplicationDetails(clientId: ClientId)(implicit hc: HeaderCarrier): Future[ApplicationWithCollaborators] = { - http.get(url"${appConfig.thirdPartyApplicationUrl}/application?${Seq("clientId" -> clientId)}").execute[ApplicationWithCollaborators] + http.get(url"${appConfig.thirdPartyApplicationUrl}/query?clientId=$clientId").execute[ApplicationWithCollaborators] } } diff --git a/it/test/uk/gov/hmrc/pushpullnotificationsapi/support/ThirdPartyApplicationService.scala b/it/test/uk/gov/hmrc/pushpullnotificationsapi/support/ThirdPartyApplicationService.scala index ef37bc4e..c90f6bed 100644 --- a/it/test/uk/gov/hmrc/pushpullnotificationsapi/support/ThirdPartyApplicationService.scala +++ b/it/test/uk/gov/hmrc/pushpullnotificationsapi/support/ThirdPartyApplicationService.scala @@ -21,7 +21,7 @@ import com.github.tomakehurst.wiremock.client.WireMock._ import uk.gov.hmrc.apiplatform.modules.common.domain.models.ClientId trait ThirdPartyApplicationService { - val queryApplicationsUrl = "/application" + val queryApplicationsUrl = "/query" def primeApplicationQueryEndpoint(status: Int, body: String, clientId: ClientId) = { stubFor(get(urlPathEqualTo(queryApplicationsUrl)) diff --git a/project/AppDependencies.scala b/project/AppDependencies.scala index 915f821b..5c98c3f8 100644 --- a/project/AppDependencies.scala +++ b/project/AppDependencies.scala @@ -6,8 +6,8 @@ object AppDependencies { def apply(): Seq[ModuleID] = dependencies ++ testDependencies val bootstrapVersion = "9.19.0" val mongoVersion = "2.7.0" - val appEventVersion = "0.88.0" - val appDomainVersion = "0.87.0" + val appEventVersion = "0.90.0" + val appDomainVersion = "0.90.0" val mockitoScalaVersion = "2.0.0" From e02141a693ae4d569453357c4fc4f98ff4f914ba Mon Sep 17 00:00:00 2001 From: Andy Spaven <16537059+AndySpaven@users.noreply.github.com> Date: Wed, 5 Nov 2025 13:48:52 +0000 Subject: [PATCH 2/3] API-8737 - PR Bot comments --- project/AppDependencies.scala | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/project/AppDependencies.scala b/project/AppDependencies.scala index 5c98c3f8..61add096 100644 --- a/project/AppDependencies.scala +++ b/project/AppDependencies.scala @@ -5,7 +5,7 @@ import play.sbt.PlayImport._ object AppDependencies { def apply(): Seq[ModuleID] = dependencies ++ testDependencies val bootstrapVersion = "9.19.0" - val mongoVersion = "2.7.0" + val mongoVersion = "2.10.0" val appEventVersion = "0.90.0" val appDomainVersion = "0.90.0" val mockitoScalaVersion = "2.0.0" @@ -23,7 +23,7 @@ object AppDependencies { // "uk.gov.hmrc" %% "api-platform-application-domain" % appDomainVersion, "com.github.blemale" %% "scaffeine" % "5.2.1", "com.lihaoyi" %% "sourcecode" % "0.3.0", - "uk.gov.hmrc" %% "crypto-json-play-30" % "8.3.0", + "uk.gov.hmrc" %% "crypto-json-play-30" % "8.4.0", "org.typelevel" %% "cats-core" % "2.10.0" ) From 44364de572c8b1ba3cc67b3f4c8867bd4beed57d Mon Sep 17 00:00:00 2001 From: Andy Spaven <16537059+AndySpaven@users.noreply.github.com> Date: Wed, 5 Nov 2025 14:01:33 +0000 Subject: [PATCH 3/3] API-8737 - PR Bot comments --- project/plugins.sbt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/project/plugins.sbt b/project/plugins.sbt index 3597c45b..4af3d34a 100644 --- a/project/plugins.sbt +++ b/project/plugins.sbt @@ -4,7 +4,7 @@ resolvers += Resolver.typesafeRepo("releases") addSbtPlugin("uk.gov.hmrc" % "sbt-auto-build" % "3.24.0") addSbtPlugin("uk.gov.hmrc" % "sbt-distributables" % "2.6.0") -addSbtPlugin("org.playframework" % "sbt-plugin" % "3.0.8") +addSbtPlugin("org.playframework" % "sbt-plugin" % "3.0.9") addSbtPlugin("org.scoverage" % "sbt-scoverage" % "2.3.1") addSbtPlugin("org.scalastyle" % "scalastyle-sbt-plugin" % "1.0.0") addSbtPlugin("ch.epfl.scala" % "sbt-bloop" % "2.0.6")