Add JRuby support and automated gem release workflow

Author: sferik

.github/workflows/push.yml

@@ -0,0 +1,46 @@
+name: Push gem to RubyGems
+
+on:
+  push:
+    tags:
+      - "v*"
+
+permissions:
+  contents: read
+
+jobs:
+  push:
+    if: github.repository == 'httprb/http'
+    runs-on: ubuntu-latest
+
+    environment:
+      name: rubygems.org
+      url: https://rubygems.org/gems/http
+
+    permissions:
+      contents: write
+      id-token: write
+
+    strategy:
+      matrix:
+        ruby: [ ruby, jruby ]
+
+    steps:
+      - uses: actions/checkout@v6
+
+      - uses: ruby/setup-ruby@v1
+        with:
+          ruby-version: ${{ matrix.ruby }}
+          bundler-cache: true
+
+      - uses: rubygems/release-gem@v1
+        env:
+          HTTP_PLATFORM: ${{ matrix.ruby == 'jruby' && 'java' || '' }}
+
+      - name: Create GitHub release
+        run: |
+          tag_name="$(git describe --tags --abbrev=0)"
+          gh release create "${tag_name}" --verify-tag --generate-notes
+        env:
+          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+        if: matrix.ruby == 'ruby'

.github/workflows/test.yml

@@ -7,7 +7,7 @@ on:
     branches: [ main ]
 
 env:
-  BUNDLE_WITHOUT: "development"
+  BUNDLE_WITHOUT: "development:sig"
 
 jobs:
   test:
@@ -27,3 +27,4 @@ jobs:
 
       - name: bundle exec rake test
         run: bundle exec rake test
+        timeout-minutes: 10

Gemfile

@@ -23,16 +23,19 @@ group :test do
   gem "simplecov",      require: false
   gem "simplecov-lcov", require: false
 
-  gem "minitest-memory"
+  gem "minitest-memory", platform: :mri
   gem "minitest-mock"
   gem "minitest-strict"
 
   gem "mutant-minitest"
 
-  gem "steep"
   gem "yardstick"
 end
 
+group :sig do
+  gem "steep"
+end
+
 group :doc do
   gem "kramdown"
   gem "yard"

http.gemspec

@@ -40,10 +40,10 @@ Gem::Specification.new do |spec|
   spec.add_dependency "http-cookie",    "~> 1.0"
   spec.add_dependency "http-form_data", "~> 2.2"
 
-  # Use native llhttp for MRI (more performant) and llhttp-ffi for other interpreters (better compatibility)
-  if RUBY_ENGINE == "ruby"
-    spec.add_dependency "llhttp", "~> 0.6.1"
-  else
+  if RUBY_ENGINE == "jruby"
+    spec.platform = "java" if ENV["HTTP_PLATFORM"] == "java"
     spec.add_dependency "llhttp-ffi", "~> 0.5.1"
+  else
+    spec.add_dependency "llhttp", "~> 0.6.1"
   end
 end

lib/http/options.rb

@@ -231,7 +231,9 @@ def assign_options(env)
     # @api private
     # @return [void]
     def argument_error!(message)
-      raise(Error, message, caller(1..-1))
+      error = Error.new(message)
+      error.set_backtrace(caller(1) || [])
+      raise error
     end
   end
 end

test/http/base64_test.rb

@@ -1,7 +1,6 @@
 # frozen_string_literal: true
 
 require "test_helper"
-require "base64"
 
 describe HTTP::Base64 do
   cover "HTTP::Base64*"
@@ -16,10 +15,10 @@
       assert_equal "aGVsbG8=", encoder.send(:encode64, "hello")
     end
 
-    it "produces output decodable by standard Base64" do
+    it "produces output that round-trips back to the original input" do
       input = "user:password"
 
-      assert_equal input, Base64.strict_decode64(encoder.send(:encode64, input))
+      assert_equal input, encoder.send(:encode64, input).unpack1("m0")
     end
 
     it "encodes empty string" do

test/http/client_test.rb

@@ -407,7 +407,7 @@ def on_error(request, error)
 
         assert_raises(HTTP::TimeoutError) do
           client.use(test_feature: feature_instance)
-                .timeout(0.025)
+                .timeout(0.01)
                 .request(:post, sleep_url)
         end
 
@@ -420,7 +420,7 @@ def on_error(request, error)
         sleep_url = "#{dummy.endpoint}/sleep"
         feature_instance = feature_class.new
 
-        TCPSocket.stub(:open, ->(*) { sleep 1 }) do
+        TCPSocket.stub(:open, ->(*) { sleep 0.1 }) do
           assert_raises(HTTP::ConnectTimeoutError) do
             client.use(test_feature: feature_instance)
                   .timeout(0.001)

test/http/headers/normalizer_test.rb

@@ -28,17 +28,19 @@
       assert normalized_headers.none?(&:frozen?)
     end
 
-    it "allocates minimal memory for normalization of the same header" do
-      normalizer.call("accept") # Ensure normalizer is pre-allocated
-
-      # On first call it is expected to allocate during normalization
-      assert_allocations(Array: 1, MatchData: 1, String: 6) do
-        normalizer.call("content_type")
-      end
-
-      # On subsequent call it is expected to only allocate copy of a cached string
-      assert_allocations(Array: 0, MatchData: 0, String: 1) do
-        normalizer.call("content_type")
+    if RUBY_ENGINE == "ruby"
+      it "allocates minimal memory for normalization of the same header" do
+        normalizer.call("accept") # Ensure normalizer is pre-allocated
+
+        # On first call it is expected to allocate during normalization
+        assert_allocations(Array: 1, MatchData: 1, String: 6) do
+          normalizer.call("content_type")
+        end
+
+        # On subsequent call it is expected to only allocate copy of a cached string
+        assert_allocations(Array: 0, MatchData: 0, String: 1) do
+          normalizer.call("content_type")
+        end
       end
     end
 

test/http/retriable/performer_test.rb

@@ -233,7 +233,19 @@ def response(**options)
     end
 
     describe "delay option" do
-      let(:timing_slack) { 0.05 }
+      it "sleeps for the calculated delay" do
+        slept_values = []
+        performer = HTTP::Retriable::Performer.new(delay: 0.123, tries: 2, should_retry: ->(*) { true })
+        performer.define_singleton_method(:sleep) { |d| slept_values << d }
+
+        assert_raises(HTTP::OutOfRetriesError) do
+          performer.perform(client, request) { response }
+        end
+
+        assert_equal [0.123], slept_values
+      end
+
+      let(:timing_slack) { 0.5 }
 
       it "can be a positive number" do
         time, = measure_wait do

test/http/session_test.rb

@@ -185,7 +185,7 @@
 
   describe "thread safety" do
     it "can be shared across threads without errors" do
-      shared_session = HTTP.headers("Accept" => "text/html").timeout(5)
+      shared_session = HTTP.headers("Accept" => "text/html").timeout(15)
       errors = []
       mutex = Mutex.new