Expand waterfall span width to include child spans outside of parent span duration

[akalitenya]

Sometimes, spans are displayed correctly, and sometimes not.

The duration of the interval was 2344 ms, but the scale is 600 ms.

clickhouse/clickstack-all-in-one:2.9.0

[pulpdrew]

Hi @akalitenya - it looks like the scale is 600 seconds, not 600ms. Would that explain the result you are seeing?

[akalitenya]

Hi. Thanks! I didn't notice that.

I tried to use @opentelemetry/instrumentation-user-interaction, and it created "Navigation" that is parent for many unrelated user actions for some reason. This parent span in folded state has length of 1.7 seconds. In unfolded state it shows 600 seconds. Is it by design?

[pulpdrew]

The waterfall will expand its time scale to contain all of the non-hidden spans in the trace. It looks like you have a child span with a timestamp and duration that puts it outside of the timespan of the parent span. Showing this child span results in a much longer timespan in the waterfall diagram. It looks like in both cases, the actual duration of the parent span matches the value in the Span's Duration column. This is by design.

Are the child spans completely unrelated to the parent span in this case, or do they have incorrect timestamps? If so, this seems like it could be an instrumentation problem.

[akalitenya]

I see that it is not a bug. But I have suggestion to improve UI.

If it is a valid case for instrumentation libs that they can produce parent span duration, and later other spans can be added as child spans. Then maybe HyperDX can show parent span full duration that will correspond to the last child span end time?

The original duration of the parent interval will be visually displayed as the initial part of the full duration of the parent interval. So visual duration will not change based on fold/unfold.

[pulpdrew]

Thank you for the suggestion! I'll file this as an enhancement request.