Refactor test providers and constructor property visibility (#7444)

huangdijia · web-flow · commit 3e3501501e2a · 2025-07-07T10:01:34.000+08:00
diff --git a/tests/StrTest.php b/tests/StrTest.php
@@ -431,12 +431,6 @@ public function testValidUrls($url)
         $this->assertTrue(Str::isUrl($url));
     }
 
-    #[DataProvider('invalidUrls')]
-    public function testInvalidUrls($url)
-    {
-        $this->assertFalse(Str::isUrl($url));
-    }
-
     public static function validUrls()
     {
         return [
@@ -679,6 +673,12 @@ public static function validUrls()
         ];
     }
 
+    #[DataProvider('invalidUrls')]
+    public function testInvalidUrls($url)
+    {
+        $this->assertFalse(Str::isUrl($url));
+    }
+
     public static function invalidUrls()
     {
         return [

Original file line number	Diff line number	Diff line change
`@@ -431,12 +431,6 @@ public function testValidUrls($url)`
`431`	`431`	`$this->assertTrue(Str::isUrl($url));`
`432`	`432`	`}`
`433`	`433`
`434`		`- #[DataProvider('invalidUrls')]`
`435`		`- public function testInvalidUrls($url)`
`436`		`- {`
`437`		`- $this->assertFalse(Str::isUrl($url));`
`438`		`- }`
`439`		`-`
`440`	`434`	`public static function validUrls()`
`441`	`435`	`{`
`442`	`436`	`return [`
`@@ -679,6 +673,12 @@ public static function validUrls()`
`679`	`673`	`];`
`680`	`674`	`}`
`681`	`675`
	`676`	`+ #[DataProvider('invalidUrls')]`
	`677`	`+ public function testInvalidUrls($url)`
	`678`	`+ {`
	`679`	`+ $this->assertFalse(Str::isUrl($url));`
	`680`	`+ }`
	`681`	`+`
`682`	`682`	`public static function invalidUrls()`
`683`	`683`	`{`
`684`	`684`	`return [`