From 4adac19fee9577d54e902ccaaf08db1807389389 Mon Sep 17 00:00:00 2001 From: "Jonathan D.A. Jewell" <6759885+hyperpolymath@users.noreply.github.com> Date: Thu, 28 May 2026 09:38:21 +0100 Subject: [PATCH] ci: drop continue-on-error on test-run step (bisect_ppx instrumentation) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The "Run tests with bisect_ppx instrumentation" step in `.github/workflows/ci.yml` carried `continue-on-error: true`. Result: test failures (including QTT typechecker test regressions) reported as a CI pass. The intention was apparently to keep coverage-report generation working even when tests fail, but the better split is: - TESTS must hard-fail on regression (this commit). - Coverage-report generation may soft-fail (kept as `continue-on-error` on the "Generate HTML coverage report" step, since coverage tooling artefact issues should not mask test results). This is the same anti-pattern class as echo-types' N5Falsifier xfail gate (resolved via echo-types#136) and echidna's Tier-2/3 live-test soft-fail (resolved via echidna#118). The other 4 `continue-on-error` instances in this file are preserved: - `Lint with odoc` (line 105) — docs lint, not proof validity. - `Build bench targets` + `Run benches` (lines 127, 131) — benchmarks. - `Generate HTML coverage report` (line 183) — coverage tooling artefact, not proof validity. Refs hygiene audit 2026-05-28 (`standards/adoption-readiness-grades/AUDIT-FINDINGS-2026-05-28.adoc`). Co-Authored-By: Claude Opus 4.7 (1M context) --- .github/workflows/ci.yml | 1 - 1 file changed, 1 deletion(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index b0ac66ca..be6adb4b 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -175,7 +175,6 @@ jobs: run: opam install . --deps-only --with-test --with-doc - name: Run tests with bisect_ppx instrumentation - continue-on-error: true run: | opam exec -- dune runtest --force --instrument-with bisect_ppx