From b070acfe6d3636d5ef5ec7592cbfcc7e76a50e70 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Bertrand=20d=27H=C3=A9rouville?= Date: Mon, 12 Jan 2026 10:55:29 +0100 Subject: [PATCH 1/4] Update target.h for OMNIBUSF4PRO_MPOSD configuration Updated target.h as suggested by qodo-code-review[bot] on maintenance branch --- src/main/target/OMNIBUSF4/target.h | 21 +++++++++++++++++---- 1 file changed, 17 insertions(+), 4 deletions(-) diff --git a/src/main/target/OMNIBUSF4/target.h b/src/main/target/OMNIBUSF4/target.h index fcd89fb0e46..c7091fa4e0a 100644 --- a/src/main/target/OMNIBUSF4/target.h +++ b/src/main/target/OMNIBUSF4/target.h @@ -17,10 +17,12 @@ #pragma once -//Same target as OMNIBUSF4PRO with LED strip in M5 -#ifdef OMNIBUSF4PRO_LEDSTRIPM5 +// OMNIBUSF4PRO_MPOSD: OMNIBUSF4PRO with LED strip on M5 and MPOSD on PA0 (OpenIPC). +#ifdef OMNIBUSF4PRO_MPOSD #define OMNIBUSF4PRO +#define OMNIBUSF4PRO_LEDSTRIPM5 #endif + //Same target as OMNIBUSF4V3 with softserial in M5 and M6 #if defined(OMNIBUSF4V3_S6_SS) || defined(OMNIBUSF4V3_S5S6_SS) || defined(OMNIBUSF4V3_S5_S6_2SS) #define OMNIBUSF4V3 @@ -146,6 +148,11 @@ #define UART3_RX_PIN PB11 #define UART3_TX_PIN PB10 +#if defined(USE_MPOSD_ON_PA0) +#define USE_UART4 +#define UART4_TX_PIN PA0 +#endif + #define USE_UART6 #define UART6_RX_PIN PC7 #define UART6_TX_PIN PC6 @@ -249,12 +256,18 @@ #ifdef DYSF4PRO #define ADC_CHANNEL_3_PIN PC3 #else - #define ADC_CHANNEL_3_PIN PA0 + #if !defined(USE_MPOSD_ON_PA0) + #define ADC_CHANNEL_3_PIN PA0 + #endif #endif #define CURRENT_METER_ADC_CHANNEL ADC_CHN_1 #define VBAT_ADC_CHANNEL ADC_CHN_2 -#define RSSI_ADC_CHANNEL ADC_CHN_3 +#if defined(OMNIBUSF4PRO_MPOSD) + #define RSSI_ADC_CHANNEL ADC_CHN_NONE +#else + #define RSSI_ADC_CHANNEL ADC_CHN_3 +#endif #define SENSORS_SET (SENSOR_ACC|SENSOR_MAG|SENSOR_BARO) From 391f89fdc9c20c233dd98523a33b3cb94fac597e Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Bertrand=20d=27H=C3=A9rouville?= Date: Mon, 12 Jan 2026 11:42:22 +0100 Subject: [PATCH 2/4] Update src/main/target/OMNIBUSF4/target.h Co-authored-by: qodo-code-review[bot] <151058649+qodo-code-review[bot]@users.noreply.github.com> --- src/main/target/OMNIBUSF4/target.h | 1 + 1 file changed, 1 insertion(+) diff --git a/src/main/target/OMNIBUSF4/target.h b/src/main/target/OMNIBUSF4/target.h index c7091fa4e0a..647bd1b6b5f 100644 --- a/src/main/target/OMNIBUSF4/target.h +++ b/src/main/target/OMNIBUSF4/target.h @@ -21,6 +21,7 @@ #ifdef OMNIBUSF4PRO_MPOSD #define OMNIBUSF4PRO #define OMNIBUSF4PRO_LEDSTRIPM5 +#define USE_MPOSD_ON_PA0 #endif //Same target as OMNIBUSF4V3 with softserial in M5 and M6 From 73011d74b38eedccc7241d2c760c7acb9c9bf71f Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Bertrand=20d=27H=C3=A9rouville?= Date: Mon, 12 Jan 2026 11:42:37 +0100 Subject: [PATCH 3/4] Update src/main/target/OMNIBUSF4/target.h Co-authored-by: qodo-code-review[bot] <151058649+qodo-code-review[bot]@users.noreply.github.com> --- src/main/target/OMNIBUSF4/target.h | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/main/target/OMNIBUSF4/target.h b/src/main/target/OMNIBUSF4/target.h index 647bd1b6b5f..d65d5cd1fdd 100644 --- a/src/main/target/OMNIBUSF4/target.h +++ b/src/main/target/OMNIBUSF4/target.h @@ -257,8 +257,10 @@ #ifdef DYSF4PRO #define ADC_CHANNEL_3_PIN PC3 #else - #if !defined(USE_MPOSD_ON_PA0) - #define ADC_CHANNEL_3_PIN PA0 + #if defined(USE_MPOSD_ON_PA0) + #define ADC_CHANNEL_3_PIN NONE + #else + #define ADC_CHANNEL_3_PIN PA0 #endif #endif From 733fd9483f7b7750317db9e6a3fe8c1aaa5ebd95 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Bertrand=20d=27H=C3=A9rouville?= Date: Mon, 12 Jan 2026 11:47:49 +0100 Subject: [PATCH 4/4] Change RSSI_ADC_CHANNEL definition condition Use USE_MPOSD_ON_PA0 for rssi logc --- src/main/target/OMNIBUSF4/target.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/main/target/OMNIBUSF4/target.h b/src/main/target/OMNIBUSF4/target.h index d65d5cd1fdd..29fb59c6161 100644 --- a/src/main/target/OMNIBUSF4/target.h +++ b/src/main/target/OMNIBUSF4/target.h @@ -266,7 +266,7 @@ #define CURRENT_METER_ADC_CHANNEL ADC_CHN_1 #define VBAT_ADC_CHANNEL ADC_CHN_2 -#if defined(OMNIBUSF4PRO_MPOSD) +#if defined(USE_MPOSD_ON_PA0) #define RSSI_ADC_CHANNEL ADC_CHN_NONE #else #define RSSI_ADC_CHANNEL ADC_CHN_3