Skip to content

Commit 11fb58a

Browse files
committed
fix(tests): update subtitle overlay references from "l-subtitle" to "l-subtitles"
1 parent df26dbd commit 11fb58a

File tree

2 files changed

+5
-5
lines changed

2 files changed

+5
-5
lines changed

src/imagekitio/lib/helper.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -296,7 +296,7 @@ def _process_overlay(overlay: Overlay) -> str:
296296
parsed_overlay.append(_process_input_path(video_input, video_encoding))
297297

298298
elif overlay_type == "subtitle":
299-
parsed_overlay.append("l-subtitle")
299+
parsed_overlay.append("l-subtitles")
300300

301301
subtitle_input = cast(str, overlay.get("input", ""))
302302
if not subtitle_input:

tests/custom/url_generation/test_overlay.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -122,7 +122,7 @@ def test_should_generate_url_with_subtitle_overlay_from_input_file(self):
122122
transformation_position="path",
123123
transformation=[{"overlay": {"type": "subtitle", "input": "subtitle.srt"}}],
124124
)
125-
expected = "https://ik.imagekit.io/test_url_endpoint/tr:l-subtitle,i-subtitle.srt,l-end/base-video.mp4"
125+
expected = "https://ik.imagekit.io/test_url_endpoint/tr:l-subtitles,i-subtitle.srt,l-end/base-video.mp4"
126126
assert url == expected
127127

128128
def test_should_generate_url_with_solid_color_overlay_using_background_color(self):
@@ -238,7 +238,7 @@ def test_should_generate_url_with_multiple_complex_overlays_including_nested_tra
238238
},
239239
],
240240
)
241-
expected = "https://ik.imagekit.io/test_url_endpoint/tr:l-text,i-Every%20thing,lx-10,ly-20,lfo-center,lso-5,leo-15,ldu-10,w-bw_mul_0.5,fs-20,ff-Arial,co-0000ff,ia-left,pa-5,al-7,tg-b,bg-red,r-10,rt-N45,fl-h,lh-20,l-end:l-image,i-logo.png,lx-10,ly-20,lfo-center,lso-5,leo-15,ldu-10,w-bw_mul_0.5,h-bh_mul_0.5,rt-N45,fl-h,l-text,i-Nested%20text%20overlay,l-end,l-end:l-video,i-play-pause-loop.mp4,lx-10,ly-20,lfo-center,lso-5,leo-15,ldu-10,w-bw_mul_0.5,h-bh_mul_0.5,rt-N45,fl-h,l-end:l-subtitle,i-subtitle.srt,lx-10,ly-20,lfo-center,lso-5,leo-15,ldu-10,bg-red,co-0000ff,ff-Arial,fol-2_A1CCDD50,fsh-A1CCDD_3,l-end:l-image,i-ik_canvas,bg-FF0000,lx-10,ly-20,lfo-center,lso-5,leo-15,ldu-10,w-bw_mul_0.5,h-bh_mul_0.5,al-0.5,bg-red,e-gradient,r-max,l-end/base-image.jpg"
241+
expected = "https://ik.imagekit.io/test_url_endpoint/tr:l-text,i-Every%20thing,lx-10,ly-20,lfo-center,lso-5,leo-15,ldu-10,w-bw_mul_0.5,fs-20,ff-Arial,co-0000ff,ia-left,pa-5,al-7,tg-b,bg-red,r-10,rt-N45,fl-h,lh-20,l-end:l-image,i-logo.png,lx-10,ly-20,lfo-center,lso-5,leo-15,ldu-10,w-bw_mul_0.5,h-bh_mul_0.5,rt-N45,fl-h,l-text,i-Nested%20text%20overlay,l-end,l-end:l-video,i-play-pause-loop.mp4,lx-10,ly-20,lfo-center,lso-5,leo-15,ldu-10,w-bw_mul_0.5,h-bh_mul_0.5,rt-N45,fl-h,l-end:l-subtitles,i-subtitle.srt,lx-10,ly-20,lfo-center,lso-5,leo-15,ldu-10,bg-red,co-0000ff,ff-Arial,fol-2_A1CCDD50,fsh-A1CCDD_3,l-end:l-image,i-ik_canvas,bg-FF0000,lx-10,ly-20,lfo-center,lso-5,leo-15,ldu-10,w-bw_mul_0.5,h-bh_mul_0.5,al-0.5,bg-red,e-gradient,r-max,l-end/base-image.jpg"
242242
assert url == expected
243243

244244
# Overlay encoding tests
@@ -379,7 +379,7 @@ def test_should_use_base64_encoding_when_explicitly_specified_for_subtitle_overl
379379
transformation_position="path",
380380
transformation=[{"overlay": {"type": "subtitle", "input": "sub.srt", "encoding": "base64"}}],
381381
)
382-
expected = "https://ik.imagekit.io/demo/tr:l-subtitle,ie-c3ViLnNydA%3D%3D,l-end/sample.mp4"
382+
expected = "https://ik.imagekit.io/demo/tr:l-subtitles,ie-c3ViLnNydA%3D%3D,l-end/sample.mp4"
383383
assert url == expected
384384

385385
def test_should_use_plain_encoding_when_explicitly_specified_for_subtitle_overlay(self):
@@ -390,7 +390,7 @@ def test_should_use_plain_encoding_when_explicitly_specified_for_subtitle_overla
390390
transformation_position="path",
391391
transformation=[{"overlay": {"type": "subtitle", "input": "/sub.srt", "encoding": "plain"}}],
392392
)
393-
expected = "https://ik.imagekit.io/demo/tr:l-subtitle,i-sub.srt,l-end/sample.mp4"
393+
expected = "https://ik.imagekit.io/demo/tr:l-subtitles,i-sub.srt,l-end/sample.mp4"
394394
assert url == expected
395395

396396
def test_should_properly_encode_overlay_text_when_transformations_are_in_query_parameters(self):

0 commit comments

Comments
 (0)