[NX-OS] Add ospf enablement to ospf interface reference

This patch automatically infers the configuration for bfd on an ospf
link according to the following config based on the `.spec.bfd.enabled`
field in the `Interface` resource.

```
interface Ethernet1/1
 ip ospf bfd
```

Author: felix-kaestner

internal/provider/cisco/nxos/ospf.go

@@ -81,6 +81,7 @@ type OSPFInterface struct {
 	ID                   string         `json:"id"`
 	NwT                  NtwType        `json:"nwT"`
 	PassiveCtrl          PassiveControl `json:"passiveCtrl"`
+	BFDCtrl              OspfBfdCtrl    `json:"bfdCtrl"`
 }
 
 func (i *OSPFInterface) Key() string { return i.ID }
@@ -112,7 +113,7 @@ type OSPFIfAdjEpGroup struct {
 	OperSt        AdjOperSt `json:"operSt"` // Adjacency neighbor state
 	Prio          uint8     `json:"prio"`   // Priority, used in determining the designated router on this network
 	AdjStatsItems struct {
-		LastStChgTs time.Time `json:"lastStChgTs"` // Timestamp of the last state change
+		LastStChgTS time.Time `json:"lastStChgTs"` // Timestamp of the last state change
 	} `json:"adjstats-items,omitzero"`
 }
 
@@ -202,3 +203,11 @@ const (
 	PassiveControlEnabled     PassiveControl = "enabled"
 	PassiveControlDisabled    PassiveControl = "disabled"
 )
+
+type OspfBfdCtrl string
+
+const (
+	OspfBfdCtrlUnspecified OspfBfdCtrl = "unspecified"
+	OspfBfdCtrlEnabled     OspfBfdCtrl = "enabled"
+	OspfBfdCtrlDisabled    OspfBfdCtrl = "disabled"
+)

internal/provider/cisco/nxos/ospf_test.go

@@ -23,6 +23,7 @@ func init() {
 			Area:                 "0.0.0.0",
 			NwT:                  NtwTypeUnspecified,
 			PassiveCtrl:          PassiveControlUnspecified,
+			BFDCtrl:              OspfBfdCtrlUnspecified,
 		}
 		if strings.HasPrefix(name, "eth") {
 			intf.NwT = NtwTypePointToPoint

internal/provider/cisco/nxos/provider.go

@@ -1440,13 +1440,17 @@ func (p *Provider) EnsureOSPF(ctx context.Context, req *provider.EnsureOSPFReque
 		}
 	}
 
+	conf := make([]gnmiext.Configurable, 0, 3)
+
 	f := new(Feature)
 	f.Name = "ospf"
 	f.AdminSt = AdminStEnabled
+	conf = append(conf, f)
 
 	o := new(OSPF)
 	o.AdminSt = AdminStEnabled
 	o.Name = req.OSPF.Spec.Instance
+	conf = append(conf, o)
 
 	dom := new(OSPFDom)
 	dom.Name = DefaultVRFName
@@ -1502,6 +1506,18 @@ func (p *Provider) EnsureOSPF(ctx context.Context, req *provider.EnsureOSPFReque
 		if iface.Passive == nil || !*iface.Passive {
 			intf.PassiveCtrl = PassiveControlDisabled
 		}
+		intf.BFDCtrl = OspfBfdCtrlUnspecified
+		if iface.Interface.Spec.BFD != nil {
+			fb := new(Feature)
+			fb.Name = "bfd"
+			fb.AdminSt = AdminStEnabled
+			conf = slices.Insert(conf, 1, gnmiext.Configurable(fb)) // insert before OSPF
+
+			intf.BFDCtrl = OspfBfdCtrlDisabled
+			if !iface.Interface.Spec.BFD.Enabled {
+				intf.BFDCtrl = OspfBfdCtrlEnabled
+			}
+		}
 		dom.IfItems.IfList.Set(intf)
 	}
 
@@ -1529,7 +1545,7 @@ func (p *Provider) EnsureOSPF(ctx context.Context, req *provider.EnsureOSPFReque
 		dom.MaxlsapItems.MaxLsa = cfg.MaxLSA
 	}
 
-	return p.client.Update(ctx, f, o)
+	return p.client.Update(ctx, conf...)
 }
 
 func (p *Provider) DeleteOSPF(ctx context.Context, req *provider.DeleteOSPFRequest) error {
@@ -1567,7 +1583,7 @@ func (p *Provider) GetOSPFStatus(ctx context.Context, req *provider.OSPFStatusRe
 				Address:             adj.PeerIP,
 				Interface:           i,
 				Priority:            adj.Prio,
-				LastEstablishedTime: adj.AdjStatsItems.LastStChgTs,
+				LastEstablishedTime: adj.AdjStatsItems.LastStChgTS,
 				AdjacencyState:      adj.OperSt.ToNeighborState(),
 			})
 		}

internal/provider/cisco/nxos/testdata/ospf.json

@@ -23,7 +23,8 @@
                       "area": "0.0.0.0",
                       "id": "eth1/1",
                       "nwT": "p2p",
-                      "passiveCtrl": "unspecified"
+                      "passiveCtrl": "unspecified",
+                      "bfdCtrl": "unspecified"
                     }
                   ]
                 },