Global API limit

[pesseyjulien]

Hi,

How to make a global rate limit. I can only make it work using Controller annotation per method. Here is my config :

Thanks in advance,
Julien

[jason-linthwaite]

+1 to this. I have set the "path_limits" in the config file to my root API path but it seems to have no effect.
I don't want to have to specify this on every controller. Is this the intended action? If so, why require the path limits config?

[ndench]

This issue is pretty old now. Has anyone fond a way to achieve a global rate limit?

[pesseyjulien]

path_limits:
- { path: /, limit: 1000, period: 3600 }

[goetas]

You have the full config list at https://github.com/jaytaph/RateLimitBundle#configuration-reference

[ndench]

Ah that's great thanks! This issue can probably be closed then?

…

On Tue., 22 Oct. 2019, 5:12 pm Asmir Mustafic, ***@***.***> wrote: You have the full config list at https://github.com/jaytaph/RateLimitBundle#configuration-reference — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#74?email_source=notifications&email_token=AAPXQNC4BKQYR3D4UX7FD23QP2RUHA5CNFSM4FNJ7ASKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEB4YFRA#issuecomment-544834244>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAPXQNGYWFB7DSQENONYM5LQP2RUHANCNFSM4FNJ7ASA> .

[stefanides]

Hi, I am trying to use pesseyjulien's solution above for global limit for all routes. Once the path config contains something more than '/', the PathLimitProcessor compares it by parts in pathMatched() method and it works fine as prefix. However, when the path is just '/', it gets trimmed in constructor to an empty string and then pathMatched() compares '' to any string present in URL, which is false - except the homepage path itself. The same can be seen watching http headers - they are present only for '/' route and no other/longer path. Should there be some more test for this scenario inside pathMatched() like
if (count($expectedParts) == 1 && $expectedParts[0] == '') { return true; }
?
Then also the constructor needs to be updated - to sort '' lower than 'xyz' paths even they have the same substr_count(), current code keeps the original sort from config file.

Tested on "version": "1.15.1"

[abarkine]

This issue can be closed as it seems like #119

New usage:

path_limits:
- { path: *, method: *, limit: 1000, period: 3600 }