Addition of fail open

[phillipsb22]

Good day,

We have added in an option to fail open if for any reason the limitRate function fails. For example server dies or network failure etc.

We have added this to the annotation to make the fail open dynamic.

If you could we would like your thoughts on the implementation and whether or not you would be willing to include the change in your version

here is the link to the branch

Brandon

[jaytaph]

Hello Brandon,

Thanks for your contribution. I think this makes a lot of sense and actually, I've needed the same functionality before. Could you open a pull request so we can discuss and hopefully merge this into the code?

[orlandothoeny]

Hello @jaytaph,

We would be happy to implement this feature by introducing an additional Bundle config boolean-flag that allows users to enable/disable this behaviour globally.

Is this a feature that you would be willing to merge?

[jaytaph]

hi @orlandothoeny I think the best you can do is ask @goetas I'm currently not doing active work on the bundle.

[goetas]

hi, overall I think that is a nice feature and i can review a PR if you plan to submit it. I can see a small issue in your branch (not rethrowing the exception with failopen false)

[orlandothoeny]

ℹ️ I'm working on this

I'll have a look at the existing branch (it's not from me).
And either continue there or start a new one.