Merge pull request #25 from jonny64/issue_23

+0pdd

Author: jonny64

.github/workflows/pdd.yml

@@ -0,0 +1,14 @@
+name: pdd
+on:
+  push:
+    branches:
+      - main
+  pull_request:
+    branches:
+      - main
+jobs:
+  pdd:
+    runs-on: ubuntu-22.04
+    steps:
+      - uses: actions/checkout@v4
+      - uses: volodya-lombrozo/pdd-action@master

eslint.config.js

@@ -3,6 +3,7 @@ const pluginJs = require("@eslint/js");
 const pluginNoFloatingPromise = require("eslint-plugin-no-floating-promise");
 const pluginSonarjs = require("eslint-plugin-sonarjs");
 
+// @todo #0:1h fix npx eslint . cause 'Warning: React version not specified in eslint-plugin-react settings.'
 module.exports = [{
 	files: ["**/*.js"],
 	languageOptions: {
@@ -19,6 +20,7 @@ module.exports = [{
 		"no-unused-vars": "off",
 		"sonarjs/sonar-no-unused-vars": "off",
 		"sonarjs/sonar-no-fallthrough": "off",
+		"sonarjs/todo-tag": "off",
 
 		"no-floating-promise/no-floating-promise": "error",
 		"sonarjs/cognitive-complexity": ["error", 15],

lib/GitBranch.js

@@ -3,6 +3,7 @@ const ShellCommand = require ('./ShellCommand')
 
 module.exports = class GitBranch {
 
+	// @todo #0:30m rename to withName
 	static createByName (id, gitRepo = new GitRepo ()) {
 		let [origin, name] = id.split ('/')
 		if (!name) {

lib/SwitchCommand.js

@@ -16,6 +16,8 @@ module.exports = class {
 				{
 					todo: `switch --merge --guess ${dst}`,
 					fail: {
+						// @todo #0:1h decompose to separate SwitchCommand and CreateCommand
+						// then remove ugly fail fallback
 						todo: `switch --guess --merge --create ${dst} ${src}`,
 						confirm: `Create new branch '${dst}' from '${src}' [Y/n]? `,
 					}

lib/UserInput.js

@@ -1,6 +1,8 @@
 
 const readline = require('readline')
 
+// @todo #0:1h add tests
+// @todo #0:1h press 'y' or 'n' without Enter should be sufficient
 module.exports = class {
 	constructor(question) {
 		this.question = question

mr.js

@@ -2,6 +2,7 @@
 const ParsedArgs = require('./lib/ParsedArgs')
 const MrCommand = require('./lib/MrCommand')
 const GitRepo = require('./lib/GitRepo')
+// @todo #0:30m move to lib/commands/Push, lib/commands/Switch, etc.
 const RunCommand = require('./lib/RunCommand')
 const Push  = require('./lib/PushCommand')
 const Switch  = require('./lib/SwitchCommand')

tests/GitBranch.js

@@ -2,7 +2,7 @@ const {describe, it, mock} = require ('node:test')
 const assert = require ('assert')
 const GitBranch = require ('../lib/GitBranch')
 
-
+// @todo #0:1h improve file coverage at least funcs % 70
 describe('git branch equals', () => {
 	let task42 = new GitBranch ({name: 'TASK-42', origin: 'origin'})
 	let task43 = new GitBranch ({name: 'TASK-43', origin: 'origin'})