cloud_deps: read auth0 creds from terraform_remote_state#45
Open
entlein wants to merge 2 commits into
Open
Conversation
The kubeconfig path was misspelled in cloud_deps/provider.tf, causing the kubernetes and kustomization providers to look for the kubeconfig at ~/.kube/cockpick-config rather than ~/.kube/cockpit-config.
Replace the sops_file-based lookup of auth0_config.yaml with a data.terraform_remote_state.auth0 reference so the cloud_deps state can consume the live values produced by the auth0 terraform run instead of relying on a separately-encrypted committed file. - core_resource_deps.tf: data.sops_file.auth0 -> data.terraform_remote_state.auth0 - variables.tf: new auth0_state_* vars (backend config for the remote state) - provider.tf: drop the sops provider (no longer referenced) Outputs expected on the auth0 state: pixie_client_id, pixie_client_secret.
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacks on top of #44 (cockpit typo fix) which stacks on #41.
Replace the sops_file-based lookup of
terraform/credentials/cockpit/auth0_config.yamlwithdata.terraform_remote_state.auth0. Lets the cloud_deps state consume client_id/secret from the live auth0 terraform state instead of relying on a committed SOPS file (which only contains one specific tenant's values).Changes
core_resource_deps.tf—data.sops_file.auth0→data.terraform_remote_state.auth0;kubernetes_secret_v1.cloud_auth0readsoutputs.pixie_client_id/outputs.pixie_client_secret.variables.tf— newauth0_state_*vars to configure the remote state backend.provider.tf— drop thesopsprovider (no longer used).Required on the auth0 state
The remote state must expose:
output "pixie_client_id"output "pixie_client_secret"(sensitive)These wrap whichever
auth0_client/auth0_client_credentialsresource pair represents Pixie Cloud in the relevant tenant.