Refactor signup to use DB trigger for profile creation

Profile creation during signup is now handled by the database trigger 'on_auth_user_created' instead of client-side code. This change avoids race conditions and client-side RLS issues. Minor formatting improvements were also made throughout the file.

Author: DongDuong2001

lib/features/auth/auth-service.ts

@@ -36,20 +36,20 @@ export function getCurrentUser(): User | null {
 // Async version that fetches from Supabase and updates cache
 export async function getCurrentUserAsync(): Promise<User | null> {
   if (typeof window === "undefined") return null
-  
+
   try {
     const supabase = createClient()
     const { data: { user: authUser }, error } = await supabase.auth.getUser()
-    
+
     if (error || !authUser) return null
-    
+
     // Fetch user profile from database
     const { data: profile, error: profileError } = await supabase
       .from('profiles')
       .select('*')
       .eq('id', authUser.id)
       .single()
-    
+
     if (profileError || !profile) {
       // Return basic user info if profile doesn't exist
       return {
@@ -60,7 +60,7 @@ export async function getCurrentUserAsync(): Promise<User | null> {
         language: 'en'
       }
     }
-    
+
     return {
       id: profile.id,
       email: authUser.email || '',
@@ -95,7 +95,7 @@ export async function signUp(
 ): Promise<{ success: boolean; error?: string; user?: User }> {
   try {
     const supabase = createClient()
-    
+
     // Sign up with Supabase Auth
     const { data: authData, error: signUpError } = await supabase.auth.signUp({
       email,
@@ -107,41 +107,29 @@ export async function signUp(
         }
       }
     })
-    
+
     if (signUpError) {
       return { success: false, error: signUpError.message }
     }
-    
+
     if (!authData.user) {
       return { success: false, error: 'Sign up failed' }
     }
-    
-    // Create user profile in database
-    const { error: profileError } = await supabase
-      .from('profiles')
-      .insert({
-        id: authData.user.id,
-        email,
-        name,
-        language: language || 'en',
-        created_at: new Date().toISOString()
-      })
-    
-    if (profileError) {
-      console.error('Error creating profile:', profileError)
-    }
-    
+
+    // Profile creation is handled by the database trigger 'on_auth_user_created'
+    // This allows us to avoid race conditions and client-side RLS issues during signup
+
     const newUser: User = {
       id: authData.user.id,
       email,
       name,
       createdAt: new Date().toISOString(),
       language: language || 'en',
     }
-    
+
     // Cache user in localStorage
     localStorage.setItem("lab68_session", JSON.stringify(newUser))
-    
+
     return { success: true, user: newUser }
   } catch (error: any) {
     return { success: false, error: error.message || 'Sign up failed' }
@@ -156,27 +144,27 @@ export async function signIn(
 ): Promise<{ success: boolean; error?: string; user?: User }> {
   try {
     const supabase = createClient()
-    
+
     const { data: authData, error: signInError } = await supabase.auth.signInWithPassword({
       email,
       password,
     })
-    
+
     if (signInError) {
       return { success: false, error: signInError.message }
     }
-    
+
     if (!authData.user) {
       return { success: false, error: 'Sign in failed' }
     }
-    
+
     // Fetch user profile
     const { data: profile } = await supabase
       .from('profiles')
       .select('*')
       .eq('id', authData.user.id)
       .single()
-    
+
     const user: User = profile ? {
       id: profile.id,
       email: authData.user.email || '',
@@ -194,16 +182,16 @@ export async function signIn(
       createdAt: authData.user.created_at,
       language: 'en'
     }
-    
+
     // Cache user in localStorage
     localStorage.setItem("lab68_session", JSON.stringify(user))
-    
+
     if (rememberMe) {
       localStorage.setItem("lab68_remember", "true")
     } else {
       localStorage.removeItem("lab68_remember")
     }
-    
+
     return { success: true, user }
   } catch (error: any) {
     return { success: false, error: error.message || 'Sign in failed' }
@@ -240,7 +228,7 @@ export async function updateUserProfile(
 ): Promise<{ success: boolean; error?: string; user?: User }> {
   try {
     const supabase = createClient()
-    
+
     // Update profile in database
     const { data, error } = await supabase
       .from('profiles')
@@ -255,18 +243,18 @@ export async function updateUserProfile(
       .eq('id', userId)
       .select()
       .single()
-    
+
     if (error) {
       return { success: false, error: error.message }
     }
-    
+
     // Get updated user
     const currentUser = await getCurrentUserAsync()
-    
+
     if (currentUser && currentUser.id === userId) {
       localStorage.setItem("lab68_session", JSON.stringify(currentUser))
     }
-    
+
     return { success: true, user: currentUser || undefined }
   } catch (error: any) {
     return { success: false, error: error.message || 'Update failed' }
@@ -275,25 +263,25 @@ export async function updateUserProfile(
 
 export async function checkRememberMe(): Promise<User | null> {
   if (typeof window === "undefined") return null
-  
+
   try {
     const remember = localStorage.getItem("lab68_remember")
     if (!remember) return null
-    
+
     const supabase = createClient()
     const { data: { user: authUser } } = await supabase.auth.getUser()
-    
+
     if (!authUser) return null
-    
+
     // Fetch user profile
     const { data: profile } = await supabase
       .from('profiles')
       .select('*')
       .eq('id', authUser.id)
       .single()
-    
+
     if (!profile) return null
-    
+
     const user: User = {
       id: profile.id,
       email: authUser.email || '',
@@ -305,7 +293,7 @@ export async function checkRememberMe(): Promise<User | null> {
       website: profile.website,
       avatar: profile.avatar
     }
-    
+
     // Restore session cache
     localStorage.setItem("lab68_session", JSON.stringify(user))
     return user