Migrate samples to lstk, away from awslocal and tflocal#17
Draft
peter-smith-phd wants to merge 3 commits into
Draft
Migrate samples to lstk, away from awslocal and tflocal#17peter-smith-phd wants to merge 3 commits into
peter-smith-phd wants to merge 3 commits into
Conversation
Standardize all samples on the lstk CLI for starting LocalStack and running Terraform, replacing the awslocal/tflocal wrappers. Modernizing the examples along the way was necessary to get them deploying and passing again: fix API Gateway deployment ordering, use $default stages for HTTP APIs, add missing stages/permissions, and bump deprecated runtimes and service versions. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Collapse the two root Makefile `lint` targets into one (terraform fmt), removing the "overriding commands for target lint" warning. The lint target now skips the sample-archive directory. Replace deprecated data.aws_region.current.id with .region in apigatewayv2-ws-request-authorizer to clear the Terraform deprecation warning. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
peter-smith-phd
force-pushed
the
dpx-503-update-terraform-samples
branch
from
0c98d04 to
9cd2e31
Compare
Reformat files flagged by `make lint` (whitespace/alignment only). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Standardize all samples on the
lstkCLI for starting LocalStack and running Terraform, replacing theawslocal/tflocalwrappers. Modernizing the examples was necessary to get them deploying and passing on CI again.Fixes applied while migrating
aws_api_gateway_deploymentnow depends on the integration responses, so the deployed snapshot includes them (was returningInternal server error/API_CONFIGURATION_ERROR):apigateway-kinesis-integration,apigateway-kinesis-lambda-integration,apigateway-step-functions-integration$defaultstage so the standardized run scripts (no stage prefix) resolve:apigatewayv2-lambda-proxy-integration,apigatewayv2-lambda-request-authorizer-1.0apigatewayv2-lambda-proxy,apigatewayv2-lambda-request-authorizer-2.0apigatewayv2-lambda-request-authorizer-2.0request_parametersmappings rejected by LocalStack:apigatewayv2-ws-sample,websocket-deploykafka_version3.2.0→3.6.0inmanaged-streaming-kafka-clustercluster_info.json(MSK test artifact) to.gitignoreTesting
Each affected sample was deployed against LocalStack and its
make test/ smoke test run to green; resources were destroyed after verification.🤖 Generated with Claude Code