Freeze when exiting a taglist window

[adah1972]

I am using the taglist plugin. I've found a strange issue: when I open a taglist window—with :TlistOpen—and then try closing the whole MacVim window without closing the taglist window separately with :TlistClose, MacVim freezes.

More investigation shows that this apparently innocent line in taglist.vim caused the freeze (commenting it out eliminates the problem):

let &columns= &columns - (g:Tlist_WinWidth + 1)

It looks like bug in MacVim. There is no such problem in, say, gVim for Windows.

I am currently using macvim stable 8.0-134 (bottled) from Homebrew.

[eirnym]

@adah1972 Does it still an issue?

[adah1972]

I can still reproduce this issue with the latest Homebrew build, version 8.1.1517 (156).

[eirnym]

Is it be reproducible with (Mac)Vim from terminal?

[adah1972]

No, not in a terminal.

One more important thing: I have just discovered that it happens in the GUI only when I check "Use Core Text Renderer". After unchecking it, the problem goes away.

[eirnym]

Thank you, it's a very valuable addition to investigate further.

[eirnym]

BTW, it's a quite strange, as I use NERDTree without a problem. Probably it's caused by using outdated features, as this plugin wasn't updated since ... 2013 and Vim changed quite a bit.

I'll investigate how to install it on plugin managers era and will play around

[eirnym]

Meanwhile you can play around with tagbar as it seems to be newer with about the same functionality

[adah1972]

Still, it is a strange thing that changing &columns about the time of an exit will cause a freeze. Even though taglist is old, what it does seems innocent to me…

Thanks for recommending tagbar. I'll take a look.

[adah1972]

I've just tried tagbar. It looks impressive, but it does not change the window width (as taglist does). So there is no way it can trigger a bug like this.

(If I turn off the window width change with let Tlist_Inc_Winwidth=0, taglist will not trigger this bug either.)

[eirnym]

Wow! Thank you for an additional discovery to narrow down the reason where bug is triggered!

[ychin]

If there is a way to freeze MacVim this definitely needs to be fixed. Tagging to the next milestone.

[eirnym]

Documentation in code says about this variable below.

    " Increase Vim window width to display vertically split taglist window.
    " For MS-Windows version of Vim running in a MS-DOS window, this must be
    " set to 0 otherwise the system may hang due to a Vim limitation.
    if !exists('Tlist_Inc_Winwidth')
        if (has('win16') || has('win95')) && !has('gui_running')
            let Tlist_Inc_Winwidth = 0
        else
            let Tlist_Inc_Winwidth = 1
        endif
    endif

@ychin This actually do the following:
let &columns= &columns - (g:Tlist_WinWidth + 1)

[eirnym]

I can't make it freeze with taglist 4.6 and MacVim 156.

[adah1972]

@eirnym Did you turn on "Use Core Text Renderer"? It is triggered only when the Core Text Renderer is used.