Skip to content

Commit 0b9583d

Browse files
authored
Merge pull request #39 from railsware/nitpick-updates
Nitpick SDK updates
2 parents 4d5554e + 4a313a4 commit 0b9583d

101 files changed

Lines changed: 1279 additions & 1229 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

README.md

Lines changed: 16 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -113,34 +113,34 @@ You can find the API reference [here](https://railsware.github.io/mailtrap-java/
113113

114114
### General API
115115

116-
- [List User & Invite account accesses](examples/java/io/mailtrap/examples/general/AccountAccess.java)
117-
- [Remove account access](examples/java/io/mailtrap/examples/general/Accounts.java)
118-
- [Permissions](examples/java/io/mailtrap/examples/general/Permissions.java)
119-
- [Current billing usage cycle](examples/java/io/mailtrap/examples/general/Billing.java)
116+
- [List User & Invite account accesses](examples/java/io/mailtrap/examples/general/AccountAccessExample.java)
117+
- [Remove account access](examples/java/io/mailtrap/examples/general/AccountsExample.java)
118+
- [Permissions](examples/java/io/mailtrap/examples/general/PermissionsExample.java)
119+
- [Current billing usage cycle](examples/java/io/mailtrap/examples/general/BillingExample.java)
120120

121121
### Sending API
122122

123-
- [Advanced](examples/java/io/mailtrap/examples/sending/Everything.java)
124-
- [Minimal](examples/java/io/mailtrap/examples/sending/Minimal.java)
125-
- [Error handling](examples/java/io/mailtrap/examples/sending/Errors.java)
126-
- [Send email using template](examples/java/io/mailtrap/examples/sending/Template.java)
123+
- [Advanced](examples/java/io/mailtrap/examples/sending/EverythingExample.java)
124+
- [Minimal](examples/java/io/mailtrap/examples/sending/MinimalExample.java)
125+
- [Error handling](examples/java/io/mailtrap/examples/sending/ErrorsExample.java)
126+
- [Send email using template](examples/java/io/mailtrap/examples/sending/TemplateExample.java)
127127

128128
### Email Testing API
129129

130-
- [Attachments](examples/java/io/mailtrap/examples/testing/Attachments.java)
131-
- [Inboxes](examples/java/io/mailtrap/examples/testing/Inboxes.java)
132-
- [Messages](examples/java/io/mailtrap/examples/testing/Messages.java)
133-
- [Projects](examples/java/io/mailtrap/examples/testing/Projects.java)
134-
- [Send mail using template](examples/java/io/mailtrap/examples/testing/Email.java)
130+
- [Attachments](examples/java/io/mailtrap/examples/testing/AttachmentsExample.java)
131+
- [Inboxes](examples/java/io/mailtrap/examples/testing/InboxesExample.java)
132+
- [Messages](examples/java/io/mailtrap/examples/testing/MessagesExample.java)
133+
- [Projects](examples/java/io/mailtrap/examples/testing/ProjectsExample.java)
134+
- [Send mail using template](examples/java/io/mailtrap/examples/testing/EmailExample.java)
135135

136136
### Bulk Sending API
137137

138-
- [Send mail](examples/java/io/mailtrap/examples/bulk/BulkSend.java)
138+
- [Send mail](examples/java/io/mailtrap/examples/bulk/BulkSendExample.java)
139139

140140
### Contacts API
141141

142-
- [Contacts](examples/java/io/mailtrap/examples/contacts/Contacts.java)
143-
- [Contact lists](examples/java/io/mailtrap/examples/contactlists/ContactLists.java)
142+
- [Contacts](examples/java/io/mailtrap/examples/contacts/ContactsExample.java)
143+
- [Contact lists](examples/java/io/mailtrap/examples/contactlists/ContactListsExample.java)
144144

145145
## Contributing
146146

examples/java/io/mailtrap/examples/bulk/Batch.java renamed to examples/java/io/mailtrap/examples/bulk/BatchExample.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010
import java.util.List;
1111
import java.util.Map;
1212

13-
public class Batch {
13+
public class BatchExample {
1414

1515
private static final String TOKEN = "<YOUR MAILTRAP TOKEN>";
1616
private static final String SENDER_EMAIL = "sender@domain.com";

examples/java/io/mailtrap/examples/bulk/BulkSend.java renamed to examples/java/io/mailtrap/examples/bulk/BulkSendExample.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77

88
import java.util.List;
99

10-
public class BulkSend {
10+
public class BulkSendExample {
1111

1212
private static final String TOKEN = "<YOUR MAILTRAP TOKEN>";
1313
private static final String SENDER_EMAIL = "sender@domain.com";

examples/java/io/mailtrap/examples/contactfields/ContactFields.java renamed to examples/java/io/mailtrap/examples/contactfields/ContactFieldsExample.java

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010
import java.util.List;
1111
import java.util.Map;
1212

13-
public class ContactFields {
13+
public class ContactFieldsExample {
1414

1515
private static final String TOKEN = "<YOUR MAILTRAP TOKEN>";
1616
private static final long ACCOUNT_ID = 1L;
@@ -22,22 +22,22 @@ public static void main(String[] args) {
2222

2323
final var client = MailtrapClientFactory.createMailtrapClient(config);
2424

25-
var createResponse = client.contactsApi().contactFields()
25+
final var createResponse = client.contactsApi().contactFields()
2626
.createContactField(ACCOUNT_ID, new CreateContactFieldRequest("Contact name", ContactFieldDataType.TEXT, "merge-tag"));
2727

2828
System.out.println(createResponse);
2929

30-
var updateResponse = client.contactsApi().contactFields()
30+
final var updateResponse = client.contactsApi().contactFields()
3131
.updateContactField(ACCOUNT_ID, createResponse.getId(), new UpdateContactFieldRequest("Updated name", "updated-merge-tag"));
3232

3333
System.out.println(updateResponse);
3434

35-
var allContactFields = client.contactsApi().contactFields()
35+
final var allContactFields = client.contactsApi().contactFields()
3636
.getAllContactFields(ACCOUNT_ID);
3737

3838
System.out.println(allContactFields);
3939

40-
var contactField = client.contactsApi().contactFields()
40+
final var contactField = client.contactsApi().contactFields()
4141
.getContactField(ACCOUNT_ID, createResponse.getId());
4242

4343
System.out.println(contactField);

examples/java/io/mailtrap/examples/contactimports/ContactImports.java renamed to examples/java/io/mailtrap/examples/contactimports/ContactImportsExample.java

Lines changed: 4 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -4,14 +4,11 @@
44
import io.mailtrap.factory.MailtrapClientFactory;
55
import io.mailtrap.model.request.contactimports.Contact;
66
import io.mailtrap.model.request.contactimports.ImportContactsRequest;
7-
import io.mailtrap.model.request.contacts.UpdateContact;
8-
import io.mailtrap.model.request.contacts.UpdateContactRequest;
97

10-
import java.util.Collections;
118
import java.util.List;
129
import java.util.Map;
1310

14-
public class ContactImports {
11+
public class ContactImportsExample {
1512

1613
private static final String TOKEN = "<YOUR MAILTRAP TOKEN>";
1714
private static final long ACCOUNT_ID = 1L;
@@ -26,15 +23,15 @@ public static void main(String[] args) {
2623

2724
final var client = MailtrapClientFactory.createMailtrapClient(config);
2825

29-
var importRequest = new ImportContactsRequest(
26+
final var importRequest = new ImportContactsRequest(
3027
List.of(new Contact(EMAIL, Map.of("first_name", "Nick"), List.of(LIST_1_ID), List.of(LIST_2_ID))));
3128

32-
var createResponse = client.contactsApi().contactImports()
29+
final var createResponse = client.contactsApi().contactImports()
3330
.importContacts(ACCOUNT_ID, importRequest);
3431

3532
System.out.println(createResponse);
3633

37-
var contactImportResponse = client.contactsApi().contactImports()
34+
final var contactImportResponse = client.contactsApi().contactImports()
3835
.getContactImport(ACCOUNT_ID, createResponse.getId());
3936

4037
System.out.println(contactImportResponse);

examples/java/io/mailtrap/examples/contactlists/ContactLists.java renamed to examples/java/io/mailtrap/examples/contactlists/ContactListsExample.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
import io.mailtrap.config.MailtrapConfig;
44
import io.mailtrap.factory.MailtrapClientFactory;
55

6-
public class ContactLists {
6+
public class ContactListsExample {
77

88
private static final String TOKEN = "<YOUR MAILTRAP TOKEN>";
99
private static final long ACCOUNT_ID = 1L;
@@ -15,7 +15,7 @@ public static void main(String[] args) {
1515

1616
final var client = MailtrapClientFactory.createMailtrapClient(config);
1717

18-
var contacts = client.contactsApi().contactLists().findAll(ACCOUNT_ID);
18+
final var contacts = client.contactsApi().contactLists().findAll(ACCOUNT_ID);
1919

2020
System.out.println(contacts);
2121
}

examples/java/io/mailtrap/examples/contacts/Contacts.java renamed to examples/java/io/mailtrap/examples/contacts/ContactsExample.java

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@
1111
import java.util.List;
1212
import java.util.Map;
1313

14-
public class Contacts {
14+
public class ContactsExample {
1515

1616
private static final String TOKEN = "<YOUR MAILTRAP TOKEN>";
1717
private static final long ACCOUNT_ID = 1L;
@@ -27,19 +27,19 @@ public static void main(String[] args) {
2727

2828
final var client = MailtrapClientFactory.createMailtrapClient(config);
2929

30-
var createRequest = new CreateContactRequest(
30+
final var createRequest = new CreateContactRequest(
3131
new CreateContact(EMAIL, Map.of("first_name", "Nick"), List.of(LIST_1_ID, LIST_2_ID)));
3232

33-
var createResponse = client.contactsApi().contacts()
33+
final var createResponse = client.contactsApi().contacts()
3434
.createContact(ACCOUNT_ID, createRequest);
3535

3636
System.out.println(createResponse);
3737

38-
var updateRequest = new UpdateContactRequest(
38+
final var updateRequest = new UpdateContactRequest(
3939
new UpdateContact(EMAIL, Map.of("first_name", "Nick"), List.of(LIST_1_ID, LIST_2_ID),
4040
Collections.emptyList(), UNSUBSCRIBED));
4141

42-
var updateResponse = client.contactsApi().contacts()
42+
final var updateResponse = client.contactsApi().contacts()
4343
.updateContact(ACCOUNT_ID, EMAIL, updateRequest);
4444

4545
System.out.println(updateResponse);

examples/java/io/mailtrap/examples/emailtemplates/EmailTemplates.java renamed to examples/java/io/mailtrap/examples/emailtemplates/EmailTemplatesExample.java

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99

1010
import java.util.List;
1111

12-
public class EmailTemplates {
12+
public class EmailTemplatesExample {
1313

1414
private static final String TOKEN = "<YOUR MAILTRAP TOKEN>";
1515
private static final long ACCOUNT_ID = 1L;
@@ -25,8 +25,6 @@ public static void main(String[] args) {
2525
.token(TOKEN)
2626
.build();
2727

28-
new EmailTemplate(EMAIL_TEMPLATE_NAME, EMAIL_TEMPLATE_CATEGORY, EMAIL_TEMPLATE_SUBJECT, EMAIL_TEMPLATE_BODY_TEXT, EMAIL_TEMPLATE_BODY_HTML);
29-
3028
final var client = MailtrapClientFactory.createMailtrapClient(config);
3129

3230
final var createRequest = new CreateEmailTemplateRequest(

examples/java/io/mailtrap/examples/general/AccountAccess.java renamed to examples/java/io/mailtrap/examples/general/AccountAccessExample.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66

77
import java.util.List;
88

9-
public class AccountAccess {
9+
public class AccountAccessExample {
1010

1111
private static final String TOKEN = "<YOUR MAILTRAP TOKEN>";
1212
private static final long ACCOUNT_ID = 1L;
@@ -19,10 +19,10 @@ public static void main(String[] args) {
1919

2020
final var client = MailtrapClientFactory.createMailtrapClient(config);
2121

22-
var queryParams = new ListAccountAccessQueryParams();
22+
final var queryParams = new ListAccountAccessQueryParams();
2323
queryParams.setInboxIds(List.of(INBOX_ID));
2424

25-
var responses = client.generalApi().accountAccesses().listUserAndInviteAccountAccesses(ACCOUNT_ID, queryParams);
25+
final var responses = client.generalApi().accountAccesses().listUserAndInviteAccountAccesses(ACCOUNT_ID, queryParams);
2626

2727
System.out.println(responses);
2828

examples/java/io/mailtrap/examples/general/Accounts.java renamed to examples/java/io/mailtrap/examples/general/AccountsExample.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
import io.mailtrap.config.MailtrapConfig;
44
import io.mailtrap.factory.MailtrapClientFactory;
55

6-
public class Accounts {
6+
public class AccountsExample {
77

88
private static final String TOKEN = "<YOUR MAILTRAP TOKEN>";
99

0 commit comments

Comments
 (0)