Skip to content

Add prop for fixed selection dot and fadeout starting point.#97

Open
gabimoncha wants to merge 7 commits into
margelo:mainfrom
gabimoncha:feat/fix-dot-position
Open

Add prop for fixed selection dot and fadeout starting point.#97
gabimoncha wants to merge 7 commits into
margelo:mainfrom
gabimoncha:feat/fix-dot-position

Conversation

@gabimoncha

Copy link
Copy Markdown
  1. Update C++ standard to c++17
  2. Update Cocoapods version to latest stable
  3. Add selectionDotValueX prop for a fixed position of the selection dot
  4. Add fadeouValueX prop for a fixed starting point for the fade out
Simulator.Screen.Recording.-.iPhone.15.Pro.Max.-.2024-02-02.at.14.25.24.mp4

@gabimoncha

gabimoncha commented Mar 12, 2024

Copy link
Copy Markdown
Author

@mrousavy would you be interested in merging this enhancement?

@mrousavy

Copy link
Copy Markdown
Member

Hey - yep, I am! I'm just waiting for @chrispader to get back from vacation, as he's the main responsible maintainer for RN Graph nowadays :)

@mrousavy

Copy link
Copy Markdown
Member

thanks for your PR on this!!

@gabimoncha

Copy link
Copy Markdown
Author

Cool! Thanks for letting me know. Will continue any further discussion and ideas with him

@theblondealex

theblondealex commented Mar 27, 2024

Copy link
Copy Markdown

I have been using this, as well as @gabimoncha 's forked CustomIndicator component PR would be good to get these merged

The only ammendment would be the logic in the AnimatedLineGraph.tsx circa line 535, if an indicator component is used then the indicator pulsing is disabled it would be good to have both, just duplicating the indicatorPulsing into your ternary operator conditional works well enough, see below. I can submit a PR if needed gabi :)

 (IndicatorComponent != null ? (
                  <Group>
                    {indicatorPulsating && (
                       <Circle
                         cx={indicatorX}
                         cy={indicatorY}
                         r={indicatorPulseRadius}
                         opacity={indicatorPulseOpacity}
                         color={indicatorPulseColor}
                         style="fill"
                       />
                     )}
                  <IndicatorComponent
                    isActive={isActive}
                    color={color}
                    circleX={indicatorX}
                    circleY={indicatorY}
                  />
                  </Group>
 

@chrispader

Copy link
Copy Markdown
Member

I'm gonna try to look into this issue (and others) on the weekend or next week. Unfortunately i'm fully booked with work right now...

@gabimoncha

Copy link
Copy Markdown
Author

@chrispader let me know if you need any help to streamline this :D

@theblondealex

Copy link
Copy Markdown

any chance we can get these merged? @chrispader as well as @gabimoncha's other forked repo containing the custom indicatordot?

@gabimoncha

Copy link
Copy Markdown
Author

@theblondealex @chrispader - I have another one where I pass the index of the data point to onPointSelected in case you want to use it for additional visualisation in a larger dataset object 😅

@chrispader

Copy link
Copy Markdown
Member

i'm gonna look into this tmrw! sorry for the delay...

@theblondealex @chrispader - I have another one where I pass the index of the data point to onPointSelected in case you want to use it for additional visualisation in a larger dataset object 😅

@gabimoncha could you provide me a link to that?

@gabimoncha

Copy link
Copy Markdown
Author

@chrispader - here
Each branch is a different feature for the app. The ones I told you on discord too

  1. Custom starting point for selection dot. this PR
  2. Custom Indicator - same props as SelectionDot.
  3. Passing the index in onPointSelected, if needed to link data point to a bigger data set

@gabimoncha

gabimoncha commented Apr 30, 2024

Copy link
Copy Markdown
Author

@chrispader any updates on this PR? would love to push the other solutions too

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants