diffHtml may be synchronous

[xmedeko]

When running diff like const diff = await htmlDiffer.diffHtml(oldHtml, newHtml); where both params are strings, then Promise.all in

html-differ/lib/utils/modify.js

Lines 102 to 104 in 783452a

	parser.on('end', async function() {
	const values = await Promise.all(modifiedValues);
	resolve(values.join(''));

is not necessary, because modifiedValues is just an array of string, i.e. it may be simplified to resolve(modifiedValues.join(''));.

Furthermore, whole modify may by synchronous by omitting that parser.on('end', ...) handler and just returning modifiedValues.join('') at the end of the function. So, even HtmlDiffer.diffHtml may be synchronous. Is there any use case or reason why it's async? I can make a PR to simplify it and make it synchronous.

[UziTech]

I think we had to make it async to be able to handle the async parsing of parse5-sax-parser. But if you think you can make it synchronous I think that would be great.

[xmedeko]

@UziTech see #527

[github-actions]

🎉 This issue has been resolved in version 5.0.4 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀