refactor: make V2 LoadExtension consistent with other versions

Copilot · baywet · Copilot · commit 12f649959fe7 · 2025-12-22T19:10:01.000Z
Moved the return statement for JsonNodeExtension outside the catch block to match the pattern used in V3, V31, and V32 deserializers.

Co-authored-by: baywet &lt;7905502+baywet@users.noreply.github.com&gt;
diff --git a/src/Microsoft.OpenApi/Reader/V2/OpenApiV2Deserializer.cs b/src/Microsoft.OpenApi/Reader/V2/OpenApiV2Deserializer.cs
@@ -87,13 +87,10 @@ private static IOpenApiExtension LoadExtension(string name, ParseNode node)
                 {
                     ex.Pointer = node.Context.GetLocation();
                     node.Context.Diagnostic.Errors.Add(new(ex));
-                    return new JsonNodeExtension(node.CreateAny());
                 }
             }
-            else
-            {
-                return new JsonNodeExtension(node.CreateAny());
-            }
+
+            return new JsonNodeExtension(node.CreateAny());
         }
 
         private static string? LoadString(ParseNode node)

Original file line number	Diff line number	Diff line change
`@@ -87,13 +87,10 @@ private static IOpenApiExtension LoadExtension(string name, ParseNode node)`
`87`	`87`	`{`
`88`	`88`	`ex.Pointer = node.Context.GetLocation();`
`89`	`89`	`node.Context.Diagnostic.Errors.Add(new(ex));`
`90`		`- return new JsonNodeExtension(node.CreateAny());`
`91`	`90`	`}`
`92`	`91`	`}`
`93`		`- else`
`94`		`- {`
`95`		`- return new JsonNodeExtension(node.CreateAny());`
`96`		`- }`
	`92`	`+`
	`93`	`+ return new JsonNodeExtension(node.CreateAny());`
`97`	`94`	`}`
`98`	`95`
`99`	`96`	`private static string? LoadString(ParseNode node)`