Factor out cache to be shared and not shared. Projects still are not sharing caches

TODO:
- Actual sharing between projects
- Handling global cache passes between projects
- Effective typeRoots differ and hence type ref resolution differs

Author: sheetalkamat

src/compiler/_namespaces/ts.ts

@@ -65,6 +65,7 @@ export * from "../builderStatePublic.js";
 export * from "../builderState.js";
 export * from "../builder.js";
 export * from "../builderPublic.js";
+export * from "../sharedResolutionCache.js";
 export * from "../resolutionCache.js";
 export * from "../watch.js";
 export * from "../watchPublic.js";

src/compiler/moduleNameResolver.ts

@@ -636,8 +636,7 @@ export function resolveTypeReferenceDirective(typeReferenceDirectiveName: string
         resolutionDiagnostics: initializeResolutionField(diagnostics),
     };
     if (containingDirectory) {
-        setPerDirectoryAndNonRelativeNameCacheResult(
-            cache,
+        cache?.setPerDirectoryAndNonRelativeNameCacheResult(
             typeReferenceDirectiveName,
             resolutionMode,
             containingDirectory,
@@ -1363,6 +1362,14 @@ function createNonRelativeNameResolutionCache<T>(
 export interface ModuleOrTypeReferenceResolutionCache<T> extends PerDirectoryResolutionCache<T>, NonRelativeNameResolutionCache<T>, PackageJsonInfoCache {
     getPackageJsonInfoCache(): PackageJsonInfoCache;
     compact(availableOptions?: Set<CompilerOptions>, skipOptionsToRedirectsKeyCleanup?: boolean): void;
+    setPerDirectoryAndNonRelativeNameCacheResult(
+        name: string,
+        mode: ResolutionMode,
+        directoryName: string,
+        redirectedReference: ResolvedProjectReference | undefined,
+        result: T,
+    ): void;
+    options: () => CompilerOptions;
     optionsToRedirectsKey: Map<CompilerOptions, RedirectsCacheKey>;
     print(): void;
 }
@@ -1394,27 +1401,31 @@ function createModuleOrTypeReferenceResolutionCache<T>(
     );
     packageJsonInfoCache ??= createPackageJsonInfoCache(currentDirectory, getCanonicalFileName);
 
-    return {
+    const cache: ModuleOrTypeReferenceResolutionCache<T> = {
         ...packageJsonInfoCache,
         ...perDirectoryResolutionCache,
         ...nonRelativeNameResolutionCache,
         clear,
         update,
         compact,
+        setPerDirectoryAndNonRelativeNameCacheResult,
+        options: () => options!,
         getPackageJsonInfoCache: () => packageJsonInfoCache,
         optionsToRedirectsKey,
         print,
     };
+    return cache;
 
     function clear() {
         perDirectoryResolutionCache.clear();
         nonRelativeNameResolutionCache.clear();
         packageJsonInfoCache!.clear();
     }
 
-    function update(options: CompilerOptions) {
-        perDirectoryResolutionCache.update(options);
-        nonRelativeNameResolutionCache.update(options);
+    function update(updatedOptions: CompilerOptions) {
+        options = updatedOptions;
+        perDirectoryResolutionCache.update(updatedOptions);
+        nonRelativeNameResolutionCache.update(updatedOptions);
     }
 
     function compact(availableOptions = new Set(optionsToRedirectsKey!.keys()), skipOptionsToRedirectsKeyCleanup?: boolean) {
@@ -1429,6 +1440,21 @@ function createModuleOrTypeReferenceResolutionCache<T>(
         }
     }
 
+    function setPerDirectoryAndNonRelativeNameCacheResult(
+        name: string,
+        mode: ResolutionMode,
+        directoryName: string,
+        redirectedReference: ResolvedProjectReference | undefined,
+        result: T,
+    ): void {
+        if (cache.isReadonly) return;
+        cache.getOrCreateCacheForDirectory(directoryName, redirectedReference).set(name, mode, result);
+        if (!isExternalModuleNameRelative(name)) {
+            // put result in per-module name cache
+            cache.getOrCreateCacheForNonRelativeName(name, mode, redirectedReference).set(directoryName, result);
+        }
+    }
+
     function print() {
         console.log(`directoryToModuleNameMap::`);
         perDirectoryResolutionCache.directoryToModuleNameMap.forEach((moduleNameMap, directoryPath, redirectsCacheKey) => {
@@ -1451,24 +1477,6 @@ function createModuleOrTypeReferenceResolutionCache<T>(
     }
 }
 
-/** @internal */
-export function setPerDirectoryAndNonRelativeNameCacheResult<T>(
-    cache: ModuleOrTypeReferenceResolutionCache<T> | undefined,
-    name: string,
-    mode: ResolutionMode,
-    directoryName: string,
-    redirectedReference: ResolvedProjectReference | undefined,
-    result: T,
-): void {
-    if (cache && !cache.isReadonly) {
-        cache.getOrCreateCacheForDirectory(directoryName, redirectedReference).set(name, mode, result);
-        if (!isExternalModuleNameRelative(name)) {
-            // put result in per-module name cache
-            cache.getOrCreateCacheForNonRelativeName(name, mode, redirectedReference).set(directoryName, result);
-        }
-    }
-}
-
 export function createModuleResolutionCache(
     currentDirectory: string,
     getCanonicalFileName: (s: string) => string,
@@ -1544,8 +1552,8 @@ export function createTypeReferenceDirectiveResolutionCache(
 }
 
 /** @internal */
-export function getOptionsForLibraryResolution(options: CompilerOptions): CompilerOptions {
-    return { moduleResolution: ModuleResolutionKind.Node10, traceResolution: options.traceResolution };
+export function getOptionsForLibraryResolution(options: CompilerOptions | undefined): CompilerOptions {
+    return { moduleResolution: ModuleResolutionKind.Node10, traceResolution: options?.traceResolution };
 }
 
 /** @internal */
@@ -1611,8 +1619,7 @@ export function resolveModuleName(moduleName: string, containingFile: string, co
                 return Debug.fail(`Unexpected moduleResolution: ${moduleResolution}`);
         }
 
-        setPerDirectoryAndNonRelativeNameCacheResult(
-            cache,
+        cache?.setPerDirectoryAndNonRelativeNameCacheResult(
             moduleName,
             resolutionMode,
             containingDirectory,