From faa49e6554d86a6f64e6f0b907654add13c4c508 Mon Sep 17 00:00:00 2001 From: Tyrie Vella Date: Mon, 1 Jun 2026 16:07:57 -0700 Subject: [PATCH] Add diagnostic logging to GetFileStreamException catch block The GetFileStreamException catch in GetFileStreamHandlerAsyncHandler silently completed the ProjFS command without logging requestMetadata (SHA, virtual path). Other catch blocks in the same handler all log this metadata. Add a RelatedWarning with the HResult value for diagnostic visibility while keeping the severity appropriate for expected/benign HResult.Handle results. Assisted-by: Claude Opus 4.6 Signed-off-by: Tyrie Vella --- GVFS/GVFS.Platform.Windows/WindowsFileSystemVirtualizer.cs | 3 +++ 1 file changed, 3 insertions(+) diff --git a/GVFS/GVFS.Platform.Windows/WindowsFileSystemVirtualizer.cs b/GVFS/GVFS.Platform.Windows/WindowsFileSystemVirtualizer.cs index 8977bfa88..f39128e7a 100644 --- a/GVFS/GVFS.Platform.Windows/WindowsFileSystemVirtualizer.cs +++ b/GVFS/GVFS.Platform.Windows/WindowsFileSystemVirtualizer.cs @@ -981,6 +981,9 @@ private void GetFileStreamHandlerAsyncHandler( } catch (GetFileStreamException e) { + requestMetadata.Add(TracingConstants.MessageKey.InfoMessage, $"{nameof(this.GetFileStreamHandlerAsyncHandler)}: GetFileStreamException HResult 0x{e.HResult:X8}"); + this.Context.Tracer.RelatedWarning(requestMetadata, nameof(this.GetFileStreamHandlerAsyncHandler) + "_GetFileStreamException"); + this.TryCompleteCommand(commandId, (HResult)e.HResult); return; }