Check tool_path folder permission before running os.chmod(tool_path, 0o755)

[IvanJosipovic]

Hello,

I’m trying to run this tool as a restricted user. However, it always calls chmod 755 on tool_path even if the permissions are already correct. Unfortunately, my user account doesn’t have permission to change file modes and the code fails.

artifacts-keyring/src/artifacts_keyring/plugin.py

Line 50 in e36c1b4

os.chmod(tool_path, 0o755)

Can we please put in a check to see if the permissions are already set prior to running os.chmod(tool_path, 0o755)?

[greatvovan]

Arguably, execution permissions must be configured at install time (setup.py) and not at run time. This way the user account running chmod() will be the owner and the change should succeed. Also, running account is not always the same as installing account, so chmod(0o777) will be probably preferred.