Commit 9b7bace
authored
Adding L0 tests for Legacy NodeHandler logic | Adding 2 Knobs for feature flag & EOL toggle status value (#5421)
* Initial commit | node handler strategies | orchestrator to get selected node | L0 tests for node handlers
* Adding collection definition for unning all node handling tests in sequence | Preventing leakage of test specific environment settings for knobs between node handler tests (both new and legacy)
* Adding selectedNode field in UnifiedNodeContext | Removing duplicate checks from handlers | Adding string tempalates for errors and warning and removing hard-coded erros and warning from code
* Adding equivalence and diverging test for legacy and new approach | Simplyfying unit test scenarios to avoid using redundant code | Update NodeHandlerTestBase to reflect the simplified test scenario usage for unning tests
* Node Handler integrtion fix for custom node (moved legacy custom node check inside getnodeLocation function) | Added custom node path L0 tests | Updated test base code to integrate custom node tests
* Merged custom node scnario tests with all other test specs
* Code cleaning
* Test scenarios updates
* Minor fixes
* Adding CustomNodeHandlerData handler
* minor fixes
* L0 unit tests for node handler with all scenarios for node handlers
* minor fix
* Code cleaning
* Updating knob name to be consistent with server side updates.
* refactor: Replace 'unified' terminology with 'strategy' in Node.js handler tests
- Replace useUnifiedStrategy → useStrategy parameter
- Replace unifiedExpectedNode → strategyExpectedNode property
- Replace unifiedExpectSuccess → strategyExpectSuccess property
- Replace unifiedExpectedError → strategyExpectedError property
- Replace shouldMatchBetweenModes → shouldMatchBetweenLegacyAndStrategy property
- Update environment variable AGENT_USE_UNIFIED_NODE_STRATEGY → AGENT_USE_NODE_STRATEGY
- Update test descriptions to use "strategy-based" instead of "unified"
- Update TestScenario class properties and constructor parameters
This improves code clarity by using terminology that directly relates to the
strategy pattern implementation rather than the generic term "unified".
* Removed strategyExpectSuccess, legacyExpectSuccess and ExpectSuccess fields | Using Trt - Catch intest rnner code instead of this to reduce complexity | updated agnet knob text || Updated knob description to be more meaningful1 parent 7f0507d commit 9b7bace
File tree
6 files changed
+1154
-0
lines changed- src
- Agent.Sdk/Knob
- Test/L0
6 files changed
+1154
-0
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
568 | 568 | | |
569 | 569 | | |
570 | 570 | | |
| 571 | + | |
| 572 | + | |
| 573 | + | |
| 574 | + | |
| 575 | + | |
| 576 | + | |
| 577 | + | |
571 | 578 | | |
572 | 579 | | |
573 | 580 | | |
| |||
929 | 936 | | |
930 | 937 | | |
931 | 938 | | |
| 939 | + | |
| 940 | + | |
| 941 | + | |
| 942 | + | |
| 943 | + | |
| 944 | + | |
| 945 | + | |
932 | 946 | | |
933 | 947 | | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
0 commit comments