Store timing in metadata (#282408)

Author: roblourens

src/vs/workbench/contrib/chat/browser/actions/chatActions.ts

@@ -766,6 +766,7 @@ export function registerChatActions() {
 											title: session.label,
 											isActive: false,
 											lastMessageDate: 0,
+											timing: { startTime: 0 },
 											lastResponseState: ResponseModelState.Complete
 										},
 										buttons,

src/vs/workbench/contrib/chat/browser/agentSessions/localAgentSessionsProvider.ts

@@ -124,22 +124,12 @@ export class LocalAgentsSessionsProvider extends Disposable implements IChatSess
 		const model = this.chatService.getSession(chat.sessionResource);
 
 		let description: string | undefined;
-		let startTime: number;
-		let endTime: number | undefined;
 		if (model) {
 			if (!model.hasRequests) {
 				return undefined; // ignore sessions without requests
 			}
 
-			const lastResponse = model.getRequests().at(-1)?.response;
 			description = this.chatSessionsService.getInProgressSessionDescription(model);
-
-			startTime = model.timestamp;
-			if (lastResponse) {
-				endTime = lastResponse.completedAt ?? lastResponse.timestamp;
-			}
-		} else {
-			startTime = chat.lastMessageDate;
 		}
 
 		return {
@@ -151,10 +141,7 @@ export class LocalAgentsSessionsProvider extends Disposable implements IChatSess
 				this.modelToStatus(model) :
 				chatResponseStateToSessionStatus(chat.lastResponseState),
 			iconPath: Codicon.chatSparkle,
-			timing: {
-				startTime,
-				endTime
-			},
+			timing: chat.timing,
 			changes: chat.stats ? {
 				insertions: chat.stats.added,
 				deletions: chat.stats.removed,

src/vs/workbench/contrib/chat/common/chatModel.ts

@@ -32,7 +32,7 @@ import { migrateLegacyTerminalToolSpecificData } from './chat.js';
 import { IChatAgentCommand, IChatAgentData, IChatAgentResult, IChatAgentService, UserSelectedTools, reviveSerializedAgent } from './chatAgents.js';
 import { IChatEditingService, IChatEditingSession, ModifiedFileEntryState, editEntriesToMultiDiffData } from './chatEditingService.js';
 import { ChatRequestTextPart, IParsedChatRequest, reviveParsedChatRequest } from './chatParserTypes.js';
-import { ChatAgentVoteDirection, ChatAgentVoteDownReason, ChatResponseClearToPreviousToolInvocationReason, ElicitationState, IChatAgentMarkdownContentWithVulnerability, IChatClearToPreviousToolInvocation, IChatCodeCitation, IChatCommandButton, IChatConfirmation, IChatContentInlineReference, IChatContentReference, IChatEditingSessionAction, IChatElicitationRequest, IChatElicitationRequestSerialized, IChatExtensionsContent, IChatFollowup, IChatLocationData, IChatMarkdownContent, IChatMcpServersStarting, IChatModelReference, IChatMultiDiffData, IChatMultiDiffDataSerialized, IChatNotebookEdit, IChatPrepareToolInvocationPart, IChatProgress, IChatProgressMessage, IChatPullRequestContent, IChatResponseCodeblockUriPart, IChatResponseProgressFileTreeData, IChatService, IChatSessionContext, IChatTask, IChatTaskSerialized, IChatTextEdit, IChatThinkingPart, IChatToolInvocation, IChatToolInvocationSerialized, IChatTreeData, IChatUndoStop, IChatUsedContext, IChatWarningMessage, ResponseModelState, isIUsedContext } from './chatService.js';
+import { ChatAgentVoteDirection, ChatAgentVoteDownReason, ChatResponseClearToPreviousToolInvocationReason, ElicitationState, IChatAgentMarkdownContentWithVulnerability, IChatClearToPreviousToolInvocation, IChatCodeCitation, IChatCommandButton, IChatConfirmation, IChatContentInlineReference, IChatContentReference, IChatEditingSessionAction, IChatElicitationRequest, IChatElicitationRequestSerialized, IChatExtensionsContent, IChatFollowup, IChatLocationData, IChatMarkdownContent, IChatMcpServersStarting, IChatModelReference, IChatMultiDiffData, IChatMultiDiffDataSerialized, IChatNotebookEdit, IChatPrepareToolInvocationPart, IChatProgress, IChatProgressMessage, IChatPullRequestContent, IChatResponseCodeblockUriPart, IChatResponseProgressFileTreeData, IChatService, IChatSessionContext, IChatSessionTiming, IChatTask, IChatTaskSerialized, IChatTextEdit, IChatThinkingPart, IChatToolInvocation, IChatToolInvocationSerialized, IChatTreeData, IChatUndoStop, IChatUsedContext, IChatWarningMessage, ResponseModelState, isIUsedContext } from './chatService.js';
 import { LocalChatSessionUri } from './chatUri.js';
 import { ChatRequestToolReferenceEntry, IChatRequestVariableEntry } from './chatVariableEntries.js';
 import { ChatAgentLocation, ChatModeKind } from './constants.js';
@@ -1170,6 +1170,7 @@ export interface IChatModel extends IDisposable {
 	readonly sessionId: string;
 	/** Milliseconds timestamp this chat model was created. */
 	readonly timestamp: number;
+	readonly timing: IChatSessionTiming;
 	readonly sessionResource: URI;
 	readonly initialLocation: ChatAgentLocation;
 	readonly title: string;
@@ -1638,6 +1639,14 @@ export class ChatModel extends Disposable implements IChatModel {
 		return this._timestamp;
 	}
 
+	get timing(): IChatSessionTiming {
+		const lastResponse = this._requests.at(-1)?.response;
+		return {
+			startTime: this._timestamp,
+			endTime: lastResponse?.completedAt ?? lastResponse?.timestamp
+		};
+	}
+
 	private _lastMessageDate: number;
 	get lastMessageDate(): number {
 		return this._lastMessageDate;

src/vs/workbench/contrib/chat/common/chatService.ts

@@ -923,10 +923,16 @@ export const enum ResponseModelState {
 	Failed
 }
 
+export interface IChatSessionTiming {
+	startTime: number;
+	endTime?: number;
+}
+
 export interface IChatDetail {
 	sessionResource: URI;
 	title: string;
 	lastMessageDate: number;
+	timing: IChatSessionTiming;
 	isActive: boolean;
 	stats?: IChatSessionStats;
 	lastResponseState: ResponseModelState;

src/vs/workbench/contrib/chat/common/chatServiceImpl.ts

@@ -399,6 +399,7 @@ export class ChatService extends Disposable implements IChatService {
 					sessionResource: session.sessionResource,
 					title,
 					lastMessageDate: session.lastMessageDate,
+					timing: session.timing,
 					isActive: true,
 					stats: await awaitStatsForSession(session),
 					lastResponseState: session.lastRequest?.response?.state ?? ResponseModelState.Pending,
@@ -419,6 +420,8 @@ export class ChatService extends Disposable implements IChatService {
 				return ({
 					...entry,
 					sessionResource,
+					// TODO@roblourens- missing for old data- normalize inside the store
+					timing: entry.timing ?? { startTime: entry.lastMessageDate },
 					isActive: this._sessionModels.has(sessionResource),
 					// TODO@roblourens- missing for old data- normalize inside the store
 					lastResponseState: entry.lastResponseState ?? ResponseModelState.Complete,
@@ -433,6 +436,8 @@ export class ChatService extends Disposable implements IChatService {
 			return {
 				...metadata,
 				sessionResource,
+				// TODO@roblourens- missing for old data- normalize inside the store
+				timing: metadata.timing ?? { startTime: metadata.lastMessageDate },
 				isActive: this._sessionModels.has(sessionResource),
 				// TODO@roblourens- missing for old data- normalize inside the store
 				lastResponseState: metadata.lastResponseState ?? ResponseModelState.Complete,

src/vs/workbench/contrib/chat/common/chatSessionStore.ts

@@ -23,7 +23,7 @@ import { ILifecycleService } from '../../../services/lifecycle/common/lifecycle.
 import { awaitStatsForSession } from './chat.js';
 import { ModifiedFileEntryState } from './chatEditingService.js';
 import { ChatModel, IChatModelInputState, ISerializableChatData, ISerializableChatDataIn, ISerializableChatsData, normalizeSerializableChatData } from './chatModel.js';
-import { IChatSessionStats, ResponseModelState } from './chatService.js';
+import { IChatSessionStats, ResponseModelState, IChatSessionTiming } from './chatService.js';
 import { LocalChatSessionUri } from './chatUri.js';
 import { ChatAgentLocation } from './constants.js';
 
@@ -430,6 +430,7 @@ export interface IChatSessionEntryMetadata {
 	sessionId: string;
 	title: string;
 	lastMessageDate: number;
+	timing?: IChatSessionTiming;
 	initialLocation?: ChatAgentLocation;
 	hasPendingEdits?: boolean;
 	stats?: IChatSessionStats;
@@ -498,10 +499,19 @@ async function getSessionMetadata(session: ChatModel | ISerializableChatData): P
 		stats = await awaitStatsForSession(session);
 	}
 
+	const timing = session instanceof ChatModel ?
+		session.timing :
+		// session is only ISerializableChatData in the old pre-fs storage data migration scenario
+		{
+			startTime: session.creationDate,
+			endTime: session.lastMessageDate
+		};
+
 	return {
 		sessionId: session.sessionId,
 		title: title || localize('newChat', "New Chat"),
 		lastMessageDate: session.lastMessageDate,
+		timing,
 		initialLocation: session.initialLocation,
 		hasPendingEdits: session instanceof ChatModel ? (session.editingSession?.entries.get().some(e => e.state.get() === ModifiedFileEntryState.Modified)) : false,
 		isEmpty: session instanceof ChatModel ? session.getRequests().length === 0 : session.requests.length === 0,

src/vs/workbench/contrib/chat/test/browser/localAgentSessionsProvider.test.ts

@@ -322,7 +322,8 @@ suite('LocalAgentsSessionsProvider', () => {
 				title: 'Test Session',
 				lastMessageDate: Date.now(),
 				isActive: true,
-				lastResponseState: ResponseModelState.Complete
+				lastResponseState: ResponseModelState.Complete,
+				timing: { startTime: 0, endTime: 1 }
 			}]);
 
 			const sessions = await provider.provideChatSessionItems(CancellationToken.None);
@@ -344,7 +345,8 @@ suite('LocalAgentsSessionsProvider', () => {
 				title: 'History Session',
 				lastMessageDate: Date.now() - 10000,
 				isActive: false,
-				lastResponseState: ResponseModelState.Complete
+				lastResponseState: ResponseModelState.Complete,
+				timing: { startTime: 0, endTime: 1 }
 			}]);
 
 			const sessions = await provider.provideChatSessionItems(CancellationToken.None);
@@ -369,14 +371,16 @@ suite('LocalAgentsSessionsProvider', () => {
 				title: 'Live Session',
 				lastMessageDate: Date.now(),
 				isActive: true,
-				lastResponseState: ResponseModelState.Complete
+				lastResponseState: ResponseModelState.Complete,
+				timing: { startTime: 0, endTime: 1 }
 			}]);
 			mockChatService.setHistorySessionItems([{
 				sessionResource,
 				title: 'History Session',
 				lastMessageDate: Date.now() - 10000,
 				isActive: false,
-				lastResponseState: ResponseModelState.Complete
+				lastResponseState: ResponseModelState.Complete,
+				timing: { startTime: 0, endTime: 1 }
 			}]);
 
 			const sessions = await provider.provideChatSessionItems(CancellationToken.None);
@@ -403,7 +407,8 @@ suite('LocalAgentsSessionsProvider', () => {
 					title: 'In Progress Session',
 					lastMessageDate: Date.now(),
 					isActive: true,
-					lastResponseState: ResponseModelState.Complete
+					lastResponseState: ResponseModelState.Complete,
+					timing: { startTime: 0, endTime: 1 }
 				}]);
 
 				const sessions = await provider.provideChatSessionItems(CancellationToken.None);
@@ -432,7 +437,8 @@ suite('LocalAgentsSessionsProvider', () => {
 					title: 'Completed Session',
 					lastMessageDate: Date.now(),
 					isActive: true,
-					lastResponseState: ResponseModelState.Complete
+					lastResponseState: ResponseModelState.Complete,
+					timing: { startTime: 0, endTime: 1 },
 				}]);
 
 				const sessions = await provider.provideChatSessionItems(CancellationToken.None);
@@ -460,7 +466,8 @@ suite('LocalAgentsSessionsProvider', () => {
 					title: 'Canceled Session',
 					lastMessageDate: Date.now(),
 					isActive: true,
-					lastResponseState: ResponseModelState.Complete
+					lastResponseState: ResponseModelState.Complete,
+					timing: { startTime: 0, endTime: 1 },
 				}]);
 
 				const sessions = await provider.provideChatSessionItems(CancellationToken.None);
@@ -488,7 +495,8 @@ suite('LocalAgentsSessionsProvider', () => {
 					title: 'Error Session',
 					lastMessageDate: Date.now(),
 					isActive: true,
-					lastResponseState: ResponseModelState.Complete
+					lastResponseState: ResponseModelState.Complete,
+					timing: { startTime: 0, endTime: 1 },
 				}]);
 
 				const sessions = await provider.provideChatSessionItems(CancellationToken.None);
@@ -532,6 +540,7 @@ suite('LocalAgentsSessionsProvider', () => {
 					lastMessageDate: Date.now(),
 					isActive: true,
 					lastResponseState: ResponseModelState.Complete,
+					timing: { startTime: 0, endTime: 1 },
 					stats: {
 						added: 30,
 						removed: 8,
@@ -575,7 +584,8 @@ suite('LocalAgentsSessionsProvider', () => {
 					title: 'No Stats Session',
 					lastMessageDate: Date.now(),
 					isActive: true,
-					lastResponseState: ResponseModelState.Complete
+					lastResponseState: ResponseModelState.Complete,
+					timing: { startTime: 0, endTime: 1 }
 				}]);
 
 				const sessions = await provider.provideChatSessionItems(CancellationToken.None);
@@ -604,7 +614,8 @@ suite('LocalAgentsSessionsProvider', () => {
 					title: 'Timing Session',
 					lastMessageDate: Date.now(),
 					isActive: true,
-					lastResponseState: ResponseModelState.Complete
+					lastResponseState: ResponseModelState.Complete,
+					timing: { startTime: modelTimestamp }
 				}]);
 
 				const sessions = await provider.provideChatSessionItems(CancellationToken.None);
@@ -626,7 +637,8 @@ suite('LocalAgentsSessionsProvider', () => {
 					title: 'History Timing Session',
 					lastMessageDate,
 					isActive: false,
-					lastResponseState: ResponseModelState.Complete
+					lastResponseState: ResponseModelState.Complete,
+					timing: { startTime: lastMessageDate }
 				}]);
 
 				const sessions = await provider.provideChatSessionItems(CancellationToken.None);
@@ -654,7 +666,8 @@ suite('LocalAgentsSessionsProvider', () => {
 					title: 'EndTime Session',
 					lastMessageDate: Date.now(),
 					isActive: true,
-					lastResponseState: ResponseModelState.Complete
+					lastResponseState: ResponseModelState.Complete,
+					timing: { startTime: 0, endTime: completedAt }
 				}]);
 
 				const sessions = await provider.provideChatSessionItems(CancellationToken.None);
@@ -681,7 +694,8 @@ suite('LocalAgentsSessionsProvider', () => {
 					title: 'Icon Session',
 					lastMessageDate: Date.now(),
 					isActive: true,
-					lastResponseState: ResponseModelState.Complete
+					lastResponseState: ResponseModelState.Complete,
+					timing: { startTime: 0, endTime: 1 }
 				}]);
 
 				const sessions = await provider.provideChatSessionItems(CancellationToken.None);

src/vs/workbench/contrib/chat/test/common/mockChatModel.ts

@@ -16,6 +16,7 @@ export class MockChatModel extends Disposable implements IChatModel {
 	readonly onDidChange = this._register(new Emitter<IChatChangeEvent>()).event;
 	readonly sessionId = '';
 	readonly timestamp = 0;
+	readonly timing = { startTime: 0 };
 	readonly initialLocation = ChatAgentLocation.Chat;
 	readonly title = '';
 	readonly hasCustomTitle = false;