Commit 139c2b5
committed
fix: catch ClosedResourceError in _handle_message error recovery path
When a client disconnects while a stateless streamable-HTTP server is
reading the request body, the exception handler in _handle_message tries
to send_log_message() back to the client. Since the write stream is
already closed, this raises ClosedResourceError, which crashes the
stateless session with an unhandled ExceptionGroup.
Wrap the send_log_message() call in a try/except for ClosedResourceError
and BrokenResourceError, matching the pattern already used throughout
streamable_http.py (lines 589, 915, 1011, 1020). Failing to notify a
disconnected client is expected and harmless.
Github-Issue: #2064
Reported-by: dannygoldstein1 parent 7ba41dc commit 139c2b5
File tree
2 files changed
+48
-5
lines changed- src/mcp/server/lowlevel
- tests/server
2 files changed
+48
-5
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
414 | 414 | | |
415 | 415 | | |
416 | 416 | | |
417 | | - | |
418 | | - | |
419 | | - | |
420 | | - | |
421 | | - | |
| 417 | + | |
| 418 | + | |
| 419 | + | |
| 420 | + | |
| 421 | + | |
| 422 | + | |
| 423 | + | |
| 424 | + | |
| 425 | + | |
| 426 | + | |
422 | 427 | | |
423 | 428 | | |
424 | 429 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | 2 | | |
| 3 | + | |
3 | 4 | | |
4 | 5 | | |
5 | 6 | | |
| |||
72 | 73 | | |
73 | 74 | | |
74 | 75 | | |
| 76 | + | |
| 77 | + | |
| 78 | + | |
| 79 | + | |
| 80 | + | |
| 81 | + | |
| 82 | + | |
| 83 | + | |
| 84 | + | |
| 85 | + | |
| 86 | + | |
| 87 | + | |
| 88 | + | |
| 89 | + | |
| 90 | + | |
| 91 | + | |
| 92 | + | |
| 93 | + | |
| 94 | + | |
| 95 | + | |
| 96 | + | |
| 97 | + | |
| 98 | + | |
| 99 | + | |
| 100 | + | |
| 101 | + | |
| 102 | + | |
| 103 | + | |
| 104 | + | |
| 105 | + | |
| 106 | + | |
| 107 | + | |
| 108 | + | |
| 109 | + | |
| 110 | + | |
| 111 | + | |
| 112 | + | |
0 commit comments