Fix some more MTA server crash handler issues:

- Use delete[] instead of delete for char array in CExceptionInformation_Impl destructor
- Use nothrow new with null check in HandleExceptionGlobal to avoid throwing when heap is corrupt
- Replace ctime with localtime_s and strftime to avoid static buffer reuse

Author: Dutchman101

Server/core/CCrashHandler.cpp

@@ -47,6 +47,7 @@ static SString ms_strDumpPath;
 
 #ifdef WIN32
     #include <ctime>
+    #include <new>
     #include <tchar.h>
     #include <dbghelp.h>
 
@@ -180,7 +181,12 @@ void CCrashHandler::HandleExceptionGlobal(int iSig)
 long WINAPI CCrashHandler::HandleExceptionGlobal(_EXCEPTION_POINTERS* pException)
 {
     // Create the exception information class
-    CExceptionInformation_Impl* pExceptionInformation = new CExceptionInformation_Impl;
+    CExceptionInformation_Impl* pExceptionInformation = new (std::nothrow) CExceptionInformation_Impl;
+    if (!pExceptionInformation)
+    {
+        TerminateProcess(GetCurrentProcess(), 1);
+        return EXCEPTION_CONTINUE_SEARCH;
+    }
     pExceptionInformation->Set(pException->ExceptionRecord->ExceptionCode, pException);
 
     // Write the dump
@@ -286,7 +292,12 @@ void CCrashHandler::DumpMiniDump(_EXCEPTION_POINTERS* pException, CExceptionInfo
 
                     SString strInfo;
                     strInfo += SString("Version = %s\n", strMTAVersionFull.c_str());
-                    strInfo += SString("Time = %s", ctime(&timeTemp));
+
+                    char szTimeBuf[64];
+                    struct tm tmLocal;
+                    localtime_s(&tmLocal, &timeTemp);
+                    strftime(szTimeBuf, sizeof(szTimeBuf), "%c\n", &tmLocal);
+                    strInfo += SString("Time = %s", szTimeBuf);
 
                     strInfo += SString("Module = %s\n", pExceptionInformation->GetModulePathName());
 

Server/core/CExceptionInformation_Impl.cpp

@@ -44,7 +44,7 @@ CExceptionInformation_Impl::CExceptionInformation_Impl()
 CExceptionInformation_Impl::~CExceptionInformation_Impl()
 {
     if (m_szModulePathName)
-        delete m_szModulePathName;
+        delete[] m_szModulePathName;
 }
 
 void CExceptionInformation_Impl::Set(unsigned int iCode, _EXCEPTION_POINTERS* pException)