cs

Author: dg

src/Bridges/DatabaseTracy/ConnectionPanel.php

@@ -31,7 +31,6 @@ class ConnectionPanel implements Tracy\IBarPanel
 	private float $totalTime = 0;
 	private int $count = 0;
 	private array $events = [];
-	private Tracy\BlueScreen $blueScreen;
 
 
 	public static function initialize(
@@ -58,10 +57,11 @@ public static function initialize(
 	}
 
 
-	public function __construct(Explorer $explorer, Tracy\BlueScreen $blueScreen)
-	{
+	public function __construct(
+		Explorer $explorer,
+		private readonly Tracy\BlueScreen $blueScreen,
+	) {
 		$explorer->onQuery[] = $this->logQuery(...);
-		$this->blueScreen = $blueScreen;
 	}
 
 

src/Database/Database.php

@@ -325,7 +325,7 @@ public function setAutoCommit(bool $state): void
 
 		$this->autoCommit = $state;
 		if (!$state && $this->connection) {
-			$$this->beginTransaction();
+			$this->beginTransaction();
 		}
 	}
 
@@ -381,9 +381,9 @@ public function preprocess(string $sql, ...$params): array
 	private function logOperation(\Closure $callback, SqlLiteral $query): Result
 	{
 		try {
-			$time = microtime(true);
+			$time = microtime(as_float: true);
 			$result = $callback();
-			$time = microtime(true) - $time;
+			$time = microtime(as_float: true) - $time;
 		} catch (DriverException $e) {
 			$e = $this->convertException($e);
 			Arrays::invoke($this->onQuery, $this, $e);

src/Database/Drivers/Accessory/LazyConnection.php

@@ -15,7 +15,7 @@
 final class LazyConnection implements Drivers\Connection
 {
 	public function __construct(
-		private \Closure $callback,
+		private readonly \Closure $callback,
 	) {
 	}
 

src/Database/Drivers/Engines/SQLiteEngine.php

@@ -237,7 +237,7 @@ public function getForeignKeys(string $table): array
 
 	public function convertToPhp(mixed $value, array $meta, TypeConverter $converter): mixed
 	{
-		return $converter->convertDateTime && in_array($meta['nativeType'], ['DATE', 'DATETIME'], true)
+		return $converter->convertDateTime && in_array($meta['nativeType'], ['DATE', 'DATETIME'], strict: true)
 			? (is_int($value) ? (new DateTime)->setTimestamp($value) : new DateTime($value))
 			: $converter->convertToPhp($value, $meta);
 	}

src/Database/Explorer.php

@@ -21,8 +21,6 @@
  */
 class Explorer extends Database
 {
-
-
 	/** @internal */
 	public function createActiveRow(Table\Selection $selection, array $row): Table\ActiveRow
 	{

src/Database/Result.php

@@ -30,7 +30,7 @@ public function __construct(
 		private readonly Explorer $explorer,
 		private readonly SqlLiteral $query,
 		private readonly ?Drivers\Result $result,
-		private float $time,
+		private readonly float $time,
 	) {
 	}
 

src/Database/Table/GroupedSelection.php

@@ -20,15 +20,9 @@
  */
 class GroupedSelection extends Selection
 {
-	/** referenced table */
-	protected readonly Selection $refTable;
-
 	/** current assigned referencing array */
 	protected mixed $refCacheCurrent;
 
-	/** grouping column name */
-	protected readonly string $column;
-
 	/** primary key */
 	protected int|string $active;
 
@@ -39,11 +33,11 @@ class GroupedSelection extends Selection
 	public function __construct(
 		Explorer $explorer,
 		string $tableName,
-		string $column,
-		Selection $refTable,
+		/** grouping column name */
+		protected readonly string $column,
+		/** referenced table */
+		protected readonly Selection $refTable,
 	) {
-		$this->refTable = $refTable;
-		$this->column = $column;
 		parent::__construct($explorer, $tableName);
 	}
 

src/Database/Table/Selection.php

@@ -669,7 +669,7 @@ protected function getSpecificCacheKey(): string
 
 	/**
 	 * @internal
-	 * @param  string|null column name or null to reload all columns
+	 * @param  string|null  $key column name or null to reload all columns
 	 * @return bool if selection requeried for more columns.
 	 */
 	public function accessColumn(?string $key, bool $selectColumn = true): bool

tests/Database/sqlsrv-loadFromFile.phpt

@@ -14,5 +14,5 @@ require __DIR__ . '/../bootstrap.php';
 $connection = connectToDB();
 
 Assert::noError(
-	fn() => Nette\Database\Helpers::loadFromFile($connection, __DIR__ . '/files/sqlsrv-loadFromFile.sql')
+	fn() => Nette\Database\Helpers::loadFromFile($connection, __DIR__ . '/files/sqlsrv-loadFromFile.sql'),
 );