Address review comments; add docs

Author: KevinEady

doc/date.md

@@ -37,6 +37,20 @@ static Napi::Date Napi::Date::New(Napi::Env env, double value);
 
 Returns a new instance of `Napi::Date` object.
 
+### New
+
+Creates a new instance of a `Napi::Date` object.
+
+```cpp
+static Napi::Date Napi::Date::New(napi_env env, std::chrono::system_clock::time_point time_point);
+```
+
+ - `[in] env`: The environment in which to construct the `Napi::Date` object.
+ - `[in] value`: The point in time, represented by an
+   `std::chrono::system_clock::time_point`.
+
+Returns a new instance of `Napi::Date` object.
+
 ### ValueOf
 
 ```cpp

napi-inl.h

@@ -20,9 +20,6 @@
 #endif  // NAPI_HAS_THREADS
 #include <type_traits>
 #include <utility>
-#if __cplusplus >= 201103L
-#include <chrono>
-#endif
 
 #if defined(__clang__) || defined(__GNUC__)
 #define NAPI_NO_SANITIZE_VPTR __attribute__((no_sanitize("vptr")))
@@ -1202,14 +1199,12 @@ inline Date Date::New(napi_env env, double val) {
   return Date(env, value);
 }
 
-#if __cplusplus >= 201103L
 inline Date Date::New(napi_env env, std::chrono::system_clock::time_point tp) {
   using namespace std::chrono;
   auto ms = static_cast<double>(
       duration_cast<milliseconds>(tp.time_since_epoch()).count());
   return Date::New(env, ms);
 }
-#endif
 
 inline void Date::CheckCast(napi_env env, napi_value value) {
   NAPI_CHECK(value != nullptr, "Date::CheckCast", "empty value");

napi.h

@@ -17,11 +17,9 @@
 #if NAPI_HAS_THREADS
 #include <mutex>
 #endif  // NAPI_HAS_THREADS
+#include <chrono>
 #include <string>
 #include <vector>
-#if __cplusplus >= 201103L
-#include <chrono>
-#endif
 
 // VS2015 RTM has bugs with constexpr, so require min of VS2015 Update 3 (known
 // good version)
@@ -690,8 +688,8 @@ class Date : public Value {
 
   /// Creates a new Date value from a std::chrono::system_clock::time_point.
   static Date New(
-      napi_env env,                             ///< Node-API environment
-      std::chrono::system_clock::time_point tp  ///< Time point value
+      napi_env env,  ///< Node-API environment
+      std::chrono::system_clock::time_point time_point  ///< Time point value
   );
 
   static void CheckCast(napi_env env, napi_value value);

test/date.cc

@@ -1,7 +1,3 @@
-#if __cplusplus >= 201103L
-#include <chrono>
-#endif
-
 #include "napi.h"
 
 using namespace Napi;
@@ -15,12 +11,10 @@ Value CreateDate(const CallbackInfo& info) {
   return Date::New(info.Env(), input);
 }
 
-#if __cplusplus >= 201103L
 Value CreateDateFromTimePoint(const CallbackInfo& info) {
   auto input = std::chrono::system_clock::time_point{};
   return Date::New(info.Env(), input);
 }
-#endif
 
 Value IsDate(const CallbackInfo& info) {
   Date input = info[0].As<Date>();
@@ -46,7 +40,8 @@ Value OperatorValue(const CallbackInfo& info) {
 Object InitDate(Env env) {
   Object exports = Object::New(env);
   exports["CreateDate"] = Function::New(env, CreateDate);
-  exports["CreateDateFromTimePoint"] = Function::New(env, CreateDate);
+  exports["CreateDateFromTimePoint"] =
+      Function::New(env, CreateDateFromTimePoint);
   exports["IsDate"] = Function::New(env, IsDate);
   exports["ValueOf"] = Function::New(env, ValueOf);
   exports["OperatorValue"] = Function::New(env, OperatorValue);

test/date.js

@@ -9,7 +9,8 @@ function test (binding) {
     CreateDate,
     IsDate,
     ValueOf,
-    OperatorValue
+    OperatorValue,
+    CreateDateFromTimePoint
   } = binding.date;
   assert.deepStrictEqual(CreateDate(0), new Date(0));
   assert.deepStrictEqual(CreateDateFromTimePoint(), new Date(0));