-
Notifications
You must be signed in to change notification settings - Fork 1
Closed as duplicate of#398
Closed as duplicate of#398
Copy link
Labels
change-proposalProposal for a new changeProposal for a new changeenhancementNew feature or requestNew feature or request
Description
Change: specfact-code-review Module Scaffold with Pydantic Models
Why
The current coding automation pipeline runs a generic codex review pass but has no structured scoring, no persistent quality ledger, and no contract-bound enforcement gates. A dedicated nold-ai/specfact-code-review installable module closes these gaps by providing a governed entry point for all code-review subcommands under specfact code review.
This change establishes the foundation: the module package scaffold, the governance-01-compatible evidence envelope (ReviewReport), the ReviewFinding Pydantic model, and the scoring algorithm - everything SP-002 through SP-009 depend on.
What Changes
- NEW:
packages/specfact-code-review/module package inspecfact-cli-modules - NEW:
module-package.yamlwithbundle_group_command: code, tierofficial,core_compatibility: >=0.40.0,<1.0.0 - NEW:
ReviewFindingPydantic model with fields for category, severity, tool, rule, file, line, message, and fixable - NEW:
ReviewReportgovernance-01-compatible evidence envelope with scoring extensions - NEW:
scorer.pyscoring algorithm withreward_delta = score - 80 - NEW: Typer app wired to extend
specfact codewith areviewsubgroup - NEW: Unit tests for
ReviewFinding,ReviewReport, andscorer.py
OpenSpec Change Proposal: code-review-01-module-scaffold
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
change-proposalProposal for a new changeProposal for a new changeenhancementNew feature or requestNew feature or request