From 020cde68ff77fcd38e7df5bd50a1df8255775365 Mon Sep 17 00:00:00 2001 From: Vordgi Date: Thu, 21 May 2026 21:37:23 +0100 Subject: [PATCH 1/5] feat: add nodejs noodle --- app/components/Noodle/Nodejs/Logo.vue | 90 +++++++++++++++++++++++++++ app/components/Noodle/Press/Logo.vue | 19 ------ app/components/Noodle/index.ts | 11 ++-- test/nuxt/a11y.spec.ts | 4 +- 4 files changed, 97 insertions(+), 27 deletions(-) create mode 100644 app/components/Noodle/Nodejs/Logo.vue delete mode 100644 app/components/Noodle/Press/Logo.vue diff --git a/app/components/Noodle/Nodejs/Logo.vue b/app/components/Noodle/Nodejs/Logo.vue new file mode 100644 index 0000000000..ba2a5e4fd8 --- /dev/null +++ b/app/components/Noodle/Nodejs/Logo.vue @@ -0,0 +1,90 @@ + diff --git a/app/components/Noodle/Press/Logo.vue b/app/components/Noodle/Press/Logo.vue deleted file mode 100644 index 97a078acaa..0000000000 --- a/app/components/Noodle/Press/Logo.vue +++ /dev/null @@ -1,19 +0,0 @@ - diff --git a/app/components/Noodle/index.ts b/app/components/Noodle/index.ts index abeef9a132..df7fe3c894 100644 --- a/app/components/Noodle/index.ts +++ b/app/components/Noodle/index.ts @@ -1,5 +1,5 @@ import NoodleKawaiiLogo from './Kawaii/Logo.vue' -import NoodlePressLogo from './Press/Logo.vue' +import NoodleNodejsLogo from './Nodejs/Logo.vue' export type Noodle = { // Unique identifier for the noodle @@ -28,11 +28,10 @@ export const PERMANENT_NOODLES: Noodle[] = [ // Active noodles - shown based on date and timezone export const ACTIVE_NOODLES: Noodle[] = [ { - key: 'press', - logo: NoodlePressLogo, - date: '2026-05-01', - dateTo: '2026-05-04', + key: 'nodejs', + logo: NoodleNodejsLogo, + date: '2026-05-21', + dateTo: '2026-05-28', timezone: 'auto', - tagline: false, }, ] diff --git a/test/nuxt/a11y.spec.ts b/test/nuxt/a11y.spec.ts index 5d0865d77f..551210b163 100644 --- a/test/nuxt/a11y.spec.ts +++ b/test/nuxt/a11y.spec.ts @@ -158,7 +158,7 @@ import { ButtonBase, LandingIntroHeader, NoodleKawaiiLogo, - NoodlePressLogo, + NoodleNodejsLogo, LinkBase, CallToAction, ChangelogCard, @@ -374,7 +374,7 @@ describe('component accessibility audits', () => { }) it('should have no accessibility violations', async () => { - const component = await mountSuspended(NoodlePressLogo) + const component = await mountSuspended(NoodleNodejsLogo) const results = await runAxe(component) expect(results.violations).toEqual([]) }) From 3d1419cbd89f92edc387d4a248c57aee4228cae2 Mon Sep 17 00:00:00 2001 From: Vordgi Date: Thu, 21 May 2026 21:42:52 +0100 Subject: [PATCH 2/5] feat: ignore color-scheme-img in knip --- knip.ts | 1 + 1 file changed, 1 insertion(+) diff --git a/knip.ts b/knip.ts index db09e209c1..f4adb33651 100644 --- a/knip.ts +++ b/knip.ts @@ -45,6 +45,7 @@ const config: KnipConfig = { ignoreFiles: [ 'app/components/Tooltip/Announce.vue', 'app/components/UserCombobox.vue', + 'app/components/ColorScheme/Img.vue', '**/*.unused.*', ], }, From 666fd4acc44f1d8d8d93b1f7b4d87494a8ccfbd6 Mon Sep 17 00:00:00 2001 From: Vordgi Date: Thu, 21 May 2026 21:43:40 +0100 Subject: [PATCH 3/5] chore: add rel to noodle link --- app/components/Noodle/Nodejs/Logo.vue | 1 + 1 file changed, 1 insertion(+) diff --git a/app/components/Noodle/Nodejs/Logo.vue b/app/components/Noodle/Nodejs/Logo.vue index ba2a5e4fd8..9b21d9fa3d 100644 --- a/app/components/Noodle/Nodejs/Logo.vue +++ b/app/components/Noodle/Nodejs/Logo.vue @@ -8,6 +8,7 @@ // github.com/nodejs/node-v0.x-archive/releases/tag/v0.0.1 From 895753d1ac637b70dd9808d865dbd406a109c5b1 Mon Sep 17 00:00:00 2001 From: Vordgi Date: Thu, 21 May 2026 21:47:19 +0100 Subject: [PATCH 4/5] fix: improve tooltip attrs logic --- app/components/Noodle/Nodejs/Logo.vue | 2 +- app/components/Tooltip/App.vue | 4 +++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/app/components/Noodle/Nodejs/Logo.vue b/app/components/Noodle/Nodejs/Logo.vue index 9b21d9fa3d..0955de19a8 100644 --- a/app/components/Noodle/Nodejs/Logo.vue +++ b/app/components/Noodle/Nodejs/Logo.vue @@ -1,5 +1,5 @@