Description
The builder feature's install script contains an unused INSTALL_DEPENDENCIES variable that appears to be a copy-paste artifact from the bosh-cli script.
Current State
File: src/builder/install.sh
- Line 4:
: ${INSTALL_DEPENDENCIES:=true} - defined but never used
Analysis
The builder tool is a simple static site generation binary that only requires:
curl and ca-certificates for downloading
- Basic file operations for installation
Unlike bosh-cli which installs additional development dependencies (build-essential, ruby, etc.), the builder feature doesn't need any optional dependencies, making the INSTALL_DEPENDENCIES variable unnecessary.
Proposed Solution
Remove the unused variable from line 4:
# Remove this line:
: ${INSTALL_DEPENDENCIES:=true}
Files Affected
src/builder/install.sh (line 4)
Context
This appears to be a copy-paste oversight where the variable was copied from bosh-cli/install.sh but the corresponding functionality was never implemented (and isn't needed for this feature).
Description
The
builderfeature's install script contains an unusedINSTALL_DEPENDENCIESvariable that appears to be a copy-paste artifact from thebosh-cliscript.Current State
File:
src/builder/install.sh: ${INSTALL_DEPENDENCIES:=true}- defined but never usedAnalysis
The
buildertool is a simple static site generation binary that only requires:curlandca-certificatesfor downloadingUnlike
bosh-cliwhich installs additional development dependencies (build-essential, ruby, etc.), thebuilderfeature doesn't need any optional dependencies, making theINSTALL_DEPENDENCIESvariable unnecessary.Proposed Solution
Remove the unused variable from line 4:
Files Affected
src/builder/install.sh(line 4)Context
This appears to be a copy-paste oversight where the variable was copied from
bosh-cli/install.shbut the corresponding functionality was never implemented (and isn't needed for this feature).